| Message ID | 20230714180636.644049-1-ktraynor@redhat.com |
|---|---|
| Headers | show |
| Series | PMD load based sleep updates | expand |
On 7/14/23 20:06, Kevin Traynor wrote: > Patches are about adding some visiblity and preparing for > new functionality in a later series. > > Patch 1 renames 'pmd-maxsleep' to 'pmd-sleep-max'. To soften > the change over, 'pmd-maxsleep' is deprecated and may still be used. > > v4 > - Drop patches 5-6 (per-pmd control) from this series to split into > a separate series as it's close to OVS 3.2 and they require more > rework and need to be tested again. > - Resolved comments on v3 for patches 1-4 (Ilya) > - 1/4 Decided to soften removal of 'pmd-maxsleep' to a deprecation. If it is > set, a deprecation warning will be displayed and it will only be used if > 'pmd-sleep-max' is not present. > - 1/4 Wasn't sure whether to keep David's RvB and he is not available, > but the goal of the patch is the same, it's just not done as quickly, so on > balance will keep it. We can remove it if anyone thinks we should but otherwise > blame me, not David if it's broken ;-) > - 3/4 Changed format of pmd-sleep-show as per comments related to later > patches > > v3 > - Rebased NEWS > - 1/6 Added warning for use of pmd-maxsleep (Simon) > - 5/6 Minor changes (David) > > v2 > - 2/6 fixed UT macro > - 3/6 rebased NEWS confict > - 3/6 moved pmd_max_sleep_show() location > - 6/6 removed incorrect check > > GHA: https://github.com/kevintraynor/ovs/actions/runs/5556620548 > > Kevin Traynor (4): > dpif-netdev: Rename pmd-maxsleep config option. > pmd.at: Add macro for checking pmd sleep max time and state. > dpif-netdev: Add pmd-sleep-show command. > dpif-netdev: Remove pmd-sleep-max experimental tag. > > Documentation/topics/dpdk/pmd.rst | 15 +++++-- > NEWS | 5 +++ > lib/dpif-netdev.c | 34 +++++++++++--- > tests/pmd.at | 73 ++++++++++++++++++++++--------- > vswitchd/vswitch.xml | 2 +- > 5 files changed, 99 insertions(+), 30 deletions(-) > Hi, Kevin. The patch #3 is definitely written in a more "forward looking" way than necessary. :) But since there is a plan to add per-pmd config in a near future, that should be fine. Applied. Thanks! Best regards, Ilya Maximets.