mbox series

[ovs-dev,v5,0/2] netdev-dpdk: Apply device rx/tx descriptor limits.

Message ID 20230526085712.411852-1-ktraynor@redhat.com
Headers show
Series netdev-dpdk: Apply device rx/tx descriptor limits. | expand

Message

Kevin Traynor May 26, 2023, 8:57 a.m. UTC
v5:
- Moved num of descriptors validation so not dependent on flow ctrl
- Updated log message when num of descriptors adjusted
- Minor whitespace
- Kept Reviewed-by: tags as minor edits

v4:
- Fixed case where sizes change but limits are not applied (David)
- Use actual device desc sizes to decide to trigger reconfig
- Add log at debug level for case where adjustment has been made but a reconfig is not
  required (i.e. device already configured with adjusted value)

v3:
- Changed get_config to remove duplicate rxq/txq sizes
- Simplified by going back to just 'requested_rxq/txq_size' and
  'rxq/txq_size' and dropped adding 'adjusted'
- Moved logging to dpdk_process_queue_size()
- Removed Acks as the code has changed a bit

GHA: https://github.com/kevintraynor/ovs/actions/runs/5080346858

Kevin Traynor (2):
  netdev-dpdk: Remove requested descriptors from get_config.
  netdev-dpdk: Check rx/tx descriptor sizes for device.

 lib/netdev-dpdk.c | 70 ++++++++++++++++++++++++++++++++++-------------
 1 file changed, 51 insertions(+), 19 deletions(-)

Comments

Ilya Maximets May 26, 2023, 8:52 p.m. UTC | #1
On 5/26/23 10:57, Kevin Traynor wrote:
> v5:
> - Moved num of descriptors validation so not dependent on flow ctrl
> - Updated log message when num of descriptors adjusted
> - Minor whitespace
> - Kept Reviewed-by: tags as minor edits
> 
> v4:
> - Fixed case where sizes change but limits are not applied (David)
> - Use actual device desc sizes to decide to trigger reconfig
> - Add log at debug level for case where adjustment has been made but a reconfig is not
>   required (i.e. device already configured with adjusted value)
> 
> v3:
> - Changed get_config to remove duplicate rxq/txq sizes
> - Simplified by going back to just 'requested_rxq/txq_size' and
>   'rxq/txq_size' and dropped adding 'adjusted'
> - Moved logging to dpdk_process_queue_size()
> - Removed Acks as the code has changed a bit
> 
> GHA: https://github.com/kevintraynor/ovs/actions/runs/5080346858
> 
> Kevin Traynor (2):
>   netdev-dpdk: Remove requested descriptors from get_config.
>   netdev-dpdk: Check rx/tx descriptor sizes for device.
> 
>  lib/netdev-dpdk.c | 70 ++++++++++++++++++++++++++++++++++-------------
>  1 file changed, 51 insertions(+), 19 deletions(-)
> 

Applied.  Thanks!

Best regards, Ilya Maximets.