mbox series

[ovs-dev,v5,0/2] MFEX Hashing Optimizations

Message ID 20220112161107.1463714-1-harry.van.haaren@intel.com
Headers show
Series MFEX Hashing Optimizations | expand

Message

Van Haaren, Harry Jan. 12, 2022, 4:11 p.m. UTC 
Following from the MFEX Optimizations IPv6 + Hashing patchset,
https://patchwork.ozlabs.org/project/openvswitch/list/?series=275590

This patchset introduces the optimization as described at OVS Conference;
https://www.openvswitch.org/support/ovscon2021/#T32
https://youtu.be/X_uPybauF3g?list=PLaJlRa-xItwARDGAUp7lXviOgOhcRxSU-&t=976

The optimizations allow for simpler compute to hash the packet data, and
the mfex autovalidator is updated to compare resulting hash values. This
ensures that the hash values from optimized and scalar hashing functions
are always identical.

v5:
- Force autovalidator to always calculate and validate hash value.
- Rename "len" variable in mfex profile describe its use better.

See here for previous versions of this patchset;
https://patchwork.ozlabs.org/project/openvswitch/cover/20211207110425.3873101-1-kumar.amber@intel.com/


Kumar Amber (2):
  dpif-netdev/mfex: Add ipv4 profile based hashing
  dpif-netdev/mfex: Optimize packet hash and enable autovalidator

 NEWS                              |  2 +-
 lib/dpif-netdev-avx512.c          |  6 +--
 lib/dpif-netdev-extract-avx512.c  | 65 +++++++++++++++++++++++++++++++
 lib/dpif-netdev-private-extract.c | 19 +++++++++
 4 files changed, 88 insertions(+), 4 deletions(-)

Comments

Finn, Emma Jan. 13, 2022, 1:31 p.m. UTC | #1 
> -----Original Message-----
> From: dev <ovs-dev-bounces@openvswitch.org> On Behalf Of Harry van Haaren
> Sent: Wednesday 12 January 2022 16:11
> To: ovs-dev@openvswitch.org
> Cc: Amber, Kumar <kumar.amber@intel.com>; i.maximets@ovn.org
> Subject: [ovs-dev] [PATCH v5 0/2] MFEX Hashing Optimizations
> 
> Following from the MFEX Optimizations IPv6 + Hashing patchset,
> https://patchwork.ozlabs.org/project/openvswitch/list/?series=275590
> 
> This patchset introduces the optimization as described at OVS Conference;
> https://www.openvswitch.org/support/ovscon2021/#T32
> https://youtu.be/X_uPybauF3g?list=PLaJlRa-xItwARDGAUp7lXviOgOhcRxSU-
> &t=976
> 
> The optimizations allow for simpler compute to hash the packet data, and the
> mfex autovalidator is updated to compare resulting hash values. This ensures
> that the hash values from optimized and scalar hashing functions are always
> identical.
> 
> v5:
> - Force autovalidator to always calculate and validate hash value.
> - Rename "len" variable in mfex profile describe its use better.
> 
> See here for previous versions of this patchset;
> https://patchwork.ozlabs.org/project/openvswitch/cover/20211207110425.387
> 3101-1-kumar.amber@intel.com/
> 
Hi, 

Tested this series by intentionally breaking SIMD implementation and ensuring the autovalidator will fail and report these errors. Also verified that autovalidator will succeed when supported packet types are sent.

Tested-by: Emma Finn <emma.finn@intel.com>

> 
> Kumar Amber (2):
>   dpif-netdev/mfex: Add ipv4 profile based hashing
>   dpif-netdev/mfex: Optimize packet hash and enable autovalidator
> 
>  NEWS                              |  2 +-
>  lib/dpif-netdev-avx512.c          |  6 +--
>  lib/dpif-netdev-extract-avx512.c  | 65 +++++++++++++++++++++++++++++++
> lib/dpif-netdev-private-extract.c | 19 +++++++++
>  4 files changed, 88 insertions(+), 4 deletions(-)
> 
> --
> 2.25.1
> 
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev