Message ID | 20200430183131.12099.85379.stgit@dceara.remote.csb |
---|---|
Headers | show
Return-Path: <ovs-dev-bounces@openvswitch.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BF3eB5sO; dkim-atps=neutral Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49CkW80DxPz9sRY for <incoming@patchwork.ozlabs.org>; Fri, 1 May 2020 04:32:03 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id BE9598886C; Thu, 30 Apr 2020 18:32:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N+ueZmiSmwHT; Thu, 30 Apr 2020 18:31:58 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 50C95884DD; Thu, 30 Apr 2020 18:31:58 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 236E7C0864; Thu, 30 Apr 2020 18:31:58 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id C1DC8C016F for <dev@openvswitch.org>; Thu, 30 Apr 2020 18:31:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id B94C0886A5 for <dev@openvswitch.org>; Thu, 30 Apr 2020 18:31:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HW90KhlZI4pX for <dev@openvswitch.org>; Thu, 30 Apr 2020 18:31:56 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by hemlock.osuosl.org (Postfix) with ESMTPS id 025D7884DD for <dev@openvswitch.org>; Thu, 30 Apr 2020 18:31:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588271514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=clAsAi61T2IV3YPnmlPcE7Ja8zu/kfH79GejpDNuxyM=; b=BF3eB5sO+4jqDtsCIyTtS1LluDkP403s4pt0ZjmlAgCgvZmPAmB1fjEzp71SQq71yyehlk fr243UDsqhWsHvjB6rHH9kVzPC6zZgGigSRRfKaxzb1eFLdJhRseb0SNHFIFuOgP4ChFQ2 GkdaGjF5yLIY0KEjk4yfPpV2HIZI8jQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-296-q-ExjV3wO1W_a8ss-P1DYA-1; Thu, 30 Apr 2020 14:31:53 -0400 X-MC-Unique: q-ExjV3wO1W_a8ss-P1DYA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2CAC9107ACCD for <dev@openvswitch.org>; Thu, 30 Apr 2020 18:31:52 +0000 (UTC) Received: from dceara.remote.csb (ovpn-115-51.ams2.redhat.com [10.36.115.51]) by smtp.corp.redhat.com (Postfix) with ESMTP id 97F07605DE for <dev@openvswitch.org>; Thu, 30 Apr 2020 18:31:51 +0000 (UTC) From: Dumitru Ceara <dceara@redhat.com> To: dev@openvswitch.org Date: Thu, 30 Apr 2020 20:31:46 +0200 Message-Id: <20200430183131.12099.85379.stgit@dceara.remote.csb> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [ovs-dev] [PATCH v3 ovn 0/2] Make ovn-northd recover from NB/SB inconsistencies. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: <ovs-dev.openvswitch.org> List-Unsubscribe: <https://mail.openvswitch.org/mailman/options/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe> List-Archive: <http://mail.openvswitch.org/pipermail/ovs-dev/> List-Post: <mailto:ovs-dev@openvswitch.org> List-Help: <mailto:ovs-dev-request@openvswitch.org?subject=help> List-Subscribe: <https://mail.openvswitch.org/mailman/listinfo/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" <ovs-dev-bounces@openvswitch.org> |
Series |
Make ovn-northd recover from NB/SB inconsistencies.
|
expand
|
The patches in this series address the following issues: - patch 1: ovn-northd generates transactions that trigger referential integrity violations due to stale Datapath_Binding records in the SB database. - patch 2: ovn-northd generates transactions that trigger index uniqueness constraint violations due to reusing of stale tunnel_key values in Port_Binding table records. Reported-by: Dan Williams <dcbw@redhat.com> Reported-at: https://bugzilla.redhat.com/1828637 Signed-off-by: Dumitru Ceara <dceara@redhat.com> Dumitru Ceara (2): ovn-northd: Clear SB records depending on stale datapaths. ovn-northd: Fix tunnel_key allocation for SB Port_Bindings. northd/ovn-northd.c | 51 ++++++++++++++++++++++----------- tests/ovn-northd.at | 80 +++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 115 insertions(+), 16 deletions(-) --- V3: - reworked patch #2 to delete/add the stale PB. - removed patch #3 as it's not needed anymore. - merged HA_Chassis_Group unit test in patch #2. V2: - add patch #3 to handle stale HA_Chassis_Group references. - add unit tests. - call cleanup_mac_bindings() also when stale Port_Bindings are reused. - rephrase commit messages.