mbox series

[ovs-dev,ovn,v1,0/1] NAT: Enhancements to external port range support

Message ID 20200415221006.22628-1-flavio@flaviof.com
Headers show
Series NAT: Enhancements to external port range support | expand

Message

Flaviof April 15, 2020, 10:10 p.m. UTC 
Hi folks,

It took me long enough, but I finally got to sit down and look at the nice
changes that Ankur Sharma did to make OVN capable of providing a port range
in the OVN NB schema. Trouble is, the changes are already merged, so I
decided to submit this follow up a patch with the changes that would
otherwise be my review comments. I hope it is not too late. :^)

Among the comments, I really thought it would be important to provide show
output of the configuration for the external port range. That turned out to
be the bulk of the changes being proposed here.

Examples of how the output of NAT with external port range looks like:

[root@ovn-central /]# sudo ovn-nbctl show lr0
router 1d409abe-751f-4251-a6af-5a6858a10d7c (lr0)
<snip>
    nat 2618d410-1d73-4ff3-8164-744ff1709e3d
        external ip: "172.16.0.100"
        logical ip: "20.0.0.0/24"
        type: "snat"
    nat 598b6495-928a-4053-b2ae-f2e8d4ae31f5
        external ip: "172.16.0.110"
        external port(s): "8080"     <=== NEW
        logical ip: "10.0.0.3"
        type: "dnat_and_snat"
    nat fa9c5f8c-1c42-44a0-b9c5-3a4fb799c75d
        external ip: "172.16.0.100"
        external port(s): "123-456"  <=== NEW
        logical ip: "10.0.0.0/24"
        type: "snat"

[root@ovn-central /]# ovn-nbctl lr-nat-list lr0
TYPE             EXTERNAL_IP        EXTERNAL_PORT    LOGICAL_IP            EXTERNAL_MAC         LOGICAL_PORT
dnat_and_snat    172.16.0.110       8080             10.0.0.3              30:54:00:00:00:03    sw0-port1
snat             172.16.0.100       123-456          10.0.0.0/24
snat             172.16.0.100                        20.0.0.0/24



Flavio Fernandes (1):
  NAT: Enhancements to external port range support

 NEWS                  |   1 +
 lib/actions.c         |   5 +-
 northd/ovn-northd.c   |   8 +--
 ovn-nb.xml            |   2 +-
 tests/ovn-nbctl.at    | 130 ++++++++++++++++++++++++++----------------
 tests/ovn.at          |   4 +-
 utilities/ovn-nbctl.c |  27 ++++++---
 7 files changed, 112 insertions(+), 65 deletions(-)