mbox series

[ovs-dev,V4,0/2] Do not rewrite fields with the same values as matched

Message ID 20190215084842.21427-1-elibr@mellanox.com
Headers show
Series Do not rewrite fields with the same values as matched | expand

Message

Eli Britstein Feb. 15, 2019, 8:48 a.m. UTC 
This patch set avoids unnecessary rewrite actions to fields with the
same values as matched on.

Patch 1 is a pre-step of generating ovs key fields macros
Patch 2 avoids the unnecessary rewrites and adapts the tests accordingly

I see tests 1219-1220 fail, but also failed witout those patches.
The difference from V3 is rebasing, adding struct ovs_key_nd_extensions
support.

Thanks,
Eli

Eli Britstein (2):
  Makefiles: Generate datapath ovs key fields macros
  odp-util: Do not rewrite fields with the same values as matched

 .gitignore                              |   1 +
 build-aux/extract-odp-netlink-xmacros-h |  56 +++++++++++
 include/automake.mk                     |  11 ++-
 lib/odp-util.c                          | 122 +++++++++++++++++++++---
 tests/mpls-xlate.at                     |   2 +-
 tests/ofproto-dpif.at                   |  14 +--
 6 files changed, 183 insertions(+), 23 deletions(-)
 create mode 100755 build-aux/extract-odp-netlink-xmacros-h

Comments

Ben Pfaff Feb. 15, 2019, 5:09 p.m. UTC | #1 
On Fri, Feb 15, 2019 at 08:48:40AM +0000, Eli Britstein wrote:
> I see tests 1219-1220 fail, but also failed witout those patches.
> The difference from V3 is rebasing, adding struct ovs_key_nd_extensions
> support.

I don't see any test failures with or without the patch.  Sometimes
there can be test failures due to races that are hard to avoid, but in
those cases the failures do not occur every time the test runs.  If the
test failures you see are reproducible, can you send the testsuite.log
so we can take a look?  (Even better: try to fix them yourself, if you
have time and the inclination.)