mbox series

[ovs-dev,v2,0/3] Port Group fixes

Message ID 20180730143749.8173-1-jkbs@redhat.com
Headers show
Series Port Group fixes | expand

Message

Jakub Sitnicki July 30, 2018, 2:37 p.m. UTC 
This series addresses two issues noticed with Port Groups:

(1) Port Group name cannot be used to refer to a row in NB DB.
(2) LSP dynamic addresses don't get copied to port group address sets.

The series depends on recent fixes for IPAM from Mark Michelson [1].

Thanks,
Jakub

[1] https://patchwork.ozlabs.org/patch/947155/

v1 -> v2:
- Check if LSP addresses are static before treating them as such to avoid a
  warning. Reported by Han Zhou.


Jakub Sitnicki (3):
  ovn-nbctl: Allow referring to port groups by name.
  ovn-northd: Make use of svec for storing lists of addresses.
  ovn-northd: Propagate dynamic addresses to port group address sets.

 ovn/northd/ovn-northd.c   |  77 ++++++++++++++++----------------
 ovn/utilities/ovn-nbctl.c |   3 ++
 tests/ovn-nbctl.at        |  14 ++++++
 tests/ovn.at              | 109 ++++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 164 insertions(+), 39 deletions(-)

--
2.14.4

Comments

Mark Michelson July 30, 2018, 2:49 p.m. UTC | #1 
Wow bad timing on my part for my review of v1.

Acked-by: Mark Michelson <mmichels@redhat.com>

On 07/30/2018 10:37 AM, Jakub Sitnicki wrote:
> This series addresses two issues noticed with Port Groups:
> 
> (1) Port Group name cannot be used to refer to a row in NB DB.
> (2) LSP dynamic addresses don't get copied to port group address sets.
> 
> The series depends on recent fixes for IPAM from Mark Michelson [1].
> 
> Thanks,
> Jakub
> 
> [1] https://patchwork.ozlabs.org/patch/947155/
> 
> v1 -> v2:
> - Check if LSP addresses are static before treating them as such to avoid a
>    warning. Reported by Han Zhou.
> 
> 
> Jakub Sitnicki (3):
>    ovn-nbctl: Allow referring to port groups by name.
>    ovn-northd: Make use of svec for storing lists of addresses.
>    ovn-northd: Propagate dynamic addresses to port group address sets.
> 
>   ovn/northd/ovn-northd.c   |  77 ++++++++++++++++----------------
>   ovn/utilities/ovn-nbctl.c |   3 ++
>   tests/ovn-nbctl.at        |  14 ++++++
>   tests/ovn.at              | 109 ++++++++++++++++++++++++++++++++++++++++++++++
>   4 files changed, 164 insertions(+), 39 deletions(-)
> 
> --
> 2.14.4
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
Ben Pfaff July 31, 2018, 7:25 p.m. UTC | #2 
I applied this series to master and branch-2.10.  Thank you!

If it should be backported to branch-2.9, let me know.

On Mon, Jul 30, 2018 at 04:37:46PM +0200, Jakub Sitnicki wrote:
> This series addresses two issues noticed with Port Groups:
> 
> (1) Port Group name cannot be used to refer to a row in NB DB.
> (2) LSP dynamic addresses don't get copied to port group address sets.
> 
> The series depends on recent fixes for IPAM from Mark Michelson [1].
> 
> Thanks,
> Jakub
> 
> [1] https://patchwork.ozlabs.org/patch/947155/
> 
> v1 -> v2:
> - Check if LSP addresses are static before treating them as such to avoid a
>   warning. Reported by Han Zhou.
> 
> 
> Jakub Sitnicki (3):
>   ovn-nbctl: Allow referring to port groups by name.
>   ovn-northd: Make use of svec for storing lists of addresses.
>   ovn-northd: Propagate dynamic addresses to port group address sets.
> 
>  ovn/northd/ovn-northd.c   |  77 ++++++++++++++++----------------
>  ovn/utilities/ovn-nbctl.c |   3 ++
>  tests/ovn-nbctl.at        |  14 ++++++
>  tests/ovn.at              | 109 ++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 164 insertions(+), 39 deletions(-)
> 
> --
> 2.14.4
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev