From patchwork Sun Apr 1 15:06:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaron Conole X-Patchwork-Id: 894022 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40Ddz32n6Kz9s15 for ; Mon, 2 Apr 2018 01:08:31 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id E4536E97; Sun, 1 Apr 2018 15:07:03 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 5C72BE4B for ; Sun, 1 Apr 2018 15:07:01 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 413C4604 for ; Sun, 1 Apr 2018 15:06:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 50A2A722DD; Sun, 1 Apr 2018 15:06:57 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (ovpn-120-201.rdu2.redhat.com [10.10.120.201]) by smtp.corp.redhat.com (Postfix) with ESMTP id A5BD8215CDAF; Sun, 1 Apr 2018 15:06:56 +0000 (UTC) From: Aaron Conole To: dev@openvswitch.org Date: Sun, 1 Apr 2018 11:06:51 -0400 Message-Id: <20180401150654.5941-1-aconole@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Sun, 01 Apr 2018 15:06:57 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Sun, 01 Apr 2018 15:06:57 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'aconole@redhat.com' RCPT:'' X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH v2 0/3] checkpatch: the comment years! X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org This series tries to get checkpatch a little better at skipping stylistic things within comments, as well as growing a new feature to actually spell check words in the comments. Patch 1 just cleans up the patch line-type state machine a little. Patch 2 introduces a c/c++ comment detection state machine filter, and plugs the infix operator whitespace detector to it. Turns out it's the best way of detecting infix operators in comments. I didn't *heavily* stress test this machine, but I did use checkpatch -2000 to get some samples as well as building up some test strings. BONUS TODO: At some point, it would be cool to have a suite of test patches to act as unit tests... or even just unit tests... Patch 3 introduces an opt-in spell checker. This can aid in reducing any mispellings. I sent something like this before, but it wasn't opt-in at the time and it was probably a bit harder to understand then. v1->v2: * Fixed flake8 errors. * Fixed the comment state machine (since it missed a number of edge cases). * Although it's submitted on April 1, it's not an april fools joke.. Aaron Conole (3): checkpatch: introduce constants for the parse states checkpatch: filter comment contents checkpatch: add a comment spell-checker utilities/checkpatch.py | 182 +++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 172 insertions(+), 10 deletions(-)