mbox series

[ovs-dev,0/8] ci: Add remaining check tests to GitHub actions.

Message ID 170073542415.369846.11111021082150317170.stgit@ebuild
Headers show
Series ci: Add remaining check tests to GitHub actions. | expand

Message

Eelco Chaudron Nov. 23, 2023, 10:30 a.m. UTC
This set of patches incorporates the remaining make check tests into
the GitHub action run. Notably, this inclusion does not appear to
extend the overall run time, as the newly added tests complete prior
to the existing ones.

Eelco Chaudron (8):
      ci: Add make check-ovsdb-cluster tests to GitHub action ci.
      ci: Add make check-kernel to GitHub actions ci.
      ci: Add make check-offloads to GitHub actions ci.
      ci: Add make check-system-userspace to GitHub actions ci.
      ci: Add make check-system-tso to GitHub actions ci.
      ci: Allow make check-dpdk to run more tests.
      ci: Add make check-afxdp to GitHub actions ci.
      ci: Exclude tests that show random failures through GitHub actions.


 .ci/dpdk-build.sh                    |  2 +-
 .ci/linux-build.sh                   | 15 ++++++----
 .github/workflows/build-and-test.yml | 39 +++++++++++++++++++++---
 python/test_requirements.txt         |  5 +++-
 tests/system-common-macros.at        |  4 +++
 tests/system-offloads-traffic.at     |  2 ++
 tests/system-traffic.at              | 45 +++++++++++++++-------------
 7 files changed, 80 insertions(+), 32 deletions(-)

Comments

Simon Horman Nov. 24, 2023, 10:29 a.m. UTC | #1
On Thu, Nov 23, 2023 at 11:30:35AM +0100, Eelco Chaudron wrote:
> This set of patches incorporates the remaining make check tests into
> the GitHub action run. Notably, this inclusion does not appear to
> extend the overall run time, as the newly added tests complete prior
> to the existing ones.
> 
> Eelco Chaudron (8):
>       ci: Add make check-ovsdb-cluster tests to GitHub action ci.
>       ci: Add make check-kernel to GitHub actions ci.
>       ci: Add make check-offloads to GitHub actions ci.
>       ci: Add make check-system-userspace to GitHub actions ci.
>       ci: Add make check-system-tso to GitHub actions ci.
>       ci: Allow make check-dpdk to run more tests.
>       ci: Add make check-afxdp to GitHub actions ci.
>       ci: Exclude tests that show random failures through GitHub actions.

Hi Eelco,

I am seeing some CI failures with this series, is this
something we should be concerned about?

https://patchwork.ozlabs.org/project/openvswitch/list/?series=383524&state=%2A&archive=both
Eelco Chaudron Nov. 24, 2023, 10:38 a.m. UTC | #2
On 24 Nov 2023, at 11:29, Simon Horman wrote:

> On Thu, Nov 23, 2023 at 11:30:35AM +0100, Eelco Chaudron wrote:
>> This set of patches incorporates the remaining make check tests into
>> the GitHub action run. Notably, this inclusion does not appear to
>> extend the overall run time, as the newly added tests complete prior
>> to the existing ones.
>>
>> Eelco Chaudron (8):
>>       ci: Add make check-ovsdb-cluster tests to GitHub action ci.
>>       ci: Add make check-kernel to GitHub actions ci.
>>       ci: Add make check-offloads to GitHub actions ci.
>>       ci: Add make check-system-userspace to GitHub actions ci.
>>       ci: Add make check-system-tso to GitHub actions ci.
>>       ci: Allow make check-dpdk to run more tests.
>>       ci: Add make check-afxdp to GitHub actions ci.
>>       ci: Exclude tests that show random failures through GitHub actions.
>
> Hi Eelco,
>
> I am seeing some CI failures with this series, is this
> something we should be concerned about?
>
> https://patchwork.ozlabs.org/project/openvswitch/list/?series=383524&state=%2A&archive=both

Yes, we should (some of them :) There is an issue in the cache key generation for the DPDK cached builds.
Discussed this yesterday with David, and will sent a v2 today or next week with an addition patch to fix this.

//Eelco