From patchwork Tue Feb 7 14:03:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eelco Chaudron X-Patchwork-Id: 1738968 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YLzH/17+; dkim-atps=neutral Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PB4cM3t4qz23hn for ; Wed, 8 Feb 2023 01:04:03 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C1BFE81E37; Tue, 7 Feb 2023 14:04:01 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C1BFE81E37 Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YLzH/17+ X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pxhuATz4ITz5; Tue, 7 Feb 2023 14:04:00 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id B2C2681E0C; Tue, 7 Feb 2023 14:03:59 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org B2C2681E0C Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8AFC1C0033; Tue, 7 Feb 2023 14:03:59 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7F2ECC002B for ; Tue, 7 Feb 2023 14:03:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 5AD3760F58 for ; Tue, 7 Feb 2023 14:03:57 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5AD3760F58 Authentication-Results: smtp3.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YLzH/17+ X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NIIci0egALY4 for ; Tue, 7 Feb 2023 14:03:55 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 6DE6060E96 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 6DE6060E96 for ; Tue, 7 Feb 2023 14:03:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675778634; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pcQjev+9kVFClkKVpWTon34Axx36tn44gBb1So+xBmE=; b=YLzH/17+kzBrZdGtGLtd/VlpHgNIfX9X/SCh4h1YRkJa/JFNBf+ZDqZT0oXgV4OdDAspx7 R7jKZJnS03EvockKmRBuLyC9FGhC+INrhYGg7MtndId8RFbr2Yp+r2y3tHWDa9YRPbFpOi 2X+26ZZKyWibmqOOZ51OiTa0+nuh8bU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-206-8_ANCrYKMcu3JgtN1QwerQ-1; Tue, 07 Feb 2023 09:03:50 -0500 X-MC-Unique: 8_ANCrYKMcu3JgtN1QwerQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5FB62802D19; Tue, 7 Feb 2023 14:03:50 +0000 (UTC) Received: from ebuild.redhat.com (unknown [10.39.193.243]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2BEDD1415113; Tue, 7 Feb 2023 14:03:48 +0000 (UTC) From: Eelco Chaudron To: dev@openvswitch.org Date: Tue, 7 Feb 2023 15:03:45 +0100 Message-Id: <167577861530.1166983.2484474802211392495.stgit@ebuild.local> User-Agent: StGit/1.5 MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Cc: simon.horman@corigine.com, i.maximets@ovn.org Subject: [ovs-dev] [PATCH v11 00/11] tests: Add system-traffic.at tests to check-offloads. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" This series makes it possible to include system-traffic.at tests into "make check-offloads" tests. The last patch of the series explains which tests are still not passing and might need some more work. I'll try to work on the remaining failing test cases or find someone who can work on them. These tests where executed on a Fedora37 machine with the kernel 6.1.5-200.fc37.x86_64 installed. v11: - Lowered log level for "recirc_id sharing not supported" message. As this is not an error, but should be debug, like all other EOPNOTSUPP, related log messages. v10: - Added missing userspace/kernel macro's. v9: - Exclude "recirc_id sharing not supported" warning from the log. - Reworked to use a skip based macro rather than skip list. - Fixes some spelling. - Removed patches for issues no longer existing when using the latest kernel/OVS. v8: - Re-based on top of latest OVS master. v7: - Removed left over merge comment, and re-run all tests. v6: - Added ACKs from v5 - Changed 'netdev-offload-tc: If the flow has not been used, report it as such.' to also work on hardware offloaded flows. v5: - Include all patches, v4 went out with missing two patches :( v4: - Fix rename from system-traffic.at to sym-traffic.at in patch 11 v3: - Fixed missing MACRO's in patches 4, 6 and 10. v2: - Fix commit message on last patch - Moved handling of system-traffic.at tests to a separate file system-offloads.at - Re-based to the latest ovs master branch - Added Roi's ACKs Eelco Chaudron (11): tests: Include working system-traffic tests into the system-offloads-testsuite. test: Do not use MPLS implicit null label in test cases. netdev-offload-tc: Fix tc conntrack force commit support. test: Flush datapath when changing rules on the fly. netdev-offload-tc: Conntrack ALGs are not supported with tc. test: tc does not support conntrack timeout, skip the related test. test: Fix 'conntrack - Multiple ICMP traverse' for tc case. odp-util: Make odp_flow_key_from_flow__ nlattr order the same as the kernel. netdev-offload-tc: If the flow has not been used, report it as such. tests: Fix reading of OpenFlow byte counters in GRE test cases. tests: Comment currently failing TC system-traffic tests. Documentation/howto/tc-offload.rst | 11 +++ lib/netdev-offload-tc.c | 19 ++++- lib/odp-util.c | 21 +++--- lib/tc.c | 14 +++- tests/automake.mk | 3 +- tests/dpif-netdev.at | 28 ++++---- tests/mcast-snooping.at | 4 +- tests/nsh.at | 10 +-- tests/odp.at | 84 +++++++++++------------ tests/ofproto-dpif.at | 30 ++++---- tests/packet-type-aware.at | 22 +++--- tests/pmd.at | 2 +- tests/system-kmod-macros.at | 5 ++ tests/system-offloads-testsuite-macros.at | 69 +++++++++++++++++++ tests/system-offloads-testsuite.at | 3 + tests/system-traffic.at | 37 ++++++---- tests/system-userspace-macros.at | 5 ++ tests/tunnel-push-pop-ipv6.at | 2 +- tests/tunnel-push-pop.at | 2 +- tests/tunnel.at | 2 +- 20 files changed, 249 insertions(+), 124 deletions(-) create mode 100644 tests/system-offloads-testsuite-macros.at