mbox series

[ovs-dev,v2,00/10] netdev-offload-tc: Fix various tc-offload related problems

Message ID 164362511347.2824752.11751862323892747321.stgit@ebuild
Headers show
Series netdev-offload-tc: Fix various tc-offload related problems | expand

Message

Eelco Chaudron Jan. 31, 2022, 10:32 a.m. UTC 
This series fixes a bunch of TC offload-related issues found when
running the kernel data path self-test (make check-kernel) forcing
TC to be enabled. To do this manually I applied the following diff:

  https://github.com/chaudron/ovs/commit/d7ff1060f371e2cbd4b2e8dee222a9eed55073c8

These changes are OVS-related fixes, however, I have still two
problems that look kernel to investigate.

I'm also planning to find a nice way to include the system-traffic.at
into "make check-offloads". However, this might take some time, and I
do not want to delay getting the actual fixes in.

The following branch has some raw changes to system-traffic.at to
make most of the tests work with TC enabled hardcoded:

  https://github.com/chaudron/ovs/tree/dev/tc_verify

v2:
  - Fixed sparse "expected restricted ovs_be16" warning
  - Removed patch "netdev-offload-tc: stats should be captured on first action in the list"
  - Added new patch "odp-util: Fix output for tc to be equal to kernel"

Eelco Chaudron (10):
      netdev-offload-tc: Add debug logs on tc rule verify failures
      netdev-offload-tc: Set the correct VLAN_VID and VLAN_PCP masks
      odp_util: Fix parse_key_and_mask_to_match() vlan parsing
      netdev-offload-tc: Check for valid netdev ifindex in flow_put
      netdev-offload-tc: Always include conntrack information to tc
      netdev-offload-tc: Fix use of ICMP values instead of masks defines.
      netdev-offload-tc: Fix IP and port ranges in flower returns.
      netdev-offload-tc: Check for none offloadable ct_state flag combination
      revalidator: Fix datapath statistics update.
      odp-util: Fix output for tc to be equal to kernel


 lib/netdev-offload-tc.c       |  27 +++++++-
 lib/odp-util.c                |  46 +++++++++----
 lib/tc.c                      | 124 +++++++++++++++++++++++++++-------
 ofproto/ofproto-dpif-upcall.c |   8 ++-
 tests/tunnel.at               |   2 +-
 5 files changed, 163 insertions(+), 44 deletions(-)