mbox series

[ovs-dev,0/7,v3] datapath: Support 4.19.x and 4.20.x kernel

Message ID 1557516614-12563-1-git-send-email-pkusunyifeng@gmail.com
Headers show
Series datapath: Support 4.19.x and 4.20.x kernel | expand

Message

Yifeng Sun May 10, 2019, 7:30 p.m. UTC
This series of patches enabled OVS to support kernel 4.19.x and 4.20.x.

Tests shows that this series of patches passed check-kmod tests or
didn't introduce new failed check-kmod tests for the following
kernel versions:
3.10.0-957.12.1.el7.x86_64 (rhel)
4.4.0-31-generic (ubuntu 14.04)
4.4.0-146-generic (ubuntu 16.04)
4.4.179
4.9.171
4.14.111
4.15.0-48-generic (ubuntu 18.04)
4.17.19
4.18.0-18-generic (ubuntu 18.10)
4.19.37
4.20.17

Travis passed at:
https://travis-ci.org/yifsun/ovs-travis/builds/528006159

In addition, build is successful on:
CentOS73, Fedora, RHEL74, RHEL75, RHEL76 and Ubuntu (bionic, trusty,
xenial).

Yifeng Sun (7):
  datapath: Handle removal of nf_conntrack_l3proto.h
  datapath: Pass nf_hook_state to nf_conntrack_in()
  datapath: Use new header file net/ipv6_frag.h
  datapath: Fix conntrack_count related compilation errors
  openvswitch: use nf_ct_get_tuplepr, invert_tuplepr
  netfilter: Remove useless param helper of nf_ct_helper_ext_add
  datapath: Support kernel version 4.19.x and 4.20.x

Tested-by: Greg Rose <gvrose8192@gmail.com>
Reviewed-by: Greg Rose <gvrose8192@gmail.com>

v1->v2: Fix by reviewers' comments.
v2->v3: Fix patch series.

 .travis.yml                                        | 18 ++++++++-------
 NEWS                                               |  2 ++
 acinclude.m4                                       | 17 ++++++++++++--
 datapath/conntrack.c                               | 26 +++++++++-------------
 datapath/linux/Modules.mk                          |  2 ++
 datapath/linux/compat/include/linux/netfilter.h    | 19 ++++++++++++++++
 datapath/linux/compat/include/net/ipv6_frag.h      |  8 +++++++
 .../include/net/netfilter/nf_conntrack_core.h      |  9 ++++++++
 .../include/net/netfilter/nf_conntrack_count.h     |  4 ++--
 .../include/net/netfilter/nf_conntrack_helper.h    | 10 +++++++++
 datapath/linux/compat/nf_conncount.c               |  6 ++++-
 datapath/linux/compat/nf_conntrack_proto.c         |  2 ++
 12 files changed, 94 insertions(+), 29 deletions(-)
 create mode 100644 datapath/linux/compat/include/linux/netfilter.h
 create mode 100644 datapath/linux/compat/include/net/ipv6_frag.h

Comments

Gregory Rose May 10, 2019, 7:47 p.m. UTC | #1
My tags are missing.

For the series:

Tested-by: Greg Rose <gvrose8192@gmail.com>
Reviewed-by: Greg Rose <gvrose8192@gmail.com>

On 5/10/2019 12:30 PM, Yifeng Sun wrote:
> This series of patches enabled OVS to support kernel 4.19.x and 4.20.x.
>
> Tests shows that this series of patches passed check-kmod tests or
> didn't introduce new failed check-kmod tests for the following
> kernel versions:
> 3.10.0-957.12.1.el7.x86_64 (rhel)
> 4.4.0-31-generic (ubuntu 14.04)
> 4.4.0-146-generic (ubuntu 16.04)
> 4.4.179
> 4.9.171
> 4.14.111
> 4.15.0-48-generic (ubuntu 18.04)
> 4.17.19
> 4.18.0-18-generic (ubuntu 18.10)
> 4.19.37
> 4.20.17
>
> Travis passed at:
> https://travis-ci.org/yifsun/ovs-travis/builds/528006159
>
> In addition, build is successful on:
> CentOS73, Fedora, RHEL74, RHEL75, RHEL76 and Ubuntu (bionic, trusty,
> xenial).
>
> Yifeng Sun (7):
>    datapath: Handle removal of nf_conntrack_l3proto.h
>    datapath: Pass nf_hook_state to nf_conntrack_in()
>    datapath: Use new header file net/ipv6_frag.h
>    datapath: Fix conntrack_count related compilation errors
>    openvswitch: use nf_ct_get_tuplepr, invert_tuplepr
>    netfilter: Remove useless param helper of nf_ct_helper_ext_add
>    datapath: Support kernel version 4.19.x and 4.20.x
>
> Tested-by: Greg Rose <gvrose8192@gmail.com>
> Reviewed-by: Greg Rose <gvrose8192@gmail.com>
>
> v1->v2: Fix by reviewers' comments.
> v2->v3: Fix patch series.
>
>   .travis.yml                                        | 18 ++++++++-------
>   NEWS                                               |  2 ++
>   acinclude.m4                                       | 17 ++++++++++++--
>   datapath/conntrack.c                               | 26 +++++++++-------------
>   datapath/linux/Modules.mk                          |  2 ++
>   datapath/linux/compat/include/linux/netfilter.h    | 19 ++++++++++++++++
>   datapath/linux/compat/include/net/ipv6_frag.h      |  8 +++++++
>   .../include/net/netfilter/nf_conntrack_core.h      |  9 ++++++++
>   .../include/net/netfilter/nf_conntrack_count.h     |  4 ++--
>   .../include/net/netfilter/nf_conntrack_helper.h    | 10 +++++++++
>   datapath/linux/compat/nf_conncount.c               |  6 ++++-
>   datapath/linux/compat/nf_conntrack_proto.c         |  2 ++
>   12 files changed, 94 insertions(+), 29 deletions(-)
>   create mode 100644 datapath/linux/compat/include/linux/netfilter.h
>   create mode 100644 datapath/linux/compat/include/net/ipv6_frag.h
>
Yifeng Sun May 10, 2019, 7:53 p.m. UTC | #2
Thanks Greg, I've put your tags in the cover letter.
Yifeng

On Fri, May 10, 2019 at 12:47 PM Gregory Rose <gvrose8192@gmail.com> wrote:
>
> My tags are missing.
>
> For the series:
>
> Tested-by: Greg Rose <gvrose8192@gmail.com>
> Reviewed-by: Greg Rose <gvrose8192@gmail.com>
>
> On 5/10/2019 12:30 PM, Yifeng Sun wrote:
> > This series of patches enabled OVS to support kernel 4.19.x and 4.20.x.
> >
> > Tests shows that this series of patches passed check-kmod tests or
> > didn't introduce new failed check-kmod tests for the following
> > kernel versions:
> > 3.10.0-957.12.1.el7.x86_64 (rhel)
> > 4.4.0-31-generic (ubuntu 14.04)
> > 4.4.0-146-generic (ubuntu 16.04)
> > 4.4.179
> > 4.9.171
> > 4.14.111
> > 4.15.0-48-generic (ubuntu 18.04)
> > 4.17.19
> > 4.18.0-18-generic (ubuntu 18.10)
> > 4.19.37
> > 4.20.17
> >
> > Travis passed at:
> > https://travis-ci.org/yifsun/ovs-travis/builds/528006159
> >
> > In addition, build is successful on:
> > CentOS73, Fedora, RHEL74, RHEL75, RHEL76 and Ubuntu (bionic, trusty,
> > xenial).
> >
> > Yifeng Sun (7):
> >    datapath: Handle removal of nf_conntrack_l3proto.h
> >    datapath: Pass nf_hook_state to nf_conntrack_in()
> >    datapath: Use new header file net/ipv6_frag.h
> >    datapath: Fix conntrack_count related compilation errors
> >    openvswitch: use nf_ct_get_tuplepr, invert_tuplepr
> >    netfilter: Remove useless param helper of nf_ct_helper_ext_add
> >    datapath: Support kernel version 4.19.x and 4.20.x
> >
> > Tested-by: Greg Rose <gvrose8192@gmail.com>
> > Reviewed-by: Greg Rose <gvrose8192@gmail.com>
> >
> > v1->v2: Fix by reviewers' comments.
> > v2->v3: Fix patch series.
> >
> >   .travis.yml                                        | 18 ++++++++-------
> >   NEWS                                               |  2 ++
> >   acinclude.m4                                       | 17 ++++++++++++--
> >   datapath/conntrack.c                               | 26 +++++++++-------------
> >   datapath/linux/Modules.mk                          |  2 ++
> >   datapath/linux/compat/include/linux/netfilter.h    | 19 ++++++++++++++++
> >   datapath/linux/compat/include/net/ipv6_frag.h      |  8 +++++++
> >   .../include/net/netfilter/nf_conntrack_core.h      |  9 ++++++++
> >   .../include/net/netfilter/nf_conntrack_count.h     |  4 ++--
> >   .../include/net/netfilter/nf_conntrack_helper.h    | 10 +++++++++
> >   datapath/linux/compat/nf_conncount.c               |  6 ++++-
> >   datapath/linux/compat/nf_conntrack_proto.c         |  2 ++
> >   12 files changed, 94 insertions(+), 29 deletions(-)
> >   create mode 100644 datapath/linux/compat/include/linux/netfilter.h
> >   create mode 100644 datapath/linux/compat/include/net/ipv6_frag.h
> >
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Gregory Rose May 10, 2019, 8 p.m. UTC | #3
On 5/10/2019 12:53 PM, Yifeng Sun wrote:
> Thanks Greg, I've put your tags in the cover letter.
> Yifeng

Now I see them.  Thanks!

>
> On Fri, May 10, 2019 at 12:47 PM Gregory Rose <gvrose8192@gmail.com> wrote:
>> My tags are missing.
>>
>> For the series:
>>
>> Tested-by: Greg Rose <gvrose8192@gmail.com>
>> Reviewed-by: Greg Rose <gvrose8192@gmail.com>
>>
>> On 5/10/2019 12:30 PM, Yifeng Sun wrote:
>>> This series of patches enabled OVS to support kernel 4.19.x and 4.20.x.
>>>
>>> Tests shows that this series of patches passed check-kmod tests or
>>> didn't introduce new failed check-kmod tests for the following
>>> kernel versions:
>>> 3.10.0-957.12.1.el7.x86_64 (rhel)
>>> 4.4.0-31-generic (ubuntu 14.04)
>>> 4.4.0-146-generic (ubuntu 16.04)
>>> 4.4.179
>>> 4.9.171
>>> 4.14.111
>>> 4.15.0-48-generic (ubuntu 18.04)
>>> 4.17.19
>>> 4.18.0-18-generic (ubuntu 18.10)
>>> 4.19.37
>>> 4.20.17
>>>
>>> Travis passed at:
>>> https://travis-ci.org/yifsun/ovs-travis/builds/528006159
>>>
>>> In addition, build is successful on:
>>> CentOS73, Fedora, RHEL74, RHEL75, RHEL76 and Ubuntu (bionic, trusty,
>>> xenial).
>>>
>>> Yifeng Sun (7):
>>>     datapath: Handle removal of nf_conntrack_l3proto.h
>>>     datapath: Pass nf_hook_state to nf_conntrack_in()
>>>     datapath: Use new header file net/ipv6_frag.h
>>>     datapath: Fix conntrack_count related compilation errors
>>>     openvswitch: use nf_ct_get_tuplepr, invert_tuplepr
>>>     netfilter: Remove useless param helper of nf_ct_helper_ext_add
>>>     datapath: Support kernel version 4.19.x and 4.20.x
>>>
>>> Tested-by: Greg Rose <gvrose8192@gmail.com>
>>> Reviewed-by: Greg Rose <gvrose8192@gmail.com>
>>>
>>> v1->v2: Fix by reviewers' comments.
>>> v2->v3: Fix patch series.
>>>
>>>    .travis.yml                                        | 18 ++++++++-------
>>>    NEWS                                               |  2 ++
>>>    acinclude.m4                                       | 17 ++++++++++++--
>>>    datapath/conntrack.c                               | 26 +++++++++-------------
>>>    datapath/linux/Modules.mk                          |  2 ++
>>>    datapath/linux/compat/include/linux/netfilter.h    | 19 ++++++++++++++++
>>>    datapath/linux/compat/include/net/ipv6_frag.h      |  8 +++++++
>>>    .../include/net/netfilter/nf_conntrack_core.h      |  9 ++++++++
>>>    .../include/net/netfilter/nf_conntrack_count.h     |  4 ++--
>>>    .../include/net/netfilter/nf_conntrack_helper.h    | 10 +++++++++
>>>    datapath/linux/compat/nf_conncount.c               |  6 ++++-
>>>    datapath/linux/compat/nf_conntrack_proto.c         |  2 ++
>>>    12 files changed, 94 insertions(+), 29 deletions(-)
>>>    create mode 100644 datapath/linux/compat/include/linux/netfilter.h
>>>    create mode 100644 datapath/linux/compat/include/net/ipv6_frag.h
>>>
>> _______________________________________________
>> dev mailing list
>> dev@openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Ben Pfaff May 10, 2019, 8:18 p.m. UTC | #4
Please add tags to each patch, because they need to be there when the
patches are applied.

I took care of that myself, and I also reordered the tags a little
(Signed-off-by should be last) and applied this series to master.
Thanks, everyone!

On Fri, May 10, 2019 at 12:53:08PM -0700, Yifeng Sun wrote:
> Thanks Greg, I've put your tags in the cover letter.
> Yifeng
> 
> On Fri, May 10, 2019 at 12:47 PM Gregory Rose <gvrose8192@gmail.com> wrote:
> >
> > My tags are missing.
> >
> > For the series:
> >
> > Tested-by: Greg Rose <gvrose8192@gmail.com>
> > Reviewed-by: Greg Rose <gvrose8192@gmail.com>
> >
> > On 5/10/2019 12:30 PM, Yifeng Sun wrote:
> > > This series of patches enabled OVS to support kernel 4.19.x and 4.20.x.
> > >
> > > Tests shows that this series of patches passed check-kmod tests or
> > > didn't introduce new failed check-kmod tests for the following
> > > kernel versions:
> > > 3.10.0-957.12.1.el7.x86_64 (rhel)
> > > 4.4.0-31-generic (ubuntu 14.04)
> > > 4.4.0-146-generic (ubuntu 16.04)
> > > 4.4.179
> > > 4.9.171
> > > 4.14.111
> > > 4.15.0-48-generic (ubuntu 18.04)
> > > 4.17.19
> > > 4.18.0-18-generic (ubuntu 18.10)
> > > 4.19.37
> > > 4.20.17
> > >
> > > Travis passed at:
> > > https://travis-ci.org/yifsun/ovs-travis/builds/528006159
> > >
> > > In addition, build is successful on:
> > > CentOS73, Fedora, RHEL74, RHEL75, RHEL76 and Ubuntu (bionic, trusty,
> > > xenial).
> > >
> > > Yifeng Sun (7):
> > >    datapath: Handle removal of nf_conntrack_l3proto.h
> > >    datapath: Pass nf_hook_state to nf_conntrack_in()
> > >    datapath: Use new header file net/ipv6_frag.h
> > >    datapath: Fix conntrack_count related compilation errors
> > >    openvswitch: use nf_ct_get_tuplepr, invert_tuplepr
> > >    netfilter: Remove useless param helper of nf_ct_helper_ext_add
> > >    datapath: Support kernel version 4.19.x and 4.20.x
> > >
> > > Tested-by: Greg Rose <gvrose8192@gmail.com>
> > > Reviewed-by: Greg Rose <gvrose8192@gmail.com>
> > >
> > > v1->v2: Fix by reviewers' comments.
> > > v2->v3: Fix patch series.
> > >
> > >   .travis.yml                                        | 18 ++++++++-------
> > >   NEWS                                               |  2 ++
> > >   acinclude.m4                                       | 17 ++++++++++++--
> > >   datapath/conntrack.c                               | 26 +++++++++-------------
> > >   datapath/linux/Modules.mk                          |  2 ++
> > >   datapath/linux/compat/include/linux/netfilter.h    | 19 ++++++++++++++++
> > >   datapath/linux/compat/include/net/ipv6_frag.h      |  8 +++++++
> > >   .../include/net/netfilter/nf_conntrack_core.h      |  9 ++++++++
> > >   .../include/net/netfilter/nf_conntrack_count.h     |  4 ++--
> > >   .../include/net/netfilter/nf_conntrack_helper.h    | 10 +++++++++
> > >   datapath/linux/compat/nf_conncount.c               |  6 ++++-
> > >   datapath/linux/compat/nf_conntrack_proto.c         |  2 ++
> > >   12 files changed, 94 insertions(+), 29 deletions(-)
> > >   create mode 100644 datapath/linux/compat/include/linux/netfilter.h
> > >   create mode 100644 datapath/linux/compat/include/net/ipv6_frag.h
> > >
> >
> > _______________________________________________
> > dev mailing list
> > dev@openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Yifeng Sun May 10, 2019, 8:24 p.m. UTC | #5
Thanks Ben. I will pay attention for future patches.
Yifeng

On Fri, May 10, 2019 at 1:18 PM Ben Pfaff <blp@ovn.org> wrote:
>
> Please add tags to each patch, because they need to be there when the
> patches are applied.
>
> I took care of that myself, and I also reordered the tags a little
> (Signed-off-by should be last) and applied this series to master.
> Thanks, everyone!
>
> On Fri, May 10, 2019 at 12:53:08PM -0700, Yifeng Sun wrote:
> > Thanks Greg, I've put your tags in the cover letter.
> > Yifeng
> >
> > On Fri, May 10, 2019 at 12:47 PM Gregory Rose <gvrose8192@gmail.com> wrote:
> > >
> > > My tags are missing.
> > >
> > > For the series:
> > >
> > > Tested-by: Greg Rose <gvrose8192@gmail.com>
> > > Reviewed-by: Greg Rose <gvrose8192@gmail.com>
> > >
> > > On 5/10/2019 12:30 PM, Yifeng Sun wrote:
> > > > This series of patches enabled OVS to support kernel 4.19.x and 4.20.x.
> > > >
> > > > Tests shows that this series of patches passed check-kmod tests or
> > > > didn't introduce new failed check-kmod tests for the following
> > > > kernel versions:
> > > > 3.10.0-957.12.1.el7.x86_64 (rhel)
> > > > 4.4.0-31-generic (ubuntu 14.04)
> > > > 4.4.0-146-generic (ubuntu 16.04)
> > > > 4.4.179
> > > > 4.9.171
> > > > 4.14.111
> > > > 4.15.0-48-generic (ubuntu 18.04)
> > > > 4.17.19
> > > > 4.18.0-18-generic (ubuntu 18.10)
> > > > 4.19.37
> > > > 4.20.17
> > > >
> > > > Travis passed at:
> > > > https://travis-ci.org/yifsun/ovs-travis/builds/528006159
> > > >
> > > > In addition, build is successful on:
> > > > CentOS73, Fedora, RHEL74, RHEL75, RHEL76 and Ubuntu (bionic, trusty,
> > > > xenial).
> > > >
> > > > Yifeng Sun (7):
> > > >    datapath: Handle removal of nf_conntrack_l3proto.h
> > > >    datapath: Pass nf_hook_state to nf_conntrack_in()
> > > >    datapath: Use new header file net/ipv6_frag.h
> > > >    datapath: Fix conntrack_count related compilation errors
> > > >    openvswitch: use nf_ct_get_tuplepr, invert_tuplepr
> > > >    netfilter: Remove useless param helper of nf_ct_helper_ext_add
> > > >    datapath: Support kernel version 4.19.x and 4.20.x
> > > >
> > > > Tested-by: Greg Rose <gvrose8192@gmail.com>
> > > > Reviewed-by: Greg Rose <gvrose8192@gmail.com>
> > > >
> > > > v1->v2: Fix by reviewers' comments.
> > > > v2->v3: Fix patch series.
> > > >
> > > >   .travis.yml                                        | 18 ++++++++-------
> > > >   NEWS                                               |  2 ++
> > > >   acinclude.m4                                       | 17 ++++++++++++--
> > > >   datapath/conntrack.c                               | 26 +++++++++-------------
> > > >   datapath/linux/Modules.mk                          |  2 ++
> > > >   datapath/linux/compat/include/linux/netfilter.h    | 19 ++++++++++++++++
> > > >   datapath/linux/compat/include/net/ipv6_frag.h      |  8 +++++++
> > > >   .../include/net/netfilter/nf_conntrack_core.h      |  9 ++++++++
> > > >   .../include/net/netfilter/nf_conntrack_count.h     |  4 ++--
> > > >   .../include/net/netfilter/nf_conntrack_helper.h    | 10 +++++++++
> > > >   datapath/linux/compat/nf_conncount.c               |  6 ++++-
> > > >   datapath/linux/compat/nf_conntrack_proto.c         |  2 ++
> > > >   12 files changed, 94 insertions(+), 29 deletions(-)
> > > >   create mode 100644 datapath/linux/compat/include/linux/netfilter.h
> > > >   create mode 100644 datapath/linux/compat/include/net/ipv6_frag.h
> > > >
> > >
> > > _______________________________________________
> > > dev mailing list
> > > dev@openvswitch.org
> > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> > _______________________________________________
> > dev mailing list
> > dev@openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev