mbox series

[ovs-dev,0/3] tests: Environment variable for default timeout.

Message ID 1534233197-11148-1-git-send-email-i.maximets@samsung.com
Headers show
Series tests: Environment variable for default timeout. | expand

Message

Ilya Maximets Aug. 14, 2018, 7:53 a.m. UTC 
This was inspired by my previous patch set about syslog [1] and
the new environment variable for syslog method [2].

Patch set introduces new env. variable 'OVS_CTL_TIMEOUT', which
is used as a default timeout for control utilities. Using it we
can avoid shell tricks with aliases. It will work in any shell
and even in a subshell.

[1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-August/350813.html
[2] https://mail.openvswitch.org/pipermail/ovs-dev/2018-August/350872.html

Ilya Maximets (3):
  utilities: Fix and unify parsing of timout option.
  tests: Use environment variable for default timeout.
  tests: Drop setting aliases for control utils.

 NEWS                       |  2 ++
 lib/util.c                 | 18 ++++++++++++++++++
 lib/util.h                 |  2 ++
 ovn/utilities/ovn-nbctl.c  | 16 +++++-----------
 ovn/utilities/ovn-sbctl.c  |  9 +++------
 ovsdb/ovsdb-client.c       | 12 +++++-------
 python/ovs/fatal_signal.py |  8 +++++++-
 tests/appctl.py            |  3 +--
 tests/atlocal.in           |  4 ++++
 tests/ovs-macros.at        | 41 -----------------------------------------
 tests/test-ovsdb.c         | 12 +++++-------
 tests/test-ovsdb.py        |  4 +++-
 utilities/ovs-appctl.c     |  7 ++++++-
 utilities/ovs-dpctl.c      | 13 ++++++-------
 utilities/ovs-ofctl.c      | 12 +++++-------
 utilities/ovs-vsctl.c      | 12 ++++--------
 vtep/vtep-ctl.c            | 12 ++++--------
 17 files changed, 80 insertions(+), 107 deletions(-)

Comments

Ben Pfaff Aug. 15, 2018, 6:46 p.m. UTC | #1 
On Tue, Aug 14, 2018 at 10:53:14AM +0300, Ilya Maximets wrote:
> This was inspired by my previous patch set about syslog [1] and
> the new environment variable for syslog method [2].
> 
> Patch set introduces new env. variable 'OVS_CTL_TIMEOUT', which
> is used as a default timeout for control utilities. Using it we
> can avoid shell tricks with aliases. It will work in any shell
> and even in a subshell.
> 
> [1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-August/350813.html
> [2] https://mail.openvswitch.org/pipermail/ovs-dev/2018-August/350872.html

Seems reasonable.  Applied to master, thanks!