| Message ID | 20240701141101.20227-4-ben.dooks@codethink.co.uk |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Updated carray and other build improvements | expand |
On Mon, Jul 01, 2024 at 03:11:00PM GMT, Ben Dooks wrote: > Now we've renamed the carray output files to .carray.c > we can now use find to remove them. > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Makefile b/Makefile > index 2d964ec..7c43d93 100644 > --- a/Makefile > +++ b/Makefile > @@ -687,6 +687,8 @@ clean: > $(CMD_PREFIX)mkdir -p $(build_dir) > $(if $(V), @echo " RM $(build_dir)/*.o") > $(CMD_PREFIX)find $(build_dir) -type f -name "*.o" -exec rm -rf {} + > + $(if $(V), @echo " RM $(build_dir)/*.carray.c") > + $(CMD_PREFIX)find $(build_dir) -type f -name "*.carray.c" -exec rm -rf {} + > $(if $(V), @echo " RM $(build_dir)/*.a") > $(CMD_PREFIX)find $(build_dir) -type f -name "*.a" -exec rm -rf {} + > $(if $(V), @echo " RM $(build_dir)/*.elf") > -- > 2.37.2.352.g3c44437643 > Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
On 01/07/2024 16:31, Andrew Jones wrote: > On Mon, Jul 01, 2024 at 03:11:00PM GMT, Ben Dooks wrote: >> Now we've renamed the carray output files to .carray.c >> we can now use find to remove them. >> >> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> >> --- >> Makefile | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Makefile b/Makefile >> index 2d964ec..7c43d93 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -687,6 +687,8 @@ clean: >> $(CMD_PREFIX)mkdir -p $(build_dir) >> $(if $(V), @echo " RM $(build_dir)/*.o") >> $(CMD_PREFIX)find $(build_dir) -type f -name "*.o" -exec rm -rf {} + >> + $(if $(V), @echo " RM $(build_dir)/*.carray.c") >> + $(CMD_PREFIX)find $(build_dir) -type f -name "*.carray.c" -exec rm -rf {} + >> $(if $(V), @echo " RM $(build_dir)/*.a") >> $(CMD_PREFIX)find $(build_dir) -type f -name "*.a" -exec rm -rf {} + >> $(if $(V), @echo " RM $(build_dir)/*.elf") >> -- >> 2.37.2.352.g3c44437643 >> > > Reviewed-by: Andrew Jones <ajones@ventanamicro.com> Thanks, given the minor typo fix and adding reviewed-by, shall I sort those and issue a pull request against opensbi github?
On Mon, Jul 1, 2024 at 7:57 PM Ben Dooks <ben.dooks@codethink.co.uk> wrote: > > Now we've renamed the carray output files to .carray.c > we can now use find to remove them. > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> LGTM. Reviewed-by: Anup Patel <anup@brainfault.org> Applied this patch to the riscv/opensbi repo. Thanks, Anup > --- > Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Makefile b/Makefile > index 2d964ec..7c43d93 100644 > --- a/Makefile > +++ b/Makefile > @@ -687,6 +687,8 @@ clean: > $(CMD_PREFIX)mkdir -p $(build_dir) > $(if $(V), @echo " RM $(build_dir)/*.o") > $(CMD_PREFIX)find $(build_dir) -type f -name "*.o" -exec rm -rf {} + > + $(if $(V), @echo " RM $(build_dir)/*.carray.c") > + $(CMD_PREFIX)find $(build_dir) -type f -name "*.carray.c" -exec rm -rf {} + > $(if $(V), @echo " RM $(build_dir)/*.a") > $(CMD_PREFIX)find $(build_dir) -type f -name "*.a" -exec rm -rf {} + > $(if $(V), @echo " RM $(build_dir)/*.elf") > -- > 2.37.2.352.g3c44437643 > > > -- > opensbi mailing list > opensbi@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/opensbi
diff --git a/Makefile b/Makefile index 2d964ec..7c43d93 100644 --- a/Makefile +++ b/Makefile @@ -687,6 +687,8 @@ clean: $(CMD_PREFIX)mkdir -p $(build_dir) $(if $(V), @echo " RM $(build_dir)/*.o") $(CMD_PREFIX)find $(build_dir) -type f -name "*.o" -exec rm -rf {} + + $(if $(V), @echo " RM $(build_dir)/*.carray.c") + $(CMD_PREFIX)find $(build_dir) -type f -name "*.carray.c" -exec rm -rf {} + $(if $(V), @echo " RM $(build_dir)/*.a") $(CMD_PREFIX)find $(build_dir) -type f -name "*.a" -exec rm -rf {} + $(if $(V), @echo " RM $(build_dir)/*.elf")
Now we've renamed the carray output files to .carray.c we can now use find to remove them. Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- Makefile | 2 ++ 1 file changed, 2 insertions(+)