From patchwork Mon Mar 4 12:15:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiang W X-Patchwork-Id: 1907536 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ZT3rrOty; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=J+Rl5/jE; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=126.com header.i=@126.com header.a=rsa-sha256 header.s=s110527 header.b=VzCNRgPi; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TpHl748xmz23qH for ; Mon, 4 Mar 2024 23:17:39 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g4ALKiScGEcaqo3Zq2G483qdlRT77+M5+nQ61EnwtL0=; b=ZT3rrOtyBH7e0N PYGAAnE1r/jaPLSol5EPJyVwhD2nYypiYYy6fF1eHuWYTriWySQcc0DGOB92Z9EMlWNSBTlZBjv9s DuWwn+vZaRH7k0Z89DDIzh4UVns9oK/7jPg8cO+v7lcP5inmaiuVhvSZE+mQ4R+WMHIampLAturiw Y+qVO6820jiGqp21qCQw89+yUeFD8W/H12IcqrbMGs38JEZZxGhGC6Fkwji2jJuoUag6nX8trLMmu f4lQvIGUN+EE1/wONX/6Prdkvi3+KlsnUDrhHKUoVGTr3H/9yrC0NpVpCxHv4eP4h3uebsbMnfi8C Tp3OBXnvEVDiSFrKLiKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh7G3-00000008ww6-0i2a; Mon, 04 Mar 2024 12:17:27 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh7Fq-00000008wq6-30zG for opensbi@bombadil.infradead.org; Mon, 04 Mar 2024 12:17:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=sZHWapsaM2AZosz4o9OgWfrec+EioHB4imdxRCoCOYw=; b=J+Rl5/jEuFDq9kbkN+liDGoYUR q5YyII/UguGHu8cjvaRZiSS+iGLEII0AVj83pc8uLQvFIzSzLhBx04y4QU51Vpaocw/qn3YrwWxVw 0iOYd3EHWdthz98GfYFWb4iOjUbelBDv87NYgHnZuRoJWyBexMrlK/2XVSx0E/CtygL+Cz5R6Lgwl tb7OyQx4g5EHzjzEBJXvOtgLhhISI7K1ztmZ/hJKm0uan+rWamP5+9XQywVwhXxoLbH9xF2weEzrq hnF2HNCnKA6tN1qLMCX9hA1DB5FDucQ8VVabF5rVMlzuK5I1DVgoj9BiOyJiWwsJkxhJij5qqZhMp udx7H5Aw==; Received: from m16.mail.126.com ([220.197.31.9]) by desiato.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh7Fm-00000004rFh-2Pbi for opensbi@lists.infradead.org; Mon, 04 Mar 2024 12:17:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=sZHWa psaM2AZosz4o9OgWfrec+EioHB4imdxRCoCOYw=; b=VzCNRgPiFk4YAIznfOvk1 t0S8+d2Q4DjVjI9xDLg4Ye96PU2xxw95M8OJPcVL+2eTHR/VdJSXIvCzWsu7QOuy M0tKq9OikmaERWL2DQYDjExOkpmJb7kRdrS/SA3xZqKqXAJ/LQs4PmpID4hrMeoQ N9S0yShdOrGUKc6LoDWYBo= Received: from T490.lan (unknown [112.83.183.140]) by gzga-smtp-mta-g0-0 (Coremail) with SMTP id _____wD33wl_u+VlK7dEAA--.3521S5; Mon, 04 Mar 2024 20:16:02 +0800 (CST) From: Xiang W To: opensbi@lists.infradead.org Cc: Xiang W , anup@brainfault.org Subject: [PATCH v6 3/5] firmware: fw_dynamic.S: Remove _bad_dynamic_info Date: Mon, 4 Mar 2024 20:15:50 +0800 Message-ID: <20240304121557.502655-4-wxjstz@126.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240304121557.502655-1-wxjstz@126.com> References: <20240304121557.502655-1-wxjstz@126.com> MIME-Version: 1.0 X-CM-TRANSID: _____wD33wl_u+VlK7dEAA--.3521S5 X-Coremail-Antispam: 1Uf129KBjvdXoWrZw17uw1rJF1Dur1ruryrCrg_yoWDCrc_AF y3uFnxCr4FvrWrta109r1rCw1xZF97ua1qg3WxCw4UXr13J343Xrn5CFW2qr4v9a10kr45 AF17CrnIyFn7ujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRuD73DUUUUU== X-Originating-IP: [112.83.183.140] X-CM-SenderInfo: pz0m23b26rjloofrz/xtbBdQeXOmSdLzkOYQAAsf X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240304_121711_258446_9D619F68 X-CRM114-Status: UNSURE ( 5.90 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "desiato.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: _bad_dynamic_info is same as _start_hang, so remove it. Signed-off-by: Xiang W Reviewed-by: Anup Patel --- firmware/fw_dynamic.S | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/firmware/fw_dynamic.S b/firmware/fw_dynamic.S index 7ff1c6a..5ee2883 100644 --- a/firmware/fw_dynamic.S +++ b/firmware/fw_dynamic.S @@ -11,12 +11,6 @@ Content analysis details: (1.5 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [220.197.31.9 listed in list.dnswl.org] 1.7 RCVD_IN_MSPIKE_L4 RBL: Bad reputation (-4) [220.197.31.9 listed in bl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 RCVD_IN_MSPIKE_BL Mailspike blocklisted 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [wxjstz(at)126.com] -0.0 T_SCC_BODY_TEXT_LINE No description available. X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org _bad_dynamic_info is same as _start_hang, so remove it. Signed-off-by: Xiang W Reviewed-by: Anup Patel --- firmware/fw_dynamic.S | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/firmware/fw_dynamic.S b/firmware/fw_dynamic.S index 7ff1c6a..5ee2883 100644 --- a/firmware/fw_dynamic.S +++ b/firmware/fw_dynamic.S @@ -11,12 +11,6 @@ #include "fw_base.S" - .section .entry, "ax", %progbits - .align 3 -_bad_dynamic_info: - wfi - j _bad_dynamic_info - .section .entry, "ax", %progbits .align 3 .global fw_boot_hart @@ -30,10 +24,10 @@ fw_boot_hart: /* Sanity checks */ li a1, FW_DYNAMIC_INFO_MAGIC_VALUE REG_L a0, FW_DYNAMIC_INFO_MAGIC_OFFSET(a2) - bne a0, a1, _bad_dynamic_info + bne a0, a1, _start_hang li a1, FW_DYNAMIC_INFO_VERSION_MAX REG_L a0, FW_DYNAMIC_INFO_VERSION_OFFSET(a2) - bgt a0, a1, _bad_dynamic_info + bgt a0, a1, _start_hang /* Read boot HART id */ li a1, FW_DYNAMIC_INFO_VERSION_2