From patchwork Mon Nov 20 09:52:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiang W X-Patchwork-Id: 1865914 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=POuQIXaz; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=126.com header.i=@126.com header.a=rsa-sha256 header.s=s110527 header.b=kBypHBrK; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SYjWQ03VSz1yRl for ; Mon, 20 Nov 2023 20:53:36 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=OorPEYNAbbmodeqViigv7/y5KuwsWYM3No1VNpQc1Ks=; b=POuQIXazVHKNOQ xrG29ua4m5ccWHxijIWDSx51WEu+3AshKGKfQ7DNClB3/PEvm9hslaVhKPqkJywrmWoVwKtSdnHbK CcGsvdhrDKWsqYquLwBJq2JVb+CUJaYBfGDk/uXeqLGenlihdfIMzJgdCWcaIwDJ2XxGwwFi7vNi3 OSBRgUHye2fD+LXwLGk2L2L5LsWlJOEgeDhjr+x6fVwpaz6oLZ3jX5m+GBaZXnjtLtqNbSivNxwE7 Irfbc2FgIbtFnAEwuHGwo32bpHje4O2wmXPRlrhoVdqWdiiDVvn4xC7/OBA2wIi/tCEfOWxd8KxIT NpRop175TsYBTYs6ziTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r50y2-00BgrY-3D; Mon, 20 Nov 2023 09:53:23 +0000 Received: from m15.mail.126.com ([45.254.50.223]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r50xx-00Bgpv-26 for opensbi@lists.infradead.org; Mon, 20 Nov 2023 09:53:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=li1aG LQCt9owqRa0ZMzyPzl/Z5V+HPRE/qWwfHZoMpI=; b=kBypHBrK+kATWwd0aNWDb Lvf38XtoIC5PRrSm4jPvokScsijaP2pd7ka35FFO7Fmzf+QTXKuFeqq4mj9N95h0 zLvtgXQicP+TR7H7ph5EJU9biYCSP3JxgKDnX9hQm86lrzM4MMlVKS1pjS1+EODI 1sZnBAtFMO8sjZYA4FN+Y4= Received: from T490.lan (unknown [112.83.182.199]) by zwqz-smtp-mta-g0-0 (Coremail) with SMTP id _____wD3ftWBLFtlo2pwAw--.17037S2; Mon, 20 Nov 2023 17:53:06 +0800 (CST) From: Xiang W To: opensbi@lists.infradead.org Cc: Xiang W Subject: [PATCH 1/2] lib: sbi: simplify sbi_ipi_send/sbi_ipi_process Date: Mon, 20 Nov 2023 17:52:42 +0800 Message-ID: <20231120095301.105772-1-wxjstz@126.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-CM-TRANSID: _____wD3ftWBLFtlo2pwAw--.17037S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7XF43Zr4Utw4kWrW7uFy3Jwb_yoWkJrg_ur yrAw1DWw4DXF4vqw15CF1DJryfKw4YvF18WF1j9rs8Aw4aqryDCryDJwnFyFn5WrW3XFy7 Gr17XFWkAr1aqjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7sRE_-BtUUUUU== X-Originating-IP: [112.83.182.199] X-CM-SenderInfo: pz0m23b26rjloofrz/xtbBdAcuOmSdLkcCmgAAsv X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231120_015318_063844_6544EF0A X-CRM114-Status: UNSURE ( 6.78 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Pass sbi_ipi_raw_send/sbi_ipi_raw_clear instead of direct access to ipi_dev. Signed-off-by: Xiang W --- lib/sbi/sbi_ipi.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/lib/sbi/sbi_ipi.c b/lib/sbi/sbi_ipi.c index 5571b37..30cb315 100644 --- a/lib/sbi/sbi_ipi.c +++ b/lib/sbi/sbi_ipi.c @@ -68,9 +68,7 @@ static int sbi_ipi_send(struct sbi_scratch *scratch, [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [45.254.50.223 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [wxjstz[at]126.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [45.254.50.223 listed in wl.mailspike.net] X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Pass sbi_ipi_raw_send/sbi_ipi_raw_clear instead of direct access to ipi_dev. Signed-off-by: Xiang W --- lib/sbi/sbi_ipi.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/lib/sbi/sbi_ipi.c b/lib/sbi/sbi_ipi.c index 5571b37..30cb315 100644 --- a/lib/sbi/sbi_ipi.c +++ b/lib/sbi/sbi_ipi.c @@ -68,9 +68,7 @@ static int sbi_ipi_send(struct sbi_scratch *scratch, u32 remote_hartindex, */ atomic_raw_set_bit(event, &ipi_data->ipi_type); smp_wmb(); - - if (ipi_dev && ipi_dev->ipi_send) - ipi_dev->ipi_send(remote_hartindex); + sbi_ipi_raw_send(remote_hartindex); sbi_pmu_ctr_incr_fw(SBI_PMU_FW_IPI_SENT); @@ -222,9 +220,7 @@ void sbi_ipi_process(void) u32 hartindex = sbi_hartid_to_hartindex(current_hartid()); sbi_pmu_ctr_incr_fw(SBI_PMU_FW_IPI_RECVD); - if (ipi_dev && ipi_dev->ipi_clear) - ipi_dev->ipi_clear(hartindex); - + sbi_ipi_raw_clear(hartindex); ipi_type = atomic_raw_xchg_ulong(&ipi_data->ipi_type, 0); ipi_event = 0; while (ipi_type) {