[v2,05/11] lib: sbi_hsm: Remove unnecessary include

Message ID	20230227103106.137995-6-ajones@ventanamicro.com
State	Accepted
Headers	show Return-Path: <opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> From: Andrew Jones <ajones@ventanamicro.com> To: opensbi@lists.infradead.org Cc: 'Ley Foon Tan ' <leyfoon.tan@starfivetech.com>, 'Atish Patra ' <atishp@rivosinc.com>, 'Anup Patel ' <apatel@ventanamicro.com>, 'Sia Jee Heng ' <jeeheng.sia@starfivetech.com>, Anup Patel <anup@brainfault.org> Subject: [PATCH v2 05/11] lib: sbi_hsm: Remove unnecessary include Date: Mon, 27 Feb 2023 11:31:00 +0100 Message-Id: <20230227103106.137995-6-ajones@ventanamicro.com> In-Reply-To: <20230227103106.137995-1-ajones@ventanamicro.com> References: <20230227103106.137995-1-ajones@ventanamicro.com> MIME-Version: 1.0 preview: Also remove a superfluous semicolon and add a blank line. Signed-off-by: Andrew Jones <ajones@ventanamicro.com> Reviewed-by: Anup Patel <anup@brainfault.org> --- lib/sbi/sbi_ecall_hsm.c \| 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:433 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain Precedence: list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "opensbi" <opensbi-bounces@lists.infradead.org> Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org
Series	SBI system suspend (SUSP) extension \| expand [v2,00/11] SBI system suspend (SUSP) extension [v2,01/11] lib: sbi_hsm: Factor out invalid state detection [v2,02/11] lib: sbi_hsm: Don't try to restore state on failed change [v2,03/11] lib: sbi_hsm: Ensure errors are consistent with spec [v2,04/11] lib: sbi_hsm: Move misplaced comment [v2,05/11] lib: sbi_hsm: Remove unnecessary include [v2,06/11] lib: sbi_hsm: Export some functions [v2,07/11] lib: sbi: Add system suspend skeleton [v2,08/11] lib: sbi: Add system_suspend_allowed domain property [v2,09/11] lib: sbi: Implement system suspend [v2,10/11] docs: Correct opensbi-domain property name [v2,11/11] platform: generic: Add system suspend test

Message ID

20230227103106.137995-6-ajones@ventanamicro.com

State

Accepted

Headers

From: Andrew Jones <ajones@ventanamicro.com>
To: opensbi@lists.infradead.org
Cc: 'Ley Foon Tan ' <leyfoon.tan@starfivetech.com>,
	'Atish Patra ' <atishp@rivosinc.com>,
	'Anup Patel ' <apatel@ventanamicro.com>,
	'Sia Jee Heng ' <jeeheng.sia@starfivetech.com>,
	Anup Patel <anup@brainfault.org>
Subject: [PATCH v2 05/11] lib: sbi_hsm: Remove unnecessary include
Date: Mon, 27 Feb 2023 11:31:00 +0100
Message-Id: <20230227103106.137995-6-ajones@ventanamicro.com>
In-Reply-To: <20230227103106.137995-1-ajones@ventanamicro.com>
References: <20230227103106.137995-1-ajones@ventanamicro.com>
MIME-Version: 1.0
Precedence: list
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "opensbi" <opensbi-bounces@lists.infradead.org>
Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org

Series

SBI system suspend (SUSP) extension | expand

Also remove a superfluous semicolon and add a blank line. Signed-off-by: Andrew Jones <ajones@ventanamicro.com> Reviewed-by: Anup Patel <anup@brainfault.org> --- lib/sbi/sbi_ecall_hsm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Anup Patel Feb. 27, 2023, 2:22 p.m. UTC | #1

On Mon, Feb 27, 2023 at 4:01 PM Andrew Jones <ajones@ventanamicro.com> wrote:
>
> Also remove a superfluous semicolon and add a blank line.
>
> Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
> Reviewed-by: Anup Patel <anup@brainfault.org>

Applied this patch to the riscv/opensbi repo.

Thanks,
Anup

> ---
>  lib/sbi/sbi_ecall_hsm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/sbi/sbi_ecall_hsm.c b/lib/sbi/sbi_ecall_hsm.c
> index 703a824493b4..f1b41d073b22 100644
> --- a/lib/sbi/sbi_ecall_hsm.c
> +++ b/lib/sbi/sbi_ecall_hsm.c
> @@ -12,7 +12,6 @@
>  #include <sbi/sbi_ecall_interface.h>
>  #include <sbi/sbi_error.h>
>  #include <sbi/sbi_trap.h>
> -#include <sbi/sbi_version.h>
>  #include <sbi/sbi_hsm.h>
>  #include <sbi/sbi_scratch.h>
>  #include <sbi/riscv_asm.h>
> @@ -45,7 +44,8 @@ static int sbi_ecall_hsm_handler(unsigned long extid, unsigned long funcid,
>                 break;
>         default:
>                 ret = SBI_ENOTSUPP;
> -       };
> +       }
> +
>         if (ret >= 0) {
>                 *out_val = ret;
>                 ret = 0;
> --
> 2.39.1
>

diff --git a/lib/sbi/sbi_ecall_hsm.c b/lib/sbi/sbi_ecall_hsm.c
index 703a824493b4..f1b41d073b22 100644
--- a/lib/sbi/sbi_ecall_hsm.c
+++ b/lib/sbi/sbi_ecall_hsm.c
@@ -12,7 +12,6 @@ 
 #include <sbi/sbi_ecall_interface.h>
 #include <sbi/sbi_error.h>
 #include <sbi/sbi_trap.h>
-#include <sbi/sbi_version.h>
 #include <sbi/sbi_hsm.h>
 #include <sbi/sbi_scratch.h>
 #include <sbi/riscv_asm.h>
@@ -45,7 +44,8 @@  static int sbi_ecall_hsm_handler(unsigned long extid, unsigned long funcid,
 		break;
 	default:
 		ret = SBI_ENOTSUPP;
-	};
+	}
+
 	if (ret >= 0) {
 		*out_val = ret;
 		ret = 0;

[v2,05/11] lib: sbi_hsm: Remove unnecessary include

Commit Message

Comments

Patch