From patchwork Thu Aug 25 04:51:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1670049 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=cYnw70d7; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ventanamicro.com header.i=@ventanamicro.com header.a=rsa-sha256 header.s=google header.b=ArgA+tvQ; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4MCrFj69Dwz1yhS for ; Thu, 25 Aug 2022 14:53:29 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZVkZ6SCJYfUev67POR3wHcfRjWrBqWxZcyweYB5iMy4=; b=cYnw70d7uqfJGM 54IyVxlHNNHdG4PdqzEL6aTNP4k647E0RZxDBHLzclwaeO3Cy8oCTrtruqVbtq67c+GGP+h+yZ2K7 YWTD5oyKIaQnceCNPyMQy8EsgSC85nkL97rhn3GLrx4OCvUbT/RMuk1rXMKroZ5Y8Y6I7cahKm9ri ycCrkLCpiPh9w5RJE+scFOg0me6LlQ3T8WOwhAVbnFplDXBkGu91kOpEZzb2oZ43HwA9PLGqk7uqO xGUPjpYN5QJAIhgbao3wDomTAGM5Lb5ZBjLioC/XHlCWPlXO1UDORi97kcCDYImnUXtxcjtu0Nbt6 UI8ek45kBJJP32tNN9vQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oR4rC-006rGN-Qa; Thu, 25 Aug 2022 04:52:42 +0000 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oR4r7-006rAb-EO for opensbi@lists.infradead.org; Thu, 25 Aug 2022 04:52:42 +0000 Received: by mail-pg1-x52e.google.com with SMTP id s206so16892593pgs.3 for ; Wed, 24 Aug 2022 21:52:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=sXZtSFd0i8xmlHpu56to8A+EduA6PFSym1ozLC/HWUk=; b=ArgA+tvQFG9KOHx20o3Ot1ycLvNdy+2/egWIcu3zKxMlUQeM25Tu85qWKtLyIv113P 6SzstSx3h516V4tHbTfwfIsEIYa4tkZHSLhiYiNSvyfSmgaMh74fvCeTZaNCXdrMW9F/ IfZFoopD9LcOSmhUSYf48cHX9dwXY1WpY7hYcn5YZKXrPZjiyv/mr+H9ZZXEfqyqqFlU buXzGECoDWoY6E0ZKw3LmPiYtZQJWW9nyThqyIku3q9J9XeIxt4Jy1ZprPPqj3893mx6 PuN1IX0Bzl8DSvp4vQqE7QgLxG+uo2O7XoBv1VazFzZs8bCQiyCm8bStkH2tdnG7Xc0B yxZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=sXZtSFd0i8xmlHpu56to8A+EduA6PFSym1ozLC/HWUk=; b=51krDWAE83sPwJcSRKxXpjodj4WnAHlp3e2aYZJeptDNLzHsGwrbXngKgX+KzKhsYE 1Dnyt/peocImdXd2o1W+10GbYtZwTAzxNRtRQEs1tAY4BNcAV1HTd6FIpH20rD4B2/Av a3A4zYTr8a96mFA/kxYquJ24scjYRKhgAxSVmmw4NxWFIZX1d+nqBgLqGvWPTq3Vwu1t 4N76Kc+GaM/eL4zYJNNQ9F8e+W3OZ7a6sM0YBWgxjAGlOYteyEGB7DQtUBm4wHku96iW tQpGguGBk0GvGui4H34RTYur/6eF079B95Rj2m33YKM20EoM+LR1knk+CkFmd6Te+RJa HuJA== X-Gm-Message-State: ACgBeo1KoVk+nwmHqhjCNLIj523krUQGzgI+0Q2ngJePhX7WyB7/iyyI NZYfIY+OHruPVC3FsKC+FNUbWnCxnXLKRA== X-Google-Smtp-Source: AA6agR7fD0Atgsmw1EuAwQ7zsBJV5yfCyb8DnedeiNBcWWc/dlYPzSaAXkkO2iR725ZLt/pTJb5VmA== X-Received: by 2002:a63:231a:0:b0:429:fb01:3c5d with SMTP id j26-20020a63231a000000b00429fb013c5dmr1771564pgj.583.1661403155752; Wed, 24 Aug 2022 21:52:35 -0700 (PDT) Received: from anup-ubuntu64-vm.. ([171.76.87.159]) by smtp.gmail.com with ESMTPSA id g5-20020a170902d1c500b0016eea511f2dsm13318881plb.242.2022.08.24.21.52.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Aug 2022 21:52:35 -0700 (PDT) From: Anup Patel To: Atish Patra , Alistair Francis Cc: Anup Patel , opensbi@lists.infradead.org, Anup Patel , Andrew Jones Subject: [PATCH 3/7] lib: sbi_pmu: Firmware counters are always 64 bits wide Date: Thu, 25 Aug 2022 10:21:40 +0530 Message-Id: <20220825045144.752619-4-apatel@ventanamicro.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220825045144.752619-1-apatel@ventanamicro.com> References: <20220825045144.752619-1-apatel@ventanamicro.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220824_215237_500072_0C30A057 X-CRM114-Status: GOOD ( 10.49 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: As-per SBI specification, all firmware counters are always 64 bits wide so let us update the SBI PMU implementation to reflect this fact. Signed-off-by: Anup Patel Reviewed-by: Andrew Jones --- lib/sbi/sbi_pmu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:52e listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org As-per SBI specification, all firmware counters are always 64 bits wide so let us update the SBI PMU implementation to reflect this fact. Signed-off-by: Anup Patel Reviewed-by: Andrew Jones --- lib/sbi/sbi_pmu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/sbi/sbi_pmu.c b/lib/sbi/sbi_pmu.c index 250808e..1c01d34 100644 --- a/lib/sbi/sbi_pmu.c +++ b/lib/sbi/sbi_pmu.c @@ -36,7 +36,7 @@ struct sbi_pmu_hw_event { /** Representation of a firmware event */ struct sbi_pmu_fw_event { /* Current value of the counter */ - unsigned long curr_count; + uint64_t curr_count; /* A flag indicating pmu event monitoring is started */ bool bStarted; @@ -719,8 +719,8 @@ int sbi_pmu_ctr_get_info(uint32_t cidx, unsigned long *ctr_info) } else { /* it's a firmware counter */ cinfo.type = SBI_PMU_CTR_TYPE_FW; - /* Firmware counters are XLEN bits wide */ - cinfo.width = BITS_PER_LONG - 1; + /* Firmware counters are always 64 bits wide */ + cinfo.width = 63; } *ctr_info = cinfo.value;