Message ID | 20210924032642.1220557-6-anup.patel@wdc.com |
---|---|
State | Superseded |
Headers | show
Return-Path: <opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=KGOOrlQv; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=IFJJACZA; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-sharedspace-onmicrosoft-com header.b=fFCq9E4K; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=<UNKNOWN>) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4HFyC16Nq1z9sXk for <incoming@patchwork.ozlabs.org>; Fri, 24 Sep 2021 13:27:25 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MrRZ8m4RzeCwBehlLYLxXD6rY9UJTOCHkU2fNtodF/k=; b=KGOOrlQvKIaIBP JlVlQcdnCIkvMWwNV9Jk7W9fPuP3319bjSLFxNWaBwsaqu2gq/y+rIrzUJeTCjzQrx5X0L1NWmzj3 iW0HzqhOdEOWOGwPHeGkDncb13Lt52HiE7lpwBOD1lJ7vlabqDoUxgYvzLQGZC6Ar/beXpss/wUks pKT8HGuPD6Ui1pcI6RGtyxKBDo1spFQedZBnKA1Jt2pzEftQpO6c0segjx3ljfFn1Xq+DQOKzwZBi KZE8q9K0Y9XYnbai0kzsoM/4q5KUf2g67DFmHaj1rAKagX9LA1EtnH5pQiR0wX62h0aqUvVFU/EIj JTmcPn7C3IZ2bw1S0MxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTbrt-00Czr8-1L; Fri, 24 Sep 2021 03:27:21 +0000 Received: from esa4.hgst.iphmx.com ([216.71.154.42]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTbrq-00Czpf-LU for opensbi@lists.infradead.org; Fri, 24 Sep 2021 03:27:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1632454038; x=1663990038; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=+6ZbXpPX6FykaOzCEIsdZLv0wg+e4AsdodzfMtQ34U8=; b=IFJJACZAy6oK20WNXjsg9M4pAI72K5sAx2xqxVgLRpP2daT4fQ/3bX6i H88VRxMlFVqTuY6xZivNB9kEjNbPy1vjdQGQzt6FzjKalSIYFn//4A/2y heAGyHsgWDWkV3iqKxLZmCnrWsGAf6krczHiSnxJCVXhFbnkxHjGfCovx JNrIwRoNPRNRssIwqNLRWdh6FeZbg+4YEQgkRinHwtB/53GAp/ZULbkhC 6jTB2+qEZ3bwkBCf2tIkissaSblD4QeQ2OkCV6j7wea6JEuTlwed0o4gi W9kUNjrHR5obKTHysNodmNXnCVUj3zRuWqoY3Raf/662PXH57xNTgaUbT A==; X-IronPort-AV: E=Sophos;i="5.85,318,1624291200"; d="scan'208";a="179886315" Received: from mail-bn7nam10lp2104.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.104]) by ob1.hgst.iphmx.com with ESMTP; 24 Sep 2021 11:27:17 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PyXQdt+NqDU1oS5+6jIHxHTaAnYn9MURhVw6f08SBTqPBVJ8ANYlQEn4uNYQcE8h2tHytCknAIVoiCqX0cXu/PlM5FVcIQZrbg9AwsdVjM3jlfSv/yYM7b3k6ODsMtXfpxZRmga1DFTG0+CchDik7q0e9mTBLOASxP5YO9Yx9BaDKUw+v/PMQpQbLpgFFprEL4ZDAYi6/3NTzCb1ByeT/tIT0S1wNUwRRZkvDYa7uCJtEV5t8Pc4qoF7mh59saaI3ZPcOwWy0jlJ5y+fNjR+gD0RHQQqP0wlRDnlUczHyrt8Vru9pnzXhRfo30R2H0DYl0V1HmB0wT3pouub27fkzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qI97LPfJCM4p/swnS0q6X3FN6VVa8Vjvs4Ce7yqHwr4=; b=IcFQI1ycyZES0uMantsJvnkFu8rVxhMx9/zvht2ghVJUuPnQmxdEgfALtzoJmFPPubeFcGzN13tvc1ZUh1umYkOytq5T/qVW+++gn8qDbOGbuvpQUj6aUmUnJhlM8waDBW9/mlbFXRnoMTr4wV0tIeqqNZVR9NgxznTY0bUrbpLmCfzZpj6wBKe31HtP1LlkdI0OV/1HFiCi/AooqJXUzpwKQGBls6R19DGj3fr69gQbGgbu6+qsl2utBh4R6XwBYiq0Gj6BQ+LsqY4IPaEzijRHI+6F8R0TSnbuo6oi/siNkv+J0Itxpu5r7OsRLCWqfr58IBqldjeLFU/pmcescQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qI97LPfJCM4p/swnS0q6X3FN6VVa8Vjvs4Ce7yqHwr4=; b=fFCq9E4KUovExVepk3JVdC3S+RJ7+zYkRiOyfTTYjD7TvAK8F5llOcyXBWpQmothgBTVjUY9Xu/EfKRDHNcfL9OZ/dn3BYk7e7itYhvKE5FCM8One5BUmInxiYpA05ZSghxQ9QlgSmS/cQ23Veq1NixS35ItHGVvi/FcJFOCi2A= Authentication-Results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; Received: from CO6PR04MB7812.namprd04.prod.outlook.com (2603:10b6:303:138::6) by CO6PR04MB7763.namprd04.prod.outlook.com (2603:10b6:5:359::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Fri, 24 Sep 2021 03:27:16 +0000 Received: from CO6PR04MB7812.namprd04.prod.outlook.com ([fe80::6830:650b:8265:af0b]) by CO6PR04MB7812.namprd04.prod.outlook.com ([fe80::6830:650b:8265:af0b%6]) with mapi id 15.20.4544.015; Fri, 24 Sep 2021 03:27:16 +0000 From: Anup Patel <anup.patel@wdc.com> To: Atish Patra <atish.patra@wdc.com>, Alistair Francis <Alistair.Francis@wdc.com> Cc: Anup Patel <anup@brainfault.org>, opensbi@lists.infradead.org, Anup Patel <anup.patel@wdc.com>, Bin Meng <bmeng.cn@gmail.com> Subject: [PATCH v2 5/5] lib: utils/reset: use sbi_timer_mdelay() in gpio reset driver Date: Fri, 24 Sep 2021 08:56:42 +0530 Message-Id: <20210924032642.1220557-6-anup.patel@wdc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210924032642.1220557-1-anup.patel@wdc.com> References: <20210924032642.1220557-1-anup.patel@wdc.com> X-ClientProxiedBy: MA1PR01CA0074.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00::14) To CO6PR04MB7812.namprd04.prod.outlook.com (2603:10b6:303:138::6) MIME-Version: 1.0 Received: from wdc.com (122.171.179.169) by MA1PR01CA0074.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15 via Frontend Transport; Fri, 24 Sep 2021 03:27:14 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e8949d91-b856-4e5f-35af-08d97f0b3539 X-MS-TrafficTypeDiagnostic: CO6PR04MB7763: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: <CO6PR04MB776376A7FF2E65EC3D9C1D468DA49@CO6PR04MB7763.namprd04.prod.outlook.com> WDCIPOUTBOUND: EOP-TRUE X-MS-Oob-TLC-OOBClassifiers: OLM:2582; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Cw1EPbkB85oCmkJkq1o6O+U404bV9rTe75rBMTTxnDStUa2QDDHs0Kvh8kKGDIbV/8KeM6GzimOBV9w1KhwTckHUzFW9FQqzcN2unkF+N/t6Jlx0Ad2fotm1MOvb9js0CROdfdTZJdp/PsP4kZs5zGX8GHPfRT/C3Zf0VEQcbkp7uB46DScE3iTz9PHjaLxxjeQweU9GqrOVdv8cClrDCpgKN+63VaFvtZO7duYQBCt5NTRqCSDrOBsTB0MsXGpVDqUJk6zETIv3DVH1AcvNOPW1OhlLLhhJrrPO1GZza/ti0Z0AAptbGaxIcpAarRhffMhfePl70Pt1Dk31PnrdmAknUvU4t81UqZYm9pnii+15XYFPfIDiTsR8zD2nPvB+jzlGpVvpz5mc+2hAJ7mv+UTqcwPrTqq16syQZj2c5BJM5UfXku+8LIluhGMJpJiFyk9SIfCkuA2VSA6p+hkMP0fgaicQ9bzDyNc1afqQY7sK+b68jsm5iz+IpZyR1t4Lp+i4pcSolVMz1D+R4iU1SbeKHGYmiR+h/0F9MeAESzN027it5wl5o/XrcStCGCFepxw7GyXG+vfHyy3T9/uLab1glYOlGT9he0GcKSrnqFYtPIRm36helIAam1wXrOeiotiW8F31zz6HVq05bWwvqx5mG1ftBpEghGvq9Hn/hSGormrERRlzInj3hc7D5M0zohe2hFPPe2ldbm7LRHRKtw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR04MB7812.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(186003)(44832011)(5660300002)(38350700002)(8936002)(4326008)(316002)(6666004)(54906003)(110136005)(7696005)(36756003)(55016002)(52116002)(1076003)(2906002)(26005)(6636002)(83380400001)(508600001)(8676002)(66476007)(66556008)(8886007)(66946007)(86362001)(2616005)(38100700002)(956004); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: kuNf+c9dECS3imep+JRw63wdLsXvgIgmfpcG/cThxPDLtUpBQhdhbVnW7v0LX0ww5nWsIp54YmqEHh4vXb5K0FNsg0aAiGDix+/n6+yx8UIeFSQcp0JUjTV8YGI5ho5AKFZk9F63db8Dcgi1vhLKr3i2O2Tk2KqxBgFpHBCdpatFXQYEZEgGGYPDZUIzk9hTOyJ2VhANJ3sgALZHRArjCDYVq9A9eUl/aQ0ebarkKqJIFuDdpqwrNMaXZXFeTjCrPOY2zc+Gqo4ARMYjJRIzzFUafZ5y7aRkkYgaT3Xplq1vgimmJtDDMylLqfqstfoGFWIC0R8INILs54Pc3xMs5GMm7ko7PMbdDjoIiyfvwxWDFM5ZoXf0ddWThPU8Ms7UvBD6mSwCMaU4MVab5BYXXgm+kOvG5MozrQAHF3WSuJQc7GR+e5Izpy0j6HNcA4J0ycHaonhdXh8CWVRec7xNYjudSNgbBqUtPuV7nZG8R0gxaCwEe8HFfW/n8gT7qjNByp2+p9fHujF/E9hfNPRCssoYzWSAhE4Y3SBa/ARXwGyPEmpjou0VZqNj/croVgEJaB/YlOq8CJo7xaTubybIb2z5z3IAckxN2bJTb+Lvye1J41M1RJLKSwnP/YR5OsnDWUbNgrfYF5JS1B6RklKbYe8xsaAJxhyWX3yLx3VmlO503cJHxPRmRAt8xtl9rHQC4PKj5m0iOWHECCrENyLDWqUxuw/+PHZNlw5aJXjbMPHjupcDT+yzhdswiT64uYWMuEnsZeNCE+7drHiEmeBvoLP2kbZtc3iz30oskVi58IcUse6wwBhIa4oLqrHznElo9bDSdM/86DwJlejRNn9S4CCs0ZBLQHMCuUtN86y8T7rtlyriLd4rAtdJtmrF2nAg8Da2hVTM3InAeCPDwzo8IxjJ1TGGGwjH6FVcea1kLZOsnWUdsUaLeWytTurz6HSe/QZ5ryWZMntswtKP7Rv9H1wk27FcDPY32St1cWCvlEXrjreilgBNjcnHEF5WSXF7CLFH4iFnw5zR2Bw1/LefHIvyj8xpVnZXZHQE4rusg+Q7Zc4iwli+IDCi5lheZCdA6pVzqx9nO8CFLsVz9GIhfe5l+cT+tZ8hrH1FmYXj7M8+ka2BApPkEEDRv+sWDKcUZV4zWo4O2nrLsGbnQuf97KZzXEJNkYmkzAJorUfDKPlcKqKoXgEmnITIiw1yb22xtARikScEqxIiWFww7waRjiImBdHIdsZOJFilzQMMmQ7NdCbe6NR6RewDJ1BJh7YzBdk6Y2h3vPvWOyG9DYdJ96n+mKN2taMXCQvy/Uck8J0im53FbDTWZAtp+WQTQNeS X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8949d91-b856-4e5f-35af-08d97f0b3539 X-MS-Exchange-CrossTenant-AuthSource: CO6PR04MB7812.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2021 03:27:16.5538 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g3xqFwQIScAYp9ODE74SJX3fBb90X/hBEH/DNxNa7OOFaow28sH68hkS0FZmrMB/mKz/tdUTTBNQ6mnqcri63A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR04MB7763 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210923_202718_829101_737DC2F4 X-CRM114-Status: GOOD ( 14.74 ) X-Spam-Score: -2.5 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: We should use sbi_timer_mdelay() instead of custom gpio_mdelay() in the gpio reset driver. Signed-off-by: Anup Patel <anup.patel@wdc.com> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> --- lib/utils/reset/fdt_reset_gpio.c | 13 +++ 1 file changed, 3 insertions(+), 10 deletions(-) Content analysis details: (-2.5 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [216.71.154.42 listed in list.dnswl.org] 0.0 SPF_NONE SPF: sender does not publish an SPF Record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <opensbi.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/opensbi>, <mailto:opensbi-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/opensbi/> List-Post: <mailto:opensbi@lists.infradead.org> List-Help: <mailto:opensbi-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/opensbi>, <mailto:opensbi-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "opensbi" <opensbi-bounces@lists.infradead.org> Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
Timer based delay loop
|
expand
|
diff --git a/lib/utils/reset/fdt_reset_gpio.c b/lib/utils/reset/fdt_reset_gpio.c index 77e308a..30127f5 100644 --- a/lib/utils/reset/fdt_reset_gpio.c +++ b/lib/utils/reset/fdt_reset_gpio.c @@ -14,6 +14,7 @@ #include <sbi/sbi_ecall_interface.h> #include <sbi/sbi_hart.h> #include <sbi/sbi_system.h> +#include <sbi/sbi_timer.h> #include <sbi_utils/fdt/fdt_helper.h> #include <sbi_utils/gpio/fdt_gpio.h> #include <sbi_utils/reset/fdt_reset.h> @@ -34,14 +35,6 @@ static struct gpio_reset restart = { .inactive_delay = 100 }; -/* Custom mdelay function until we have a generic mdelay() API */ -static void gpio_mdelay(unsigned long msecs) -{ - volatile int i; - while (msecs--) - for (i = 0; i < 100000; i++) ; -} - static int gpio_system_reset_check(u32 type, u32 reason) { switch (type) { @@ -76,11 +69,11 @@ static void gpio_system_reset(u32 type, u32 reason) /* drive it active, also inactive->active edge */ gpio_direction_output(&reset->pin, 1); - gpio_mdelay(reset->active_delay); + sbi_timer_mdelay(reset->active_delay); /* drive inactive, also active->inactive edge */ gpio_set(&reset->pin, 0); - gpio_mdelay(reset->inactive_delay); + sbi_timer_mdelay(reset->inactive_delay); /* drive it active, also inactive->active edge */ gpio_set(&reset->pin, 1);