diff mbox series

[5/7] lib: sbi: Make the root domain instance global variable

Message ID 20210410071808.759856-6-anup.patel@wdc.com
State Superseded
Headers show
Series Protect M-mode only MMIO devices | expand

Commit Message

Anup Patel April 10, 2021, 7:18 a.m. UTC
We make the the root domain instance global variable so that
platform support and drivers can iterate over the root domain
regions.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
---
 include/sbi/sbi_domain.h | 3 +++
 lib/sbi/sbi_domain.c     | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

Comments

Xiang W April 11, 2021, 10:07 a.m. UTC | #1
在 2021-04-10六的 12:48 +0530,Anup Patel写道:
> We make the the root domain instance global variable so that
> platform support and drivers can iterate over the root domain
> regions.
> 
> Signed-off-by: Anup Patel <anup.patel@wdc.com>
looks good to me.

Reviewed-by: Xiang W <wxjstz@126.com>

Regards,
Xiang W
> ---
>  include/sbi/sbi_domain.h | 3 +++
>  lib/sbi/sbi_domain.c     | 2 +-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/include/sbi/sbi_domain.h b/include/sbi/sbi_domain.h
> index b5f2f38..ef53ca5 100644
> --- a/include/sbi/sbi_domain.h
> +++ b/include/sbi/sbi_domain.h
> @@ -80,6 +80,9 @@ struct sbi_domain {
>  	bool system_reset_allowed;
>  };
>  
> +/** The root domain instance */
> +extern struct sbi_domain root;
> +
>  /** HART id to domain table */
>  extern struct sbi_domain *hartid_to_domain_table[];
>  
> diff --git a/lib/sbi/sbi_domain.c b/lib/sbi/sbi_domain.c
> index 8afdb5d..5e3a30d 100644
> --- a/lib/sbi/sbi_domain.c
> +++ b/lib/sbi/sbi_domain.c
> @@ -29,7 +29,7 @@ static u32 root_memregs_count = 0;
>  static struct sbi_domain_memregion root_fw_region;
>  static struct sbi_domain_memregion root_memregs[ROOT_REGION_MAX + 1]
> = { 0 };
>  
> -static struct sbi_domain root = {
> +struct sbi_domain root = {
>  	.name = "root",
>  	.possible_harts = &root_hmask,
>  	.regions = root_memregs,
> -- 
> 2.25.1
> 
>
Alistair Francis April 11, 2021, 9:29 p.m. UTC | #2
On Sat, 2021-04-10 at 12:48 +0530, Anup Patel wrote:
> We make the the root domain instance global variable so that
> platform support and drivers can iterate over the root domain
> regions.
> 
> Signed-off-by: Anup Patel <anup.patel@wdc.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  include/sbi/sbi_domain.h | 3 +++
>  lib/sbi/sbi_domain.c     | 2 +-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/include/sbi/sbi_domain.h b/include/sbi/sbi_domain.h
> index b5f2f38..ef53ca5 100644
> --- a/include/sbi/sbi_domain.h
> +++ b/include/sbi/sbi_domain.h
> @@ -80,6 +80,9 @@ struct sbi_domain {
>         bool system_reset_allowed;
>  };
>  
> +/** The root domain instance */
> +extern struct sbi_domain root;
> +
>  /** HART id to domain table */
>  extern struct sbi_domain *hartid_to_domain_table[];
>  
> diff --git a/lib/sbi/sbi_domain.c b/lib/sbi/sbi_domain.c
> index 8afdb5d..5e3a30d 100644
> --- a/lib/sbi/sbi_domain.c
> +++ b/lib/sbi/sbi_domain.c
> @@ -29,7 +29,7 @@ static u32 root_memregs_count = 0;
>  static struct sbi_domain_memregion root_fw_region;
>  static struct sbi_domain_memregion root_memregs[ROOT_REGION_MAX + 1] =
> { 0 };
>  
> -static struct sbi_domain root = {
> +struct sbi_domain root = {
>         .name = "root",
>         .possible_harts = &root_hmask,
>         .regions = root_memregs,
diff mbox series

Patch

diff --git a/include/sbi/sbi_domain.h b/include/sbi/sbi_domain.h
index b5f2f38..ef53ca5 100644
--- a/include/sbi/sbi_domain.h
+++ b/include/sbi/sbi_domain.h
@@ -80,6 +80,9 @@  struct sbi_domain {
 	bool system_reset_allowed;
 };
 
+/** The root domain instance */
+extern struct sbi_domain root;
+
 /** HART id to domain table */
 extern struct sbi_domain *hartid_to_domain_table[];
 
diff --git a/lib/sbi/sbi_domain.c b/lib/sbi/sbi_domain.c
index 8afdb5d..5e3a30d 100644
--- a/lib/sbi/sbi_domain.c
+++ b/lib/sbi/sbi_domain.c
@@ -29,7 +29,7 @@  static u32 root_memregs_count = 0;
 static struct sbi_domain_memregion root_fw_region;
 static struct sbi_domain_memregion root_memregs[ROOT_REGION_MAX + 1] = { 0 };
 
-static struct sbi_domain root = {
+struct sbi_domain root = {
 	.name = "root",
 	.possible_harts = &root_hmask,
 	.regions = root_memregs,