[RFC,03/14] lib: sbi: Remove stray '\' character

Message ID	20210319221305.2138412-4-atish.patra@wdc.com
State	Superseded
Headers	show Return-Path: <opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> IronPort-SDR: nIF56HwPXaLHic52LC7vN8ULWtWsROMnoWYaTd+VpITbFvatrFMLJFdjF2t66WCm5Qa4Yx7uwD OTQg+I0aFcE4LMFUMBApzqA9+68zRblG/XSsHCSc2qM8PwQplaQ13wpxfEIx0flbT3lLYm4F8L /KLdtrhDOvq9cDYpybPzCVp6BDEtZgtaPRXZTNfKv82qDQ01TUHfomsBCWWyf5F2qUwS6SFGzc sWzkY8NHvFEoGQTz0hglOW99g54D7P8UY7I0FDQ6IKUYSlF/sFRRsCS9lWzMI/RwAuGwQbRT1s Bz0= IronPort-SDR: bFKthvrqdsIiHWih8b7YOzemZwLx7/M1yz4U2Ck+g669IEWtDL9A0ozjXhglVLlmgcf/Slf8mK kDS4S6RtOupt7q7Fby6J2uw7hjkon5o22J+4BPW49v57lD2qcGamR1ZyH8XD/KQh8U5/sCwef3 yPRH6i8SQ6ewSsnRbWsncYyoW19Py2nUdKrJAtbpjJ2sbnTFhNpiZtyuL3zDDQ8G/zbGBAeHsl wOjtOc/VTy6YhBAvYB1mnWxO+jG4bAASlCyHCFU5pLR5RzPTLTg9s0UuN9AfSHlLFqZwM9Ukmh GKqzBvV/UpYDLRXMt/QT5lgq IronPort-SDR: bWDCvrWZVILQKYspJN8ubr3rjtvEOr2vpotIc9DOM97RmgEOsEu1KAM828fno2UlGGhwWz9nAI pm9LRmk0jbhLzOn1t7ZSCkjwOojdNpVUapiUVF8jsmAXltRRDYwEYVuw/ob83S4hmf3XM/U7/R Z639ugqCl4FEd6uDKjWE1W4wQV8QBLAL0HSJdW1Or1ngYlwwlUqJx72iwoCNrQl0LBWJ0u0XLG XFlXrbVGZ4oZoi3IANYC0QtMSnwUG9sJKXurML+CT6cfHUE1j/XcuLW2ekAh+KVcqwYAcMsQSv +Fc= WDCIronportException: Internal From: Atish Patra <atish.patra@wdc.com> To: opensbi@lists.infradead.org Cc: Atish Patra <atish.patra@wdc.com>, anup.patel@wdc.com Subject: [RFC 03/14] lib: sbi: Remove stray '\' character Date: Fri, 19 Mar 2021 15:12:54 -0700 Message-Id: <20210319221305.2138412-4-atish.patra@wdc.com> In-Reply-To: <20210319221305.2138412-1-atish.patra@wdc.com> References: <20210319221305.2138412-1-atish.patra@wdc.com> MIME-Version: 1.0 preview: Signed-off-by: Atish Patra <atish.patra@wdc.com> --- lib/sbi/sbi_hart.c \| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sbi/sbi_hart.c b/lib/sbi/sbi_hart.c index 0b3bb6237182..ee11b2133d05 100644 --- a/lib/sbi/sbi_hart.c +++ b/lib/sbi/sbi_hart.c @@ -320, 7 +320, 7 @@ static unsigned long hart_pmp_get_all [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [216.71.154.45 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain Precedence: list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "opensbi" <opensbi-bounces@lists.infradead.org> Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org
Series	SBI PMU extension support \| expand [RFC,00/14] SBI PMU extension support [RFC,01/14] docs: Add device tree bindings for SBI PMU extension [RFC,02/14] lib: sbi: Detect mcountinihibit support at runtime [RFC,03/14] lib: sbi: Remove stray '\' character [RFC,04/14] lib: sbi: Detect number of bits implemented in mhpmcounter [RFC,05/14] lib: sbi: Disable m/scounteren & enable mcountinhibit [RFC,06/14] include: Add a list empty check function [RFC,07/14] lib: sbi: Remove redundant boot time print statement [RFC,08/14] lib: sbi: Use csr_read/write_num to read/update PMU counters [RFC,09/14] lib: sbi: Add PMU specific platform hooks [RFC,10/14] lib: sbi: Add PMU support [RFC,11/14] utils: fdt: Add fdt helper functions to parse PMU DT nodes [RFC,12/14] lib: sbi: Implement SBI PMU extension [RFC,13/14] lib: sbi: Implement firmware counters [RFC,14/14] platform: generic: Add PMU support

Message ID

20210319221305.2138412-4-atish.patra@wdc.com

State

Superseded

Headers

IronPort-SDR: 
 nIF56HwPXaLHic52LC7vN8ULWtWsROMnoWYaTd+VpITbFvatrFMLJFdjF2t66WCm5Qa4Yx7uwD
 OTQg+I0aFcE4LMFUMBApzqA9+68zRblG/XSsHCSc2qM8PwQplaQ13wpxfEIx0flbT3lLYm4F8L
 /KLdtrhDOvq9cDYpybPzCVp6BDEtZgtaPRXZTNfKv82qDQ01TUHfomsBCWWyf5F2qUwS6SFGzc
 sWzkY8NHvFEoGQTz0hglOW99g54D7P8UY7I0FDQ6IKUYSlF/sFRRsCS9lWzMI/RwAuGwQbRT1s
 Bz0=
IronPort-SDR: 
 bFKthvrqdsIiHWih8b7YOzemZwLx7/M1yz4U2Ck+g669IEWtDL9A0ozjXhglVLlmgcf/Slf8mK
 kDS4S6RtOupt7q7Fby6J2uw7hjkon5o22J+4BPW49v57lD2qcGamR1ZyH8XD/KQh8U5/sCwef3
 yPRH6i8SQ6ewSsnRbWsncYyoW19Py2nUdKrJAtbpjJ2sbnTFhNpiZtyuL3zDDQ8G/zbGBAeHsl
 wOjtOc/VTy6YhBAvYB1mnWxO+jG4bAASlCyHCFU5pLR5RzPTLTg9s0UuN9AfSHlLFqZwM9Ukmh
 GKqzBvV/UpYDLRXMt/QT5lgq
IronPort-SDR: 
 bWDCvrWZVILQKYspJN8ubr3rjtvEOr2vpotIc9DOM97RmgEOsEu1KAM828fno2UlGGhwWz9nAI
 pm9LRmk0jbhLzOn1t7ZSCkjwOojdNpVUapiUVF8jsmAXltRRDYwEYVuw/ob83S4hmf3XM/U7/R
 Z639ugqCl4FEd6uDKjWE1W4wQV8QBLAL0HSJdW1Or1ngYlwwlUqJx72iwoCNrQl0LBWJ0u0XLG
 XFlXrbVGZ4oZoi3IANYC0QtMSnwUG9sJKXurML+CT6cfHUE1j/XcuLW2ekAh+KVcqwYAcMsQSv
 +Fc=
WDCIronportException: Internal
From: Atish Patra <atish.patra@wdc.com>
To: opensbi@lists.infradead.org
Cc: Atish Patra <atish.patra@wdc.com>,
	anup.patel@wdc.com
Subject: [RFC 03/14] lib: sbi: Remove stray '\' character
Date: Fri, 19 Mar 2021 15:12:54 -0700
Message-Id: <20210319221305.2138412-4-atish.patra@wdc.com>
In-Reply-To: <20210319221305.2138412-1-atish.patra@wdc.com>
References: <20210319221305.2138412-1-atish.patra@wdc.com>
MIME-Version: 1.0
Precedence: list
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "opensbi" <opensbi-bounces@lists.infradead.org>
Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org

Series

SBI PMU extension support | expand

Comments

Anup Patel April 8, 2021, 3:15 a.m. UTC | #1

> -----Original Message-----
> From: Atish Patra <atish.patra@wdc.com>
> Sent: 20 March 2021 03:43
> To: opensbi@lists.infradead.org
> Cc: Atish Patra <Atish.Patra@wdc.com>; Anup Patel <Anup.Patel@wdc.com>
> Subject: [RFC 03/14] lib: sbi: Remove stray '\' character
> 
> Signed-off-by: Atish Patra <atish.patra@wdc.com>

Looks good to me.

Reviewed-by: Anup Patel <anup.patel@wdc.com>

Regards,
Anup

> ---
>  lib/sbi/sbi_hart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/sbi/sbi_hart.c b/lib/sbi/sbi_hart.c index
> 0b3bb6237182..ee11b2133d05 100644
> --- a/lib/sbi/sbi_hart.c
> +++ b/lib/sbi/sbi_hart.c
> @@ -320,7 +320,7 @@ static unsigned long
> hart_pmp_get_allowed_addr(void)
>  	unsigned long val = 0;
>  	struct sbi_trap_info trap = {0};
> 
> -	csr_write_allowed(CSR_PMPADDR0, (ulong)&trap,
> PMP_ADDR_MASK);			\
> +	csr_write_allowed(CSR_PMPADDR0, (ulong)&trap,
> PMP_ADDR_MASK);
>  	if (!trap.cause) {
>  		val = csr_read_allowed(CSR_PMPADDR0, (ulong)&trap);
>  		if (trap.cause)
> --
> 2.25.1

Xiang W April 19, 2021, 3:46 a.m. UTC | #2

在 2021-03-19五的 15:12 -0700，Atish Patra写道：
> Signed-off-by: Atish Patra <atish.patra@wdc.com>
Look good to me.

Reviewed-by: Xiang W <wxjstz@126.com>

Regards,
Xiang W
> ---
>  lib/sbi/sbi_hart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/sbi/sbi_hart.c b/lib/sbi/sbi_hart.c
> index 0b3bb6237182..ee11b2133d05 100644
> --- a/lib/sbi/sbi_hart.c
> +++ b/lib/sbi/sbi_hart.c
> @@ -320,7 +320,7 @@ static unsigned long
> hart_pmp_get_allowed_addr(void)
>  	unsigned long val = 0;
>  	struct sbi_trap_info trap = {0};
>  
> -	csr_write_allowed(CSR_PMPADDR0, (ulong)&trap, PMP_ADDR_MASK);	
> 		\
> +	csr_write_allowed(CSR_PMPADDR0, (ulong)&trap, PMP_ADDR_MASK);
>  	if (!trap.cause) {
>  		val = csr_read_allowed(CSR_PMPADDR0, (ulong)&trap);
>  		if (trap.cause)
> -- 
> 2.25.1
> 
>

diff --git a/lib/sbi/sbi_hart.c b/lib/sbi/sbi_hart.c
index 0b3bb6237182..ee11b2133d05 100644
--- a/lib/sbi/sbi_hart.c
+++ b/lib/sbi/sbi_hart.c
@@ -320,7 +320,7 @@  static unsigned long hart_pmp_get_allowed_addr(void)
 	unsigned long val = 0;
 	struct sbi_trap_info trap = {0};
 
-	csr_write_allowed(CSR_PMPADDR0, (ulong)&trap, PMP_ADDR_MASK);			\
+	csr_write_allowed(CSR_PMPADDR0, (ulong)&trap, PMP_ADDR_MASK);
 	if (!trap.cause) {
 		val = csr_read_allowed(CSR_PMPADDR0, (ulong)&trap);
 		if (trap.cause)

[RFC,03/14] lib: sbi: Remove stray '\' character

Commit Message

Comments

Patch