From patchwork Wed Jan 13 10:06:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1425745 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1231::1; helo=merlin.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=merlin.20170209 header.b=pF+tMb5v; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=mgcp7jLA; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-sharedspace-onmicrosoft-com header.b=M3B2oGaX; dkim-atps=neutral Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DG36L6KCsz9sVs for ; Wed, 13 Jan 2021 21:07:54 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vSOVxWiszM/9hJaPxvAQKRaJhWra3zrPHnQAMzoXEt0=; b=pF+tMb5vDKuHzF2eNlwEaMJR3 Ce6jlbV73gmmF4Ewzn10aJW+uwDafpxf46vjKmvzEQtxGYBNsTXppjgqtOZt0C6dx2oZGH7yvrJwD UUpWEYDzxMN/91Pf3QCEKQC5y6VaxLRjYyhfgP5iejGa9rkiUORUTsBnnEOjyOhIlhWIEMq4z+V/y 9PjyO5XxHBJTYSQe8URftt/2QhndSNWhlyRoQ7De8tZ9xiqZXrYnT82byAQRdTRJ6SpsUvhMQx0er fP7isDYyJKE4Z3T9oUlCZ6+L8GHeQG9DBtFWrEWB5mm8bzTWeEw5qMpZdVp6ByApPo42gT1sUaUBK z6VhYfssA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzd49-00058p-0H; Wed, 13 Jan 2021 10:07:49 +0000 Received: from esa5.hgst.iphmx.com ([216.71.153.144]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzd46-000551-0v for opensbi@lists.infradead.org; Wed, 13 Jan 2021 10:07:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1610532465; x=1642068465; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=98dAPh5gDhMw980FU3jM1XT+msnzSXIpyztuaQ33pD8=; b=mgcp7jLApFqqy57L3M3iGrIZwpai3pVfnqLWzvibGEP+pv1Nk/1CCpUb AlWij2DqMtxwb4+sFxGDPavHsTKOwiRz/LlPrm69szTg+cSowHObeCS+L NE2INvBqxKLzLCy+1O3jtikBZgzKg73umHeipOYNo+i+JCg5RehFM6Jz3 RzcTx2hb+bvA1XZ5BUPgoqL3maEhcyWbOYJd5quJ4HMvUzqomFocYR2fy vU0ywbg6LciYNZfzRQNOqGmUiygnFVRtz4Kl6sbuYVyvYuUgoyylBIih5 hVJlF8TsBM4X86OLottpUQPFoJ6Sp2rndpOTbNTKj27MpGhn38j1GL9bR A==; IronPort-SDR: wvxIrxMDymj5Qn+TITKUmDQS1E21UyOT+mN/hFn2e2IhC2wNnbdqUxe7Fmxo0d4dGo0rQSgMK/ CdL3HOREJbnzswJ38AjtXgxJ0pNTBRKsaMysg34ijfyp9q3xLY8kwR3gEDInAYiG9hYSMiSHYH axxIHC3jmB9WewCg0jvmM4vKu96mud4jZWQ6XYzPlmibhF93V3UNPlaQHZeHqGXMC4R7QlG4He hyXXRoCmpiViD5g82YFBU02IhwvVcuKxbVxYHpgHKKaxFpirmiZMXacr4ONji5auwJ4z7Maeqh kAM= X-IronPort-AV: E=Sophos;i="5.79,344,1602518400"; d="scan'208";a="157320002" Received: from mail-dm6nam12lp2176.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.176]) by ob1.hgst.iphmx.com with ESMTP; 13 Jan 2021 18:07:45 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KSQNo8tozzSxOQRbfHZpNkgP2deNf2r/3qK6eeHM1vGyppbCg7aelTVvZ2yoiN5BDDBfpMl0F85iNr5GOCM8a9ulhQKf92whmV/vZLwXa18cFPAvVPd+Q/I/zfCKdeMa/xe3DxEhEkUq7vAvNZb4vDli1Z+gYrcMYufWn5mFnfDjE9fjkuyV5IPSVOJdh0bKRYxsm76RZknD5/d+k7NSBbDfU9huwfQOJXK1ubEM9tnWKqNStacwb/sfAvDhAKe06Zs3fS92+SIpEzjfrdDSsQ9uhFI5JRkWkw973rhLgW2ydn2azVvOI/LSxVoBKBGIdpR6NMrsRMTolON2wnj9zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZXSKTs/kw3t3GH2Gzr8hhPnvASClqMLqTG3OpcHCfWs=; b=meLL0yCZr1RIr/SuOoK9WuJAP3fO/KHLDbJiUnDA3PESzn81MSAD4X3xq/R9IXqReuA0+qBvk3tX2bsKtDzchR+Rv17dhmq/CPAyOoGbFkFBebErM567biy+5+EukA2D9seJ7wuxgqTVeSOFzfJW+DIjykQQh+lOWXeNN6yqYXAfH0Q+2UlRJtbHPsLeuZ6Vdt5bNWbfgDq2Qw0i9dL5j2pGZOSI7iRc8GfV2n1fSiY7XbpaVpcyqivXzY74cX4SheDTI+8uXDidNcmYCDyBoTc3SxobCn+ku2b7NKdub9lyUYNTv9Ve63Ds3WallGhUlh+CruTahI2eGYPuIe1KnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZXSKTs/kw3t3GH2Gzr8hhPnvASClqMLqTG3OpcHCfWs=; b=M3B2oGaXeq8iasCbWyB61eIjWwUYO8zQm8RvrjbY8z2xaCojSkjRuJH38BfMvAXE3eG9J/k3XyIehxusbiUKult4zjZMYnfjscND0SD8wcz8PvvZv+phj32MnPyUZmjETva14bZzJfbWYNPZFGgJ9xrF3TTHxW65XwbtO8zW14Y= Authentication-Results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; Received: from DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) by DM5PR04MB3770.namprd04.prod.outlook.com (2603:10b6:3:fe::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.11; Wed, 13 Jan 2021 10:07:44 +0000 Received: from DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::2513:b200:bdc8:b97]) by DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::2513:b200:bdc8:b97%5]) with mapi id 15.20.3742.012; Wed, 13 Jan 2021 10:07:44 +0000 From: Anup Patel To: Atish Patra , Alistair Francis Subject: [PATCH 3/3] include: sbi: Don't pack struct sbi_platform and sbi_platform_operations Date: Wed, 13 Jan 2021 15:36:57 +0530 Message-Id: <20210113100657.809754-4-anup.patel@wdc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210113100657.809754-1-anup.patel@wdc.com> References: <20210113100657.809754-1-anup.patel@wdc.com> X-Originating-IP: [122.179.74.246] X-ClientProxiedBy: MAXPR0101CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::13) To DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from wdc.com (122.179.74.246) by MAXPR0101CA0027.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.10 via Frontend Transport; Wed, 13 Jan 2021 10:07:41 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 46a6ba39-f198-4fde-f22a-08d8b7ab120f X-MS-TrafficTypeDiagnostic: DM5PR04MB3770: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: WDCIPOUTBOUND: EOP-TRUE X-MS-Oob-TLC-OOBClassifiers: OLM:1002; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rk/nfT6es8YeoI4gYZpGCEThAGmR7ci70cLUmoYXhBJL1acKcT/HuI9GaUMRphBlvzxVbnLjnnBYCJGKGqqRSfB3Rd6hls0Db9MmocrCq6qBodvi15E01aozMV00ZJl0hMCEep4nFQ+5DgBbGK02CjHEvRrSMhbqS6ufclAEfJUepTqgkOXdpqXzwlkvCxYeTM2Y5fLvMH27yhX0MgEVR0p6hk/P4aKiDdg1tee7brX4TgCWfbMWfO4V1UMeCwtW2Otfbe96lB1WWyN9ohP3w+L4mGacYVZbKU8mLQqHbIfEgl6FNS32yxHdsz5NPHY+KTwVr527bp+GGqUvAWks9fiz0/zEg3dzUUeUZbVl/1yruWkU42bHPkFktIu1Gr1vL7sC2s+iW3J1KSD9kgIYVg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR04MB6201.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(346002)(136003)(366004)(396003)(376002)(8676002)(36756003)(86362001)(6636002)(66476007)(66556008)(8936002)(7696005)(956004)(66946007)(2616005)(44832011)(54906003)(1076003)(316002)(110136005)(5660300002)(52116002)(6666004)(26005)(16526019)(8886007)(186003)(478600001)(2906002)(83380400001)(4326008)(55016002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: pb00j0lsfwACGf1fYf/FkUoUSYMrdh89xs+7+7Nd22VoXsOIP29ChfA8Qf3JHBekvDdiln2GV1FiLqraLo3SrT3mqBdTHbKah7Xw5XsWfBZjTwURRP7rS38LTGTJyJmgROyCLue/s/I+hMPTLdexjv1yBVcZjDwsBr4EKqpEbjrJ8rBBZ5EoEeBlDA1Hc/4uLt/sLjfY5FRLo9I3CAy633pK8V6NjnwVeeJ+WUWcimwxYTyNqeljh4tdVyL1VTxF3T/+ZVGGTyHfwYRDt57VMh79c/36SnrCnZqDblFfc8kn8Ox9MO5SayuUf5JPjkrbbtfFZqC9LcxtCol3HQRln6K4xsQi9efz1eNSrkfKb5OSfrUjLKuHIbwM1AtKZGZKmffZBLIE7x7kVfuHG8ybGYBcoXgTNjgO++ttHaOf075trqR/Y0WO+Sv5Hoyu03HV3lBg2ba1RHZGmqmdsNzkf7wykjnyauIhsInXwpfJZfFaW0M94iKbyqnbSrcvcXb/mMsKxTSVZIM6dvTdd1bdKwZA13+Y+6nYJsQKtZiNR2meeDoJxEo6Re0j+u5DHqPxCDlEZhEXt0vHzhqRtDPOk2KVwnQ+mgAeCoPNKqSvq9zcY0gei9NCuLL3BhUFRJKdf4Mh61DEz5KrFZThhmBBjhhqJsod5uraPs0bx3B+93zu0EH/9AT+90aVn84Rf6xzMW9nR9zcW2qhPEjef9uXDJN0ME+ZYtnyEIVddGp8+j4kdI5ZcFYhPLYw2oOgHIY+k/ePOCrfDx1Eq9mya2LhuZT9Mq+KWRnoj+bIXfJpdb2EIoZTtjGV/GLg+QUd9BSlxjzbrPc5sSOW73+DQehG+zVjzC2RzBfK2NOFrGLDvY/X9I5QKFH4wvmosxMBZIIbm89Z8OEaX3lllVcdOHOYesVXdL3LJzZKHVUZ+w5jQwQ00yfHvr2Xw1yPeVHtkid0njPMzD/BWHx98eh0pH1tSQKnPcdL1SsEAWDKEUvGsEoONwW7BNw32I/cGfN1QHrJ X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6201.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2021 10:07:44.2471 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-Network-Message-Id: 46a6ba39-f198-4fde-f22a-08d8b7ab120f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rmBTOkX1c3EF2+NR1RnaSZPetJvV/v7yW2ngfkYHsvVcuH3p6pt5epYRy6AIxNTSSFmgDuRYd6ZkU4oSyc7c7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB3770 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210113_050746_341229_91D759DF X-CRM114-Status: GOOD ( 14.78 ) X-Spam-Score: -0.9 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [216.71.153.144 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anup Patel , Anup Patel , Paul Campbell , opensbi@lists.infradead.org Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org We don't need to pack struct sbi_platform and sbi_platform_operations because GCC ensures member offsets match member data type irrespective to the target system (RV32 or RV64). This also allows GCC to generate more optimized instruction sequence when accessing members of struct sbi_platform and struct sbi_platform_operations. Reported-by: Paul Campbell Signed-off-by: Anup Patel Reviewed-by: Alistair Francis --- include/sbi/sbi_platform.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/sbi/sbi_platform.h b/include/sbi/sbi_platform.h index c252628..cc7e3ff 100644 --- a/include/sbi/sbi_platform.h +++ b/include/sbi/sbi_platform.h @@ -152,7 +152,7 @@ struct sbi_platform_operations { const struct sbi_trap_regs *regs, unsigned long *out_value, struct sbi_trap_info *out_trap); -} __packed; +}; /** Platform default per-HART stack size for exception/interrupt handling */ #define SBI_PLATFORM_DEFAULT_HART_STACK_SIZE 8192 @@ -199,7 +199,7 @@ struct sbi_platform { * 2. HART id < SBI_HARTMASK_MAX_BITS */ const u32 *hart_index2id; -} __packed; +}; /** Get pointer to sbi_platform for sbi_scratch pointer */ #define sbi_platform_ptr(__s) \