diff mbox

[MERGED] libosmocore[master]: gsm48: move to hex TMSI representation

Message ID 20160520162652.958A66D4B@lists.osmocom.org
State New
Headers show

Commit Message

gerrit-no-reply@lists.osmocom.org May 20, 2016, 4:26 p.m. UTC 
Holger Freyther has submitted this change and it was merged.

Change subject: gsm48: move to hex TMSI representation
......................................................................


gsm48: move to hex TMSI representation

Previously, we traditionally displayed a TMSI in its integer
representation, which is quite unusual in the telecom world.
A TMSI is normally printed as a series of 8 hex digits.

Review at https://gerrit.osmocom.org/57/
Change-Id: Ifd25365bfa3b4ee95b16979740c3229948ce17f2
Reviewed-on: https://gerrit.osmocom.org/57
Tested-by: Jenkins Builder
Reviewed-by: Harald Welte <laforge@gnumonks.org>
Reviewed-by: Holger Freyther <holger@freyther.de>
---
M src/gsm/gsm48.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, but someone else must approve
  Jenkins Builder: Verified
  Holger Freyther: Looks good to me, approved
diff mbox

Patch

diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c
index 8a46f76..d0e050b 100644
--- a/src/gsm/gsm48.c
+++ b/src/gsm/gsm48.c
@@ -458,11 +458,10 @@ 
 	case GSM_MI_TYPE_NONE:
 		break;
 	case GSM_MI_TYPE_TMSI:
-		/* Table 10.5.4.3, reverse generate_mid_from_tmsi */
 		if (mi_len == GSM48_TMSI_LEN && mi[0] == (0xf0 | GSM_MI_TYPE_TMSI)) {
 			memcpy(&tmsi, &mi[1], 4);
 			tmsi = ntohl(tmsi);
-			return snprintf(string, str_len, "%u", tmsi);
+			return snprintf(string, str_len, "0x%08X", tmsi);
 		}
 		break;
 	case GSM_MI_TYPE_IMSI: