diff mbox

[10/16] Add missing UARTs to Firestone DT

Message ID 822637739.194632.1473971801609.JavaMail.zimbra@raptorengineeringinc.com
State Superseded, archived
Headers show

Commit Message

Timothy Pearson Sept. 15, 2016, 8:36 p.m. UTC 
---
 arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts |   10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Joel Stanley Sept. 16, 2016, 1:39 a.m. UTC | #1 
On Fri, Sep 16, 2016 at 6:06 AM, Timothy Pearson
<tpearson@raptorengineering.com> wrote:

Missing your s-o-b.

Please add a comment as to why you're enabling them - I assume that
these are the physical ports on the back of the chassis?

>
> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts |   10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> index 82df794..c6e81f4 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> @@ -9,6 +9,8 @@
>         compatible = "ibm,firestone-bmc", "aspeed,ast2400";
>
>         aliases {
> +               serial1 = &uart1;
> +               serial2 = &uart2;
>                 serial4 = &uart5;
>         };
>
> @@ -73,6 +75,14 @@
>         no-hw-checksum;
>  };
>
> +&uart1 {
> +       status = "okay";
> +};
> +
> +&uart2 {
> +       status = "okay";
> +};
> +
>  &uart5 {
>         status = "okay";
>  };
> --
> 1.7.9.5
>
> _______________________________________________
> openbmc mailing list
> openbmc@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc
diff mbox

Patch

diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
index 82df794..c6e81f4 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
@@ -9,6 +9,8 @@ 
 	compatible = "ibm,firestone-bmc", "aspeed,ast2400";
 
 	aliases {
+		serial1 = &uart1;
+		serial2 = &uart2;
 		serial4 = &uart5;
 	};
 
@@ -73,6 +75,14 @@ 
 	no-hw-checksum;
 };
 
+&uart1 {
+	status = "okay";
+};
+
+&uart2 {
+	status = "okay";
+};
+
 &uart5 {
 	status = "okay";
 };