diff mbox

[05/16] arm/dts: Remove mac hardware checksum from Firestone

Message ID 712861897.194624.1473971675913.JavaMail.zimbra@raptorengineeringinc.com
State Superseded, archived
Headers show

Commit Message

Timothy Pearson Sept. 15, 2016, 8:34 p.m. UTC
BMC Board

Hardware checksumming doesn't work.

Without this patch pings work but more complex network interactions like SSH
fail.

Signed-off-by: Cyril Bur <cyrilbur@gmail.com>
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts |    2 ++
 1 file changed, 2 insertions(+)

Comments

Andrew Jeffery Sept. 16, 2016, 1:03 a.m. UTC | #1
On Thu, 2016-09-15 at 15:34 -0500, Timothy Pearson wrote:
>  BMC Board

A couple of nits:

Some of your subjects appear to exceed the recommended max width and
are wrapping into the body. Ideally these should be shortened to around
50 characters (recommended by `git help commit`).

> 
> Hardware checksumming doesn't work.

Perhaps the subject should say 'Disable' rather than 'Remove'; it feels
odd seeing an addition in the patch when the subject claims remove :)

Anyhow,

Acked-by: Andrew Jeffery <andrew@aj.id.au>

> 
> Without this patch pings work but more complex network interactions like SSH
> fail.
> 
> Signed-off-by: Cyril Bur <cyrilbur@gmail.com>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> index 2ec9e44..ae1a633 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> @@ -51,6 +51,8 @@
>  
>  &mac0 {
>  	status = "okay";
> +
> +	no-hw-checksum;
>  };
>  
>  &i2c0 {
diff mbox

Patch

diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
index 2ec9e44..ae1a633 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
@@ -51,6 +51,8 @@ 
 
 &mac0 {
 	status = "okay";
+
+	no-hw-checksum;
 };
 
 &i2c0 {