| Message ID | 20231219080021.2048889-2-kcfeng0@nuvoton.com |
|---|---|
| State | New |
| Headers | show |
| Series | hwmon: Driver for Nuvoton NCT7363Y | expand |
Hi Rob, On Tue, Dec 19, 2023 at 5:22 PM Rob Herring <robh@kernel.org> wrote: > > > On Tue, 19 Dec 2023 16:00:20 +0800, baneric926@gmail.com wrote: > > From: Ban Feng <kcfeng0@nuvoton.com> > > > > Adding bindings for the Nuvoton NCT7363Y Fan Controller > > > > Signed-off-by: Ban Feng <kcfeng0@nuvoton.com> > > --- > > .../bindings/hwmon/nuvoton,nct7363.yaml | 62 +++++++++++++++++++ > > MAINTAINERS | 6 ++ > > 2 files changed, 68 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): Our design is based on [1], and adds fan-common.yaml to Documentation/devicetree/bindings/hwmon/, I didn't see any errors when executing dt_binding_check. This design is suggested by reviewer, and [1] is still reviewing: [1]: https://patchwork.kernel.org/project/linux-hwmon/patch/20231107105025.1480561-2-billy_tsai@aspeedtech.com/ How to modify our patch to achieve referencing patch not merged yet? > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml: > Error in referenced schema matching $id: http://devicetree.org/schemas/hwmon/fan-common.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.example.dtb: hwmon@22: fan-0: False schema does not allow {'pwms': [[1, 0, 50000]], 'tach-ch': ['']} > from schema $id: http://devicetree.org/schemas/hwmon/nuvoton,nct7363.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.example.dtb: hwmon@22: fan-1: False schema does not allow {'pwms': [[1, 1, 50000]], 'tach-ch': b'\x01'} > from schema $id: http://devicetree.org/schemas/hwmon/nuvoton,nct7363.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.example.dtb: fan-1: tach-ch: b'\x01' is not of type 'object', 'array', 'boolean', 'null' > from schema $id: http://devicetree.org/schemas/dt-core.yaml# > > doc reference errors (make refcheckdocs): > Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/hwmon/nuvoton,nct736x.yaml > MAINTAINERS: Documentation/devicetree/bindings/hwmon/nuvoton,nct736x.yaml I will modify this typo in v3. Thanks, Ban > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231219080021.2048889-2-kcfeng0@nuvoton.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. >
Hi Krzysztof, On Thu, Dec 21, 2023 at 4:20 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 21/12/2023 01:44, Ban Feng wrote: > > Hi Rob, > > > > On Tue, Dec 19, 2023 at 5:22 PM Rob Herring <robh@kernel.org> wrote: > >> > >> > >> On Tue, 19 Dec 2023 16:00:20 +0800, baneric926@gmail.com wrote: > >>> From: Ban Feng <kcfeng0@nuvoton.com> > >>> > >>> Adding bindings for the Nuvoton NCT7363Y Fan Controller > >>> > >>> Signed-off-by: Ban Feng <kcfeng0@nuvoton.com> > >>> --- > >>> .../bindings/hwmon/nuvoton,nct7363.yaml | 62 +++++++++++++++++++ > >>> MAINTAINERS | 6 ++ > >>> 2 files changed, 68 insertions(+) > >>> create mode 100644 Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml > >>> > >> > >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > >> on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > Our design is based on [1], and adds fan-common.yaml to > > Nothing in the patch or cover letter described the dependency. > ok, in v3, I'll attach a relevant patch and describe it in the cover letter. Thanks, Ban
Hi,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.7-rc6 next-20231219]
[cannot apply to groeck-staging/hwmon-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/baneric926-gmail-com/dt-bindings-hwmon-Add-NCT7363Y-documentation/20231219-160534
base: linus/master
patch link: https://lore.kernel.org/r/20231219080021.2048889-2-kcfeng0%40nuvoton.com
patch subject: [PATCH v2 1/2] dt-bindings: hwmon: Add NCT7363Y documentation
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231220/202312200129.7EYVeOyc-lkp@intel.com/reproduce)
dtcheck warnings: (new ones prefixed by >>)
>> Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml:
Error in referenced schema matching $id: http://devicetree.org/schemas/hwmon/fan-common.yaml
diff --git a/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml b/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml new file mode 100644 index 000000000000..8928e0757f24 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml @@ -0,0 +1,62 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- + +$id: http://devicetree.org/schemas/hwmon/nuvoton,nct7363.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Nuvoton NCT7363Y Hardware Monitoring IC + +maintainers: + - Ban Feng <kcfeng0@nuvoton.com> + +description: | + The NCT7363Y is a Fan controller which provides up to 16 independent + FAN input monitors, and up to 16 independent PWM output with SMBus interface. + +properties: + compatible: + enum: + - nuvoton,nct7363 + + reg: + maxItems: 1 + + "#pwm-cells": + const: 2 + +patternProperties: + "^fan-[0-9]+$": + $ref: fan-common.yaml# + required: + - pwms + - tach-ch + +required: + - compatible + - reg + - "#pwm-cells" + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + hwmon: hwmon@22 { + compatible = "nuvoton,nct7363"; + reg = <0x22>; + #pwm-cells = <2>; + + fan-0 { + pwms = <&hwmon 0 50000>; + tach-ch = /bits/ 8 <0x00>; + }; + fan-1 { + pwms = <&hwmon 1 50000>; + tach-ch = /bits/ 8 <0x01>; + }; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 9104430e148e..c4081a45445e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14838,6 +14838,12 @@ S: Maintained F: Documentation/devicetree/bindings/hwmon/nuvoton,nct6775.yaml F: drivers/hwmon/nct6775-i2c.c +NCT736X HARDWARE MONITOR DRIVER +M: Ban Feng <kcfeng0@nuvoton.com> +L: linux-hwmon@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/hwmon/nuvoton,nct736x.yaml + NETDEVSIM M: Jakub Kicinski <kuba@kernel.org> S: Maintained