| Message ID | 20220414210045.26480-1-zev@bewilderbeest.net |
|---|---|
| State | New |
| Headers | show |
| Series | [u-boot,v2019.04-aspeed-openbmc] ARM: dts: aspeed: add Delta AHE-50DC BMC | expand |
On Thu, Apr 14, 2022 at 02:00:45PM PDT, Zev Weiss wrote: > The Delta AHE-50DC Open19 power shelf uses a pair of AST1250 BMCs that > are mostly compatible with the existing ast2400-evb device tree, with > a couple small tweaks for the serial console UART and ethernet MACs. > > Signed-off-by: Zev Weiss <zev@bewilderbeest.net> > --- > arch/arm/dts/Makefile | 1 + > arch/arm/dts/ast2400-ahe-50dc.dts | 34 +++++++++++++++++++++++++++++++ > 2 files changed, 35 insertions(+) > create mode 100644 arch/arm/dts/ast2400-ahe-50dc.dts > Ping...does this look like a reasonable approach for a board that's mostly-but-not-entirely EVB-compatible? Once the regulator/extcon driver question gets sorted out I'll post a kernel dts, after which I think the necessary pieces will be in place to add an OpenBMC meta-layer for this system. This patch is also still outstanding as a semi-dependency (not strictly necessary for this, but nice to have for it): https://lore.kernel.org/openbmc/20220414205950.26406-1-zev@bewilderbeest.net/ Thanks, Zev
On Wed, 11 May 2022 at 03:37, Zev Weiss <zev@bewilderbeest.net> wrote: > > On Thu, Apr 14, 2022 at 02:00:45PM PDT, Zev Weiss wrote: > > The Delta AHE-50DC Open19 power shelf uses a pair of AST1250 BMCs that > > are mostly compatible with the existing ast2400-evb device tree, with > > a couple small tweaks for the serial console UART and ethernet MACs. > > > > Signed-off-by: Zev Weiss <zev@bewilderbeest.net> > > --- > > arch/arm/dts/Makefile | 1 + > > arch/arm/dts/ast2400-ahe-50dc.dts | 34 +++++++++++++++++++++++++++++++ > > 2 files changed, 35 insertions(+) > > create mode 100644 arch/arm/dts/ast2400-ahe-50dc.dts > > > > Ping...does this look like a reasonable approach for a board that's > mostly-but-not-entirely EVB-compatible? That looks okay. Are you sure you have everything that the evb enables on your board? Dual flashes on both flash controllers, etc? I wonder if it would be better to put more into ast2400-u-boot.dtsi and use that? But I don't have strong opinions either way. Your device tree looks fine, and I am happy to merge it. > Once the regulator/extcon > driver question gets sorted out I'll post a kernel dts, after which I > think the necessary pieces will be in place to add an OpenBMC meta-layer > for this system. > > This patch is also still outstanding as a semi-dependency (not strictly > necessary for this, but nice to have for it): > https://lore.kernel.org/openbmc/20220414205950.26406-1-zev@bewilderbeest.net/ > > > Thanks, > Zev >
On Tue, May 10, 2022 at 11:04:01PM PDT, Joel Stanley wrote: >On Wed, 11 May 2022 at 03:37, Zev Weiss <zev@bewilderbeest.net> wrote: >> >> On Thu, Apr 14, 2022 at 02:00:45PM PDT, Zev Weiss wrote: >> > The Delta AHE-50DC Open19 power shelf uses a pair of AST1250 BMCs that >> > are mostly compatible with the existing ast2400-evb device tree, with >> > a couple small tweaks for the serial console UART and ethernet MACs. >> > >> > Signed-off-by: Zev Weiss <zev@bewilderbeest.net> >> > --- >> > arch/arm/dts/Makefile | 1 + >> > arch/arm/dts/ast2400-ahe-50dc.dts | 34 +++++++++++++++++++++++++++++++ >> > 2 files changed, 35 insertions(+) >> > create mode 100644 arch/arm/dts/ast2400-ahe-50dc.dts >> > >> >> Ping...does this look like a reasonable approach for a board that's >> mostly-but-not-entirely EVB-compatible? > >That looks okay. Are you sure you have everything that the evb enables >on your board? Dual flashes on both flash controllers, etc? > Ah, good point -- while it does have dual flashes on the fmc, I should probably disable spi1. >I wonder if it would be better to put more into ast2400-u-boot.dtsi >and use that? > >But I don't have strong opinions either way. Your device tree looks >fine, and I am happy to merge it. > Hmm, hadn't considered that possibility...I'm likewise not strongly opinionated, but I guess the current approach of extending the evb dts seems slightly simpler? Thanks for the review -- I'll send a v2 with spi1 disabled soon. Zev
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index e5a73697c574..257bbd6d3b07 100755 --- a/arch/arm/dts/Makefile +++ b/arch/arm/dts/Makefile @@ -676,6 +676,7 @@ dtb-$(CONFIG_ARCH_BCM6858) += \ dtb-$(CONFIG_ARCH_ASPEED) += \ ast2400-evb.dtb \ + ast2400-ahe-50dc.dtb \ ast2500-evb.dtb \ ast2600a0-evb.dtb \ ast2600a1-evb.dtb \ diff --git a/arch/arm/dts/ast2400-ahe-50dc.dts b/arch/arm/dts/ast2400-ahe-50dc.dts new file mode 100644 index 000000000000..6735af90b106 --- /dev/null +++ b/arch/arm/dts/ast2400-ahe-50dc.dts @@ -0,0 +1,34 @@ +/dts-v1/; + +#include "ast2400-evb.dts" + +/ { + model = "Delta AHE-50DC BMC"; + compatible = "delta,ahe-50dc-bmc", "aspeed,ast2400-evb", "aspeed,ast2400"; + + chosen { + stdout-path = &uart3; + }; +}; + +&uart5 { + status = "disabled"; +}; + +&uart3 { + u-boot,dm-pre-reloc; + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_txd3_default &pinctrl_rxd3_default>; +}; + +&mac0 { + status = "disabled"; +}; + +&mac1 { + status = "okay"; + phy-mode = "rgmii"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rgmii2_default &pinctrl_mdio2_default>; +};
The Delta AHE-50DC Open19 power shelf uses a pair of AST1250 BMCs that are mostly compatible with the existing ast2400-evb device tree, with a couple small tweaks for the serial console UART and ethernet MACs. Signed-off-by: Zev Weiss <zev@bewilderbeest.net> --- arch/arm/dts/Makefile | 1 + arch/arm/dts/ast2400-ahe-50dc.dts | 34 +++++++++++++++++++++++++++++++ 2 files changed, 35 insertions(+) create mode 100644 arch/arm/dts/ast2400-ahe-50dc.dts