| Message ID | 20220220035321.3870-3-warp5tw@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | i2c: npcm: Bug fixes timeout, spurious interrupts | expand |
On Sun, 20 Feb 2022 11:53:12 +0800, Tyrone Ting wrote: > From: Tyrone Ting <kfting@nuvoton.com> > > Add compatible and nuvoton,sys-mgr description for NPCM i2c module. > > Signed-off-by: Tyrone Ting <kfting@nuvoton.com> > Signed-off-by: Tali Perry <tali.perry1@gmail.com> > --- > .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml:19:6: [warning] wrong indentation: expected 4 but found 5 (indentation) ./Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml:20:7: [warning] wrong indentation: expected 7 but found 6 (indentation) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1595125 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Hi Rob: Thank you for your comments and they will be addressed. Rob Herring <robh@kernel.org> 於 2022年2月21日 週一 上午10:36寫道： > > On Sun, 20 Feb 2022 11:53:12 +0800, Tyrone Ting wrote: > > From: Tyrone Ting <kfting@nuvoton.com> > > > > Add compatible and nuvoton,sys-mgr description for NPCM i2c module. > > > > Signed-off-by: Tyrone Ting <kfting@nuvoton.com> > > Signed-off-by: Tali Perry <tali.perry1@gmail.com> > > --- > > .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 17 ++++++++++++----- > > 1 file changed, 12 insertions(+), 5 deletions(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml:19:6: [warning] wrong indentation: expected 4 but found 5 (indentation) > ./Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml:20:7: [warning] wrong indentation: expected 7 but found 6 (indentation) > > dtschema/dtc warnings/errors: > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/1595125 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. > Best regards, Tyrone
On Sun, Feb 20, 2022 at 11:53:12AM +0800, Tyrone Ting wrote: > From: Tyrone Ting <kfting@nuvoton.com> > > Add compatible and nuvoton,sys-mgr description for NPCM i2c module. > > Signed-off-by: Tyrone Ting <kfting@nuvoton.com> > Signed-off-by: Tali Perry <tali.perry1@gmail.com> > --- > .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml > index 128444942aec..809c51ac32fe 100644 > --- a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml > @@ -7,17 +7,18 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# > title: nuvoton NPCM7XX I2C Controller Device Tree Bindings > > description: | > - The NPCM750x includes sixteen I2C bus controllers. All Controllers support > - both master and slave mode. Each controller can switch between master and slave > - at run time (i.e. IPMB mode). Each controller has two 16 byte HW FIFO for TX and > - RX. > + I2C bus controllers of the NPCM series support both master and > + slave mode. Each controller can switch between master and slave at run time > + (i.e. IPMB mode). HW FIFO for TX and RX are supported. > > maintainers: > - Tali Perry <tali.perry1@gmail.com> > > properties: > compatible: > - const: nuvoton,npcm750-i2c > + enum: > + - nuvoton,npcm750-i2c > + - nuvoton,npcm845-i2c > > reg: > maxItems: 1 > @@ -36,11 +37,16 @@ properties: > default: 100000 > enum: [100000, 400000, 1000000] > > + nuvoton,sys-mgr: > + $ref: "/schemas/types.yaml#/definitions/phandle" > + description: The phandle of system manager register node. > + > required: > - compatible > - reg > - interrupts > - clocks > + - nuvoton,sys-mgr You can't make nuvoton,sys-mgr required for existing users. You can add an if/then schema for nuvoton,npcm845-i2c if you want to make it required in that case. Rob
Hi Rob: Thank you for your comment and it'll be addressed. Rob Herring <robh@kernel.org> 於 2022年2月23日 週三 上午1:56寫道： > > On Sun, Feb 20, 2022 at 11:53:12AM +0800, Tyrone Ting wrote: > > From: Tyrone Ting <kfting@nuvoton.com> > > > > Add compatible and nuvoton,sys-mgr description for NPCM i2c module. > > > > Signed-off-by: Tyrone Ting <kfting@nuvoton.com> > > Signed-off-by: Tali Perry <tali.perry1@gmail.com> > > --- > > .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 17 ++++++++++++----- > > 1 file changed, 12 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml > > index 128444942aec..809c51ac32fe 100644 > > --- a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml > > +++ b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml > > @@ -7,17 +7,18 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# > > title: nuvoton NPCM7XX I2C Controller Device Tree Bindings > > > > description: | > > - The NPCM750x includes sixteen I2C bus controllers. All Controllers support > > - both master and slave mode. Each controller can switch between master and slave > > - at run time (i.e. IPMB mode). Each controller has two 16 byte HW FIFO for TX and > > - RX. > > + I2C bus controllers of the NPCM series support both master and > > + slave mode. Each controller can switch between master and slave at run time > > + (i.e. IPMB mode). HW FIFO for TX and RX are supported. > > > > maintainers: > > - Tali Perry <tali.perry1@gmail.com> > > > > properties: > > compatible: > > - const: nuvoton,npcm750-i2c > > + enum: > > + - nuvoton,npcm750-i2c > > + - nuvoton,npcm845-i2c > > > > reg: > > maxItems: 1 > > @@ -36,11 +37,16 @@ properties: > > default: 100000 > > enum: [100000, 400000, 1000000] > > > > + nuvoton,sys-mgr: > > + $ref: "/schemas/types.yaml#/definitions/phandle" > > + description: The phandle of system manager register node. > > + > > required: > > - compatible > > - reg > > - interrupts > > - clocks > > + - nuvoton,sys-mgr > > You can't make nuvoton,sys-mgr required for existing users. You can add > an if/then schema for nuvoton,npcm845-i2c if you want to make it > required in that case. > > Rob Best regards, Tyrone
diff --git a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml index 128444942aec..809c51ac32fe 100644 --- a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml +++ b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml @@ -7,17 +7,18 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# title: nuvoton NPCM7XX I2C Controller Device Tree Bindings description: | - The NPCM750x includes sixteen I2C bus controllers. All Controllers support - both master and slave mode. Each controller can switch between master and slave - at run time (i.e. IPMB mode). Each controller has two 16 byte HW FIFO for TX and - RX. + I2C bus controllers of the NPCM series support both master and + slave mode. Each controller can switch between master and slave at run time + (i.e. IPMB mode). HW FIFO for TX and RX are supported. maintainers: - Tali Perry <tali.perry1@gmail.com> properties: compatible: - const: nuvoton,npcm750-i2c + enum: + - nuvoton,npcm750-i2c + - nuvoton,npcm845-i2c reg: maxItems: 1 @@ -36,11 +37,16 @@ properties: default: 100000 enum: [100000, 400000, 1000000] + nuvoton,sys-mgr: + $ref: "/schemas/types.yaml#/definitions/phandle" + description: The phandle of system manager register node. + required: - compatible - reg - interrupts - clocks + - nuvoton,sys-mgr allOf: - $ref: /schemas/i2c/i2c-controller.yaml# @@ -57,6 +63,7 @@ examples: clock-frequency = <100000>; interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>; compatible = "nuvoton,npcm750-i2c"; + nuvoton,sys-mgr = <&gcr>; }; ...