| Message ID | 20210127070054.81719-6-joel@jms.id.au |
|---|---|
| State | New |
| Headers | show |
| Series | FIT verification | expand |
On 1/27/2021 4:00 AM, Joel Stanley wrote: > This feature consumes 3656 bytes. Without it systems will need to load a > new SPL over the UART with the AST2600's recovery feature if they flash > a bad u-boot proper. No objections here. Just a bit confusing since that in the introductory letter you mention we *could* leave that enabled. So if that's not necessary, why bundle that with this patchset (and not separate)? > Signed-off-by: Joel Stanley <joel@jms.id.au> > --- > configs/ast2600_openbmc_spl_emmc_defconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/configs/ast2600_openbmc_spl_emmc_defconfig b/configs/ast2600_openbmc_spl_emmc_defconfig > index 3f2de64e077d..c55a70c5c1c9 100644 > --- a/configs/ast2600_openbmc_spl_emmc_defconfig > +++ b/configs/ast2600_openbmc_spl_emmc_defconfig > @@ -55,7 +55,6 @@ CONFIG_SPL_DM_RESET=y > CONFIG_SPL_RAM_SUPPORT=y > CONFIG_SPL_RAM_DEVICE=y > CONFIG_SPL_WATCHDOG_SUPPORT=y > -CONFIG_SPL_YMODEM_SUPPORT=y > CONFIG_HUSH_PARSER=y > # CONFIG_AUTO_COMPLETE is not set > CONFIG_SYS_PROMPT="ast# " Reviewed-by: Klaus Heinrich Kiwi <klaus@linux.vnet.ibm.com>
On Wed, 27 Jan 2021, at 17:30, Joel Stanley wrote: > This feature consumes 3656 bytes. Without it systems will need to load a > new SPL over the UART with the AST2600's recovery feature if they flash > a bad u-boot proper. > > Signed-off-by: Joel Stanley <joel@jms.id.au> As mentioned in my reply to the cover letter, I think we should drop this one. Andrew
diff --git a/configs/ast2600_openbmc_spl_emmc_defconfig b/configs/ast2600_openbmc_spl_emmc_defconfig index 3f2de64e077d..c55a70c5c1c9 100644 --- a/configs/ast2600_openbmc_spl_emmc_defconfig +++ b/configs/ast2600_openbmc_spl_emmc_defconfig @@ -55,7 +55,6 @@ CONFIG_SPL_DM_RESET=y CONFIG_SPL_RAM_SUPPORT=y CONFIG_SPL_RAM_DEVICE=y CONFIG_SPL_WATCHDOG_SUPPORT=y -CONFIG_SPL_YMODEM_SUPPORT=y CONFIG_HUSH_PARSER=y # CONFIG_AUTO_COMPLETE is not set CONFIG_SYS_PROMPT="ast# "
This feature consumes 3656 bytes. Without it systems will need to load a new SPL over the UART with the AST2600's recovery feature if they flash a bad u-boot proper. Signed-off-by: Joel Stanley <joel@jms.id.au> --- configs/ast2600_openbmc_spl_emmc_defconfig | 1 - 1 file changed, 1 deletion(-)