diff mbox

[linux,dev-4.7,2/3] arm: dts: aspeed: Add spi1 pins to g5 device tree

Message ID 20160915111308.31481-2-joel@jms.id.au
State Superseded, archived
Headers show

Commit Message

Joel Stanley Sept. 15, 2016, 11:13 a.m. UTC 
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 arch/arm/boot/dts/aspeed-g5.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Andrew Jeffery Sept. 16, 2016, 12:31 a.m. UTC | #1 
On Thu, 2016-09-15 at 20:43 +0930, Joel Stanley wrote:
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
>  arch/arm/boot/dts/aspeed-g5.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index f73a2b18e152..e4e43ae3616a 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -201,6 +201,17 @@
>  						function = "RMII2";
>  						groups = "RMII2";
>  					};
> +
> +					pinctrl_spi1_master_default: spi1_master_default {
> +						function = "SPI1_MASTER";
> +						groups = "SPI1_MASTER";
> +					};
> +
> +					pinctrl_spi1_passthru_default: spi1_passthru_default {
> +						function = "SPI1_PASSTHRU";
> +						groups = "SPI1_PASSTHRU";
> +					};
> +

This looks fine, however I think we should add VGABIOS_ROM and SYSSPI
given you went to the effort of defining them in the driver.

Cheers,

Andrew

>  				};
>  			};
>
diff mbox

Patch

diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
index f73a2b18e152..e4e43ae3616a 100644
--- a/arch/arm/boot/dts/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed-g5.dtsi
@@ -201,6 +201,17 @@ 
 						function = "RMII2";
 						groups = "RMII2";
 					};
+
+					pinctrl_spi1_master_default: spi1_master_default {
+						function = "SPI1_MASTER";
+						groups = "SPI1_MASTER";
+					};
+
+					pinctrl_spi1_passthru_default: spi1_passthru_default {
+						function = "SPI1_PASSTHRU";
+						groups = "SPI1_PASSTHRU";
+					};
+
 				};
 			};