| Message ID | 1473921146-19509-7-git-send-email-clg@kaod.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Thu, Sep 15, 2016 at 4:02 PM, Cédric Le Goater <clg@kaod.org> wrote: > Signed-off-by: Cédric Le Goater <clg@kaod.org> > --- > arch/arm/boot/dts/aspeed-g4.dtsi | 6 ++++++ > arch/arm/boot/dts/aspeed-g5.dtsi | 6 ++++++ > 2 files changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi > index eb0122fa34c2..4480b858103e 100644 > --- a/arch/arm/boot/dts/aspeed-g4.dtsi > +++ b/arch/arm/boot/dts/aspeed-g4.dtsi > @@ -391,6 +391,12 @@ > clocks = <&clk_apb>; > }; > > + ibt: ibt@1e789140 { Given this is part of the LPC register set, and we need to expose other parts of the LPC, I was wondering if we wanted to make this a sub-node of a mfd device that covered all of the LPC controller's registers. What do you think? > + compatible = "aspeed,bt-bmc"; When getting bindings reviewed I've been told we should have something soc specific in the string, like aspeed,ast2400-bt-bmc. I'm to too fussed though. > + reg = <0x1e789140 0x18>; > + interrupts = <8>; > + }; > + > wdt1: wdt@1e785000 { > compatible = "aspeed,ast2400-wdt"; > reg = <0x1e785000 0x1c>; > diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi > index 79abac876abf..7c781fb613f8 100644 > --- a/arch/arm/boot/dts/aspeed-g5.dtsi > +++ b/arch/arm/boot/dts/aspeed-g5.dtsi > @@ -255,6 +255,12 @@ > clocks = <&clk_apb>; > }; > > + ibt: ibt@1e789140 { > + compatible = "aspeed,bt-bmc"; > + reg = <0x1e789140 0x18>; > + interrupts = <8>; > + }; > + > wdt1: wdt@1e785000 { > compatible = "aspeed,ast2500-wdt"; > reg = <0x1e785000 0x1c>; > -- > 2.7.4 >
On 09/15/2016 09:11 AM, Joel Stanley wrote: > On Thu, Sep 15, 2016 at 4:02 PM, Cédric Le Goater <clg@kaod.org> wrote: >> Signed-off-by: Cédric Le Goater <clg@kaod.org> >> --- >> arch/arm/boot/dts/aspeed-g4.dtsi | 6 ++++++ >> arch/arm/boot/dts/aspeed-g5.dtsi | 6 ++++++ >> 2 files changed, 12 insertions(+) >> >> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi >> index eb0122fa34c2..4480b858103e 100644 >> --- a/arch/arm/boot/dts/aspeed-g4.dtsi >> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi >> @@ -391,6 +391,12 @@ >> clocks = <&clk_apb>; >> }; >> >> + ibt: ibt@1e789140 { > > Given this is part of the LPC register set, and we need to expose > other parts of the LPC, I was wondering if we wanted to make this a > sub-node of a mfd device that covered all of the LPC controller's > registers. What do you think? It will be cleaner. We don't have to put all of it right now. >> + compatible = "aspeed,bt-bmc"; > > When getting bindings reviewed I've been told we should have something > soc specific in the string, like aspeed,ast2400-bt-bmc. I'm to too > fussed though. yes, this is frequent, something like : compatible = "aspeed,bt-bmc", "aspeed,ast2400-bt-bmc"; Thanks, C. >> + reg = <0x1e789140 0x18>; >> + interrupts = <8>; >> + }; >> + >> wdt1: wdt@1e785000 { >> compatible = "aspeed,ast2400-wdt"; >> reg = <0x1e785000 0x1c>; >> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi >> index 79abac876abf..7c781fb613f8 100644 >> --- a/arch/arm/boot/dts/aspeed-g5.dtsi >> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi >> @@ -255,6 +255,12 @@ >> clocks = <&clk_apb>; >> }; >> >> + ibt: ibt@1e789140 { >> + compatible = "aspeed,bt-bmc"; >> + reg = <0x1e789140 0x18>; >> + interrupts = <8>; >> + }; >> + >> wdt1: wdt@1e785000 { >> compatible = "aspeed,ast2500-wdt"; >> reg = <0x1e785000 0x1c>; >> -- >> 2.7.4 >>
diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi index eb0122fa34c2..4480b858103e 100644 --- a/arch/arm/boot/dts/aspeed-g4.dtsi +++ b/arch/arm/boot/dts/aspeed-g4.dtsi @@ -391,6 +391,12 @@ clocks = <&clk_apb>; }; + ibt: ibt@1e789140 { + compatible = "aspeed,bt-bmc"; + reg = <0x1e789140 0x18>; + interrupts = <8>; + }; + wdt1: wdt@1e785000 { compatible = "aspeed,ast2400-wdt"; reg = <0x1e785000 0x1c>; diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi index 79abac876abf..7c781fb613f8 100644 --- a/arch/arm/boot/dts/aspeed-g5.dtsi +++ b/arch/arm/boot/dts/aspeed-g5.dtsi @@ -255,6 +255,12 @@ clocks = <&clk_apb>; }; + ibt: ibt@1e789140 { + compatible = "aspeed,bt-bmc"; + reg = <0x1e789140 0x18>; + interrupts = <8>; + }; + wdt1: wdt@1e785000 { compatible = "aspeed,ast2500-wdt"; reg = <0x1e785000 0x1c>;
Signed-off-by: Cédric Le Goater <clg@kaod.org> --- arch/arm/boot/dts/aspeed-g4.dtsi | 6 ++++++ arch/arm/boot/dts/aspeed-g5.dtsi | 6 ++++++ 2 files changed, 12 insertions(+)