mbox series

[v8,0/4] i2c: npcm: read/write operation, checkpatch

Message ID 20241219090859.18722-1-kfting@nuvoton.com
Headers show
Series i2c: npcm: read/write operation, checkpatch | expand

Message

Tyrone Ting Dec. 19, 2024, 9:08 a.m. UTC 
This patchset includes the following fixes:

- Enable the target functionality in the interrupt handling routine 
  when the i2c transfer is about to finish.
- Correct the read/write operation procedure.
- Introduce a software flag to handle the bus error (BER) condition
  which is not caused by the i2c transfer.
- Modify timeout calculation.
- Assign the client address earlier logically.
- Use an i2c frequency table for the frequency parameters assignment.
- Coding style fix.

The NPCM I2C driver is tested on NPCM750 and NPCM845 evaluation boards.

Addressed comments from:
- Paul Menzel : https://lore.kernel.org/lkml/67d34216-e98b-43d9-afd1-
  2e73ffb71968@molgen.mpg.de/
- Andi Shyti : https://lore.kernel.org/lkml/cexpymszobfl7676acibp474e
  q3qx242ppo22wrbjepxhufkvt@w4ptnmfjx7yo/
- Tali Perry : https://lore.kernel.org/lkml/CAHb3i=uT+Zx8m4hAF1M2yjCn
  =a5sDBn2wJajWdCm79syuy97Ag@mail.gmail.com/

Changes since version 7:
- Modify the commit title for better description.
- Modify i2c address assignment.

Changes since version 6:
- Modify code comments.
- Remove redundant code check.
- Remove i2c address mask.

Changes since version 5:
- Correct "EAGAIN" to "-EAGAIN" in the commit message.
- Configure the bus->dest_addr by calling i2c_8bit_addr_from_msg()
  and remove the I2C_M_RD flag when calling i2c_recover_bus().
- Fix the commit message which meets a too small wrapping limit.

Changes since version 4:
- Add more description for the codes.
- Modify the term "function" to "function()" in the commit message
and code comments.

Changes since version 3:
- Remove "Bug fixes" in the cover letter title.
- Modify the term "function" to "func()" in the commit message and
  code comments.
- Correct the coding style.

Changes since version 2:
- Add more explanations in the commit message and code modification.
- Use lower character names for declarations.
- Remove Fixes tags in commits which are not to fix bugs.

Changes since version 1:
- Restore the npcm_i2caddr array length to fix the smatch warning.
- Remove unused variables.
- Handle the condition where scl_table_cnt reaches to the maximum value.
- Fix the checkpatch warning.

Charles Boyer (1):
  i2c: npcm: Enable slave in eob interrupt

Tyrone Ting (3):
  i2c: npcm: Modify timeout evaluation mechanism
  i2c: npcm: Assign client address earlier for `i2c_recover_bus()`
  i2c: npcm: use i2c frequency table

 drivers/i2c/busses/i2c-npcm7xx.c | 427 +++++++++++++++++++++++--------
 1 file changed, 326 insertions(+), 101 deletions(-)


base-commit: 663bff1ddfe4ecbba3bcf4a74646bb388b1ad5b2

Comments

Andi Shyti Dec. 26, 2024, 12:52 a.m. UTC | #1 
Hi Tyrone,

> Charles Boyer (1):
>   i2c: npcm: Enable slave in eob interrupt
> 
> Tyrone Ting (3):
>   i2c: npcm: Modify timeout evaluation mechanism
>   i2c: npcm: Assign client address earlier for `i2c_recover_bus()`
>   i2c: npcm: use i2c frequency table

merged to i2c/i2c-host.

Thanks,
Andi
Tyrone Ting Dec. 27, 2024, 5:09 a.m. UTC | #2 
Hi Andi:

Thanks for the help and guidance from you and other reviewers alone the way.

Thank you again.

Andi Shyti <andi.shyti@kernel.org> 於 2024年12月26日 週四 上午8:52寫道：
>
> Hi Tyrone,
>
> > Charles Boyer (1):
> >   i2c: npcm: Enable slave in eob interrupt
> >
> > Tyrone Ting (3):
> >   i2c: npcm: Modify timeout evaluation mechanism
> >   i2c: npcm: Assign client address earlier for `i2c_recover_bus()`
> >   i2c: npcm: use i2c frequency table
>
> merged to i2c/i2c-host.
>
> Thanks,
> Andi

Thank you.

Regards,
Tyrone