| Message ID | 20190114130710.427600-1-tmaimon77@gmail.com |
|---|---|
| Headers | show |
| Series | dd NPCM7xx patches to dev-4.19 | expand |
Hi Tomer, On Tue, 15 Jan 2019 at 00:07, Tomer Maimon <tmaimon77@gmail.com> wrote: > > Hi Joel, > > Please add the following NPCM7xx patches to dev-4.19: I applied your series and it does not compile. I am using the npcm7xx_defconfig you included: arm-linux-gnueabi-ld: drivers/i2c/busses/i2c-npcm7xx.o: in function `npcm_smb_calc_crc8': drivers/i2c/busses/i2c-npcm7xx.c:423: undefined reference to `crc8' arm-linux-gnueabi-ld: drivers/i2c/busses/i2c-npcm7xx.o: in function `__npcm_i2c_init': drivers/i2c/busses/i2c-npcm7xx.c:1668: undefined reference to `crc8_populate_lsb' drivers/i2c/busses/i2c-npcm7xx.c:1669: undefined reference to `crc8_populate_msb' Please test the patchset exactly as you intend to send before sending it. In this case you needed to add `selects CRC8` to drivers/i2c/busses/Kconfig. You also have some warnings. Please send follow up patches ASAP to resolve these: ../drivers/iio/adc/npcm_adc.c: In function ‘npcm_adc_probe’: ../drivers/iio/adc/npcm_adc.c:301:9: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized] return ret; ^~~ arch/arm/boot/dts/nuvoton-npcm750-evb.dtb: Warning (pci_bridge): /ahb/axi-pcie@e1000000: node name is not "pci" or "pcie" arch/arm/boot/dts/nuvoton-npcm750-evb.dtb: Warning (pci_device_bus_num): Failed prerequisite 'pci_bridge' I have done this for you and the tree now builds. I've merged the patches into dev-4.19 and will push out once I've finished testing. Cheers, Joel
Hi Joel, Thanks a lot for applying the patches On Wed, 16 Jan 2019 at 01:46, Joel Stanley <joel@jms.id.au> wrote: > Hi Tomer, > > On Tue, 15 Jan 2019 at 00:07, Tomer Maimon <tmaimon77@gmail.com> wrote: > > > > Hi Joel, > > > > Please add the following NPCM7xx patches to dev-4.19: > > I applied your series and it does not compile. I am using the > npcm7xx_defconfig you included: > > arm-linux-gnueabi-ld: drivers/i2c/busses/i2c-npcm7xx.o: in function > `npcm_smb_calc_crc8': > drivers/i2c/busses/i2c-npcm7xx.c:423: undefined reference to `crc8' > arm-linux-gnueabi-ld: drivers/i2c/busses/i2c-npcm7xx.o: in function > `__npcm_i2c_init': > drivers/i2c/busses/i2c-npcm7xx.c:1668: undefined reference to > `crc8_populate_lsb' > drivers/i2c/busses/i2c-npcm7xx.c:1669: undefined reference to > `crc8_populate_msb' > > Please test the patchset exactly as you intend to send before sending it. > > I did test the patches with https://developer.arm.com/open-source/gnu-toolchain/gnu-a/downloads/8-2-2018-08 (gcc-arm-8.2-2018.08-x86_64-arm-linux-gnueabi) So I do not understand why you get this failures > In this case you needed to add `selects CRC8` to > drivers/i2c/busses/Kconfig. > > You also have some warnings. Please send follow up patches ASAP to > resolve these: > > ../drivers/iio/adc/npcm_adc.c: In function ‘npcm_adc_probe’: > ../drivers/iio/adc/npcm_adc.c:301:9: warning: ‘ret’ may be used > uninitialized in this function [-Wmaybe-uninitialized] > return ret; > ^~~ > > About the ADC patch you are right, somehow I didn't send the latest code of the ADC driver. I will send it today. > arch/arm/boot/dts/nuvoton-npcm750-evb.dtb: Warning (pci_bridge): > /ahb/axi-pcie@e1000000: node name is not "pci" or "pcie" > arch/arm/boot/dts/nuvoton-npcm750-evb.dtb: Warning > (pci_device_bus_num): Failed prerequisite 'pci_bridge' > > In the patch set you can find patch [linux dev-4.19 15/15] dts: npcm7xx: Modify NPCM7xx device tree It's fix the above warnings and modify other node. please apply it. > I have done this for you and the tree now builds. I've merged the > patches into dev-4.19 and will push out once I've finished testing. > > Cheers, > > Joel > I will make sure to send all the fixes today. Thanks a lot, Tomer <div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr">Hi Joel,<div><br></div><div>Thanks a lot for applying the patches</div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, 16 Jan 2019 at 01:46, Joel Stanley <<a href="mailto:joel@jms.id.au" target="_blank">joel@jms.id.au</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Tomer,<br> <br> On Tue, 15 Jan 2019 at 00:07, Tomer Maimon <<a href="mailto:tmaimon77@gmail.com" target="_blank">tmaimon77@gmail.com</a>> wrote:<br> ><br> > Hi Joel,<br> ><br> > Please add the following NPCM7xx patches to dev-4.19:<br> <br> I applied your series and it does not compile. I am using the<br> npcm7xx_defconfig you included:<br> <br> arm-linux-gnueabi-ld: drivers/i2c/busses/i2c-npcm7xx.o: in function<br> `npcm_smb_calc_crc8':<br> drivers/i2c/busses/i2c-npcm7xx.c:423: undefined reference to `crc8'<br> arm-linux-gnueabi-ld: drivers/i2c/busses/i2c-npcm7xx.o: in function<br> `__npcm_i2c_init':<br> drivers/i2c/busses/i2c-npcm7xx.c:1668: undefined reference to<br> `crc8_populate_lsb'<br> drivers/i2c/busses/i2c-npcm7xx.c:1669: undefined reference to<br> `crc8_populate_msb'<br> <br> Please test the patchset exactly as you intend to send before sending it.<br> <br></blockquote><div><br></div><div>I did test the patches with</div><div><a href="https://developer.arm.com/open-source/gnu-toolchain/gnu-a/downloads/8-2-2018-08">https://developer.arm.com/open-source/gnu-toolchain/gnu-a/downloads/8-2-2018-08</a><br></div><div>(gcc-arm-8.2-2018.08-x86_64-arm-linux-gnueabi)</div><div>So I do not understand why you get this failures</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> In this case you needed to add `selects CRC8` to drivers/i2c/busses/Kconfig.<br> <br> You also have some warnings. Please send follow up patches ASAP to<br> resolve these:<br> <br> ../drivers/iio/adc/npcm_adc.c: In function ‘npcm_adc_probe’:<br> ../drivers/iio/adc/npcm_adc.c:301:9: warning: ‘ret’ may be used<br> uninitialized in this function [-Wmaybe-uninitialized]<br> return ret;<br> ^~~<br> <br></blockquote><div>About the ADC patch you are right, somehow I didn't send the latest code of the ADC driver. I will send it today.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> arch/arm/boot/dts/nuvoton-npcm750-evb.dtb: Warning (pci_bridge):<br> /ahb/axi-pcie@e1000000: node name is not "pci" or "pcie"<br> arch/arm/boot/dts/nuvoton-npcm750-evb.dtb: Warning<br> (pci_device_bus_num): Failed prerequisite 'pci_bridge'<br> <br></blockquote><div>In the patch set you can find patch</div><div><font face="arial, helvetica, sans-serif"><span style="color:rgb(32,33,36);font-variant-ligatures:no-contextual">[linux dev-4.19 15/15] dts: npcm7xx: Modify NPCM7xx device tree</span><br></font></div><div><span style="color:rgb(32,33,36);font-variant-ligatures:no-contextual"><font face="arial, helvetica, sans-serif">It's fix the above warnings and modify other node.</font></span></div><div><span style="color:rgb(32,33,36);font-variant-ligatures:no-contextual"><font face="arial, helvetica, sans-serif">please apply it.</font></span></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I have done this for you and the tree now builds. I've merged the<br> patches into dev-4.19 and will push out once I've finished testing.<br> <br> Cheers,<br> <br> Joel<br></blockquote><div><br></div><div>I will make sure to send all the fixes today.</div><div><br></div><div>Thanks a lot,</div><div><br></div><div>Tomer</div></div></div></div></div></div>