diff mbox

SV: [PATCH 15/18] binutils/jpeg/lzo/tslib: Remove forced static/disabled

Message ID BD22328D0EB182418C2A0952DC2454F88086FEF5@VMPREVAS2.prevas.se
State Not Applicable
Headers show

Commit Message

kim.hansen@prevas.dk Jan. 5, 2015, 3:27 p.m. UTC 
Hi Yann,

This seems like something that could potentially break stuff, what problems does it cause?

/Kim

Comments

Yann Diorcet Jan. 5, 2015, 3:30 p.m. UTC | #1 
Hi,

It's still related to a a package granularity switches that i talk
about few times ago. If you take the patch which introduces enable
static/shared patch override --enable-shared and --enable-static is
enabled by default and can be disabled.

Yann

2015-01-05 16:27 GMT+01:00 Kim Højgaard-Hansen <Kim.Hansen@prevas.dk>:
> Hi Yann,
>
> This seems like something that could potentially break stuff, what problems does it cause?
>
> /Kim
> ____________________________
> KIM HØJGAARD-HANSEN
> Software Developer
>
> Prevas A/S
> Hedeager 1
> DK-8200 Århus N
>
> Central +45 87438070
> Direct/Mobile +45 51547387
> kim.hansen@prevas.dk
> www.prevas.dk
> ________________________________________
> Fra: dev-bounces@oe-lite.org [dev-bounces@oe-lite.org] p&#229; vegne af Yann Diorcet [diorcet.yann@gmail.com]
> Sendt: 6. august 2014 21:18
> Til: dev@oe-lite.org
> Emne: [PATCH 15/18] binutils/jpeg/lzo/tslib: Remove forced static/disabled
>
> ---
>  recipes/binutils/binutils.inc | 2 +-
>  recipes/jpeg/jpeg.inc         | 1 -
>  recipes/lzo/lzo.inc           | 2 --
>  recipes/tslib/tslib.inc       | 2 +-
>  4 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/recipes/binutils/binutils.inc b/recipes/binutils/binutils.inc
> index 95da776..0cbddf5 100644
> --- a/recipes/binutils/binutils.inc
> +++ b/recipes/binutils/binutils.inc
> @@ -17,7 +17,7 @@ SRC_URI = "${GNU_MIRROR}/binutils/binutils-${PV}.tar.bz2 "
>
>  DEPENDS = "native:flex native:bison"
>
> -EXTRA_OECONF = "--enable-install-libbfd --enable-shared"
> +EXTRA_OECONF = "--enable-install-libbfd"
>  EXTRA_OECONF:>HOST_CPU_arm = " --disable-werror"
>
>  inherit auto-package-libs
> diff --git a/recipes/jpeg/jpeg.inc b/recipes/jpeg/jpeg.inc
> index 7ab0e39..0f6c9ef 100644
> --- a/recipes/jpeg/jpeg.inc
> +++ b/recipes/jpeg/jpeg.inc
> @@ -7,7 +7,6 @@ RECIPE_TYPES = "machine native"
>
>  SRC_URI = "http://www.ijg.org/files/jpegsrc.v${PV}.tar.gz"
>
> -EXTRA_OECONF = "--enable-static --enable-shared"
>  CFLAGS += "-D_REENTRANT"
>
>  PACKAGES =+ "${PN}-tools "
> diff --git a/recipes/lzo/lzo.inc b/recipes/lzo/lzo.inc
> index 7fa802e..788265c 100644
> --- a/recipes/lzo/lzo.inc
> +++ b/recipes/lzo/lzo.inc
> @@ -7,8 +7,6 @@ inherit autotools library
>
>  SRC_URI = "http://www.oberhumer.com/opensource/lzo/download/lzo-${PV}.tar.gz"
>
> -EXTRA_OECONF = "--enable-shared"
> -
>  LIBRARY_NAME = "liblzo2"
>
>  DEPENDS_${PN} += "libc"
> diff --git a/recipes/tslib/tslib.inc b/recipes/tslib/tslib.inc
> index ef67e3e..8b0492b 100644
> --- a/recipes/tslib/tslib.inc
> +++ b/recipes/tslib/tslib.inc
> @@ -14,7 +14,7 @@ SRC_URI += "${SRC_URI_EXTRA}"
>
>  DEPENDS += "libdl"
>
> -EXTRA_OECONF += "--enable-shared ac_cv_func_malloc_0_nonnull=yes"
> +EXTRA_OECONF += "ac_cv_func_malloc_0_nonnull=yes"
>
>  do_install[postfuncs] += "do_install_extra"
>  do_install_extra () {
> --
> 2.0.1
>
> _______________________________________________
> dev mailing list
> dev@oe-lite.org
> http://lists.oe-lite.org/mailman/listinfo/dev
kim.hansen@prevas.dk Jan. 6, 2015, 7:21 a.m. UTC | #2 
hi Yann,

That would be a change in meta/core right? I would prefer we get it in there first then, then you can re-submit this, ok?

/Kim
Yann Diorcet Jan. 6, 2015, 7:30 a.m. UTC | #3 
No problem

Yann
Le 06/01/2015 08:21, Kim Højgaard-Hansen a écrit :
> hi Yann,
>
> That would be a change in meta/core right? I would prefer we get it in there first then, then you can re-submit this, ok?
>
> /Kim
> ____________________________
> KIM HØJGAARD-HANSEN
> Software Developer
>
> Prevas A/S
> Hedeager 1
> DK-8200 Århus N
>
> Central +45 87438070
> Direct/Mobile +45 51547387
> kim.hansen@prevas.dk
> www.prevas.dk
> ________________________________________
> Fra: Yann Diorcet [diorcet.yann@gmail.com]
> Sendt: 5. januar 2015 16:30
> Til: Kim Højgaard-Hansen
> Cc: dev@oe-lite.org
> Emne: Re: [PATCH 15/18] binutils/jpeg/lzo/tslib: Remove forced static/disabled
>
> Hi,
>
> It's still related to a a package granularity switches that i talk
> about few times ago. If you take the patch which introduces enable
> static/shared patch override --enable-shared and --enable-static is
> enabled by default and can be disabled.
>
> Yann
>
> 2015-01-05 16:27 GMT+01:00 Kim Højgaard-Hansen <Kim.Hansen@prevas.dk>:
>> Hi Yann,
>>
>> This seems like something that could potentially break stuff, what problems does it cause?
>>
>> /Kim
>> ____________________________
>> KIM HØJGAARD-HANSEN
>> Software Developer
>>
>> Prevas A/S
>> Hedeager 1
>> DK-8200 Århus N
>>
>> Central +45 87438070
>> Direct/Mobile +45 51547387
>> kim.hansen@prevas.dk
>> www.prevas.dk
>> ________________________________________
>> Fra: dev-bounces@oe-lite.org [dev-bounces@oe-lite.org] p&#229; vegne af Yann Diorcet [diorcet.yann@gmail.com]
>> Sendt: 6. august 2014 21:18
>> Til: dev@oe-lite.org
>> Emne: [PATCH 15/18] binutils/jpeg/lzo/tslib: Remove forced static/disabled
>>
>> ---
>>  recipes/binutils/binutils.inc | 2 +-
>>  recipes/jpeg/jpeg.inc         | 1 -
>>  recipes/lzo/lzo.inc           | 2 --
>>  recipes/tslib/tslib.inc       | 2 +-
>>  4 files changed, 2 insertions(+), 5 deletions(-)
>>
>> diff --git a/recipes/binutils/binutils.inc b/recipes/binutils/binutils.inc
>> index 95da776..0cbddf5 100644
>> --- a/recipes/binutils/binutils.inc
>> +++ b/recipes/binutils/binutils.inc
>> @@ -17,7 +17,7 @@ SRC_URI = "${GNU_MIRROR}/binutils/binutils-${PV}.tar.bz2 "
>>
>>  DEPENDS = "native:flex native:bison"
>>
>> -EXTRA_OECONF = "--enable-install-libbfd --enable-shared"
>> +EXTRA_OECONF = "--enable-install-libbfd"
>>  EXTRA_OECONF:>HOST_CPU_arm = " --disable-werror"
>>
>>  inherit auto-package-libs
>> diff --git a/recipes/jpeg/jpeg.inc b/recipes/jpeg/jpeg.inc
>> index 7ab0e39..0f6c9ef 100644
>> --- a/recipes/jpeg/jpeg.inc
>> +++ b/recipes/jpeg/jpeg.inc
>> @@ -7,7 +7,6 @@ RECIPE_TYPES = "machine native"
>>
>>  SRC_URI = "http://www.ijg.org/files/jpegsrc.v${PV}.tar.gz"
>>
>> -EXTRA_OECONF = "--enable-static --enable-shared"
>>  CFLAGS += "-D_REENTRANT"
>>
>>  PACKAGES =+ "${PN}-tools "
>> diff --git a/recipes/lzo/lzo.inc b/recipes/lzo/lzo.inc
>> index 7fa802e..788265c 100644
>> --- a/recipes/lzo/lzo.inc
>> +++ b/recipes/lzo/lzo.inc
>> @@ -7,8 +7,6 @@ inherit autotools library
>>
>>  SRC_URI = "http://www.oberhumer.com/opensource/lzo/download/lzo-${PV}.tar.gz"
>>
>> -EXTRA_OECONF = "--enable-shared"
>> -
>>  LIBRARY_NAME = "liblzo2"
>>
>>  DEPENDS_${PN} += "libc"
>> diff --git a/recipes/tslib/tslib.inc b/recipes/tslib/tslib.inc
>> index ef67e3e..8b0492b 100644
>> --- a/recipes/tslib/tslib.inc
>> +++ b/recipes/tslib/tslib.inc
>> @@ -14,7 +14,7 @@ SRC_URI += "${SRC_URI_EXTRA}"
>>
>>  DEPENDS += "libdl"
>>
>> -EXTRA_OECONF += "--enable-shared ac_cv_func_malloc_0_nonnull=yes"
>> +EXTRA_OECONF += "ac_cv_func_malloc_0_nonnull=yes"
>>
>>  do_install[postfuncs] += "do_install_extra"
>>  do_install_extra () {
>> --
>> 2.0.1
>>
>> _______________________________________________
>> dev mailing list
>> dev@oe-lite.org
>> http://lists.oe-lite.org/mailman/listinfo/dev
>
>
> --
> Diorcet Yann
diff mbox

Patch

diff --git a/recipes/binutils/binutils.inc b/recipes/binutils/binutils.inc
index 95da776..0cbddf5 100644
--- a/recipes/binutils/binutils.inc
+++ b/recipes/binutils/binutils.inc
@@ -17,7 +17,7 @@  SRC_URI = "${GNU_MIRROR}/binutils/binutils-${PV}.tar.bz2 "

 DEPENDS = "native:flex native:bison"

-EXTRA_OECONF = "--enable-install-libbfd --enable-shared"
+EXTRA_OECONF = "--enable-install-libbfd"
 EXTRA_OECONF:>HOST_CPU_arm = " --disable-werror"

 inherit auto-package-libs
diff --git a/recipes/jpeg/jpeg.inc b/recipes/jpeg/jpeg.inc
index 7ab0e39..0f6c9ef 100644
--- a/recipes/jpeg/jpeg.inc
+++ b/recipes/jpeg/jpeg.inc
@@ -7,7 +7,6 @@  RECIPE_TYPES = "machine native"

 SRC_URI = "http://www.ijg.org/files/jpegsrc.v${PV}.tar.gz"

-EXTRA_OECONF = "--enable-static --enable-shared"
 CFLAGS += "-D_REENTRANT"

 PACKAGES =+ "${PN}-tools "
diff --git a/recipes/lzo/lzo.inc b/recipes/lzo/lzo.inc
index 7fa802e..788265c 100644
--- a/recipes/lzo/lzo.inc
+++ b/recipes/lzo/lzo.inc
@@ -7,8 +7,6 @@  inherit autotools library

 SRC_URI = "http://www.oberhumer.com/opensource/lzo/download/lzo-${PV}.tar.gz"

-EXTRA_OECONF = "--enable-shared"
-
 LIBRARY_NAME = "liblzo2"

 DEPENDS_${PN} += "libc"
diff --git a/recipes/tslib/tslib.inc b/recipes/tslib/tslib.inc
index ef67e3e..8b0492b 100644
--- a/recipes/tslib/tslib.inc
+++ b/recipes/tslib/tslib.inc
@@ -14,7 +14,7 @@  SRC_URI += "${SRC_URI_EXTRA}"

 DEPENDS += "libdl"

-EXTRA_OECONF += "--enable-shared ac_cv_func_malloc_0_nonnull=yes"
+EXTRA_OECONF += "ac_cv_func_malloc_0_nonnull=yes"

 do_install[postfuncs] += "do_install_extra"
 do_install_extra () {