From patchwork Mon Dec 14 20:47:31 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jozsef Kadlecsik X-Patchwork-Id: 556629 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 822901401AF for ; Tue, 15 Dec 2015 07:47:37 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=blackhole.kfki.hu header.i=@blackhole.kfki.hu header.b=VZ4mlc23; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753478AbbLNUrf (ORCPT ); Mon, 14 Dec 2015 15:47:35 -0500 Received: from smtp-in.kfki.hu ([148.6.0.25]:51799 "EHLO smtp0.kfki.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753201AbbLNUre (ORCPT ); Mon, 14 Dec 2015 15:47:34 -0500 Received: from localhost (localhost [127.0.0.1]) by smtp0.kfki.hu (Postfix) with ESMTP id CCD1D67400E9; Mon, 14 Dec 2015 21:47:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= blackhole.kfki.hu; h=content-type:content-type:mime-version :user-agent:references:message-id:message-id:in-reply-to:from :from:date:date:received:received:received; s=20151130; t= 1450126049; x=1451940450; bh=6PnHw6onsUP8GY9sESVtqv9XZ/RvQcV8wAp +ATYrGEk=; b=VZ4mlc23K4C1M7OAy3QWbc3/4dPMkiwPV43UK8u4O3rURzTxqIe EnZK4UW2Zdo4NEZtFHGfQJlcuyyZFym7bGwMuCie9sLX+8Nc9jiaIwrnIMOZH0nC AJCAfAux6wcZr4N9Lr27m7Htnmu65mhre/9q80YE0oQHvfCY9eVQQAEA= X-Virus-Scanned: Debian amavisd-new at smtp0.kfki.hu Received: from smtp0.kfki.hu ([127.0.0.1]) by localhost (smtp0.kfki.hu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id VNGROlsr6ZTU; Mon, 14 Dec 2015 21:47:29 +0100 (CET) Received: from blackhole.kfki.hu (blackhole.kfki.hu [148.6.0.114]) by smtp0.kfki.hu (Postfix) with ESMTP id BBF4367400E2; Mon, 14 Dec 2015 21:47:28 +0100 (CET) Received: by blackhole.kfki.hu (Postfix, from userid 1000) id 5A90E21766; Mon, 14 Dec 2015 21:47:31 +0100 (CET) Date: Mon, 14 Dec 2015 21:47:31 +0100 (CET) From: Jozsef Kadlecsik To: Jan Engelhardt cc: =?ISO-8859-15?Q?D=E2niel_Fraga?= , Florian Westphal , Noel Kuntze , =?ISO-8859-15?Q?Remzi_AKY=DCZ?= , netfilter@vger.kernel.org, netfilter-devel@vger.kernel.org Subject: Re: Linux 4.3.1 regression: -m state returns "Protocol wrong type for socket" In-Reply-To: Message-ID: References: <566BEF33.7090501@gmail.com> <566C09F5.6080606@gmail.com> <566C0E75.6080800@familie-kuntze.de> <566c4622.936d810a.ece67.ffffdfc9@mx.google.com> <20151212232044.GE12854@breakpoint.cc> <566cae67.86f60d0a.f3ad2.2638@mx.google.com> <566cb640.46dc0d0a.5c3cc.287a@mx.google.com> <566cbcbe.01ed0d0a.36f37.2c88@mx.google.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Sun, 13 Dec 2015, Jan Engelhardt wrote: > On Sunday 2015-12-13 01:32, Dâniel Fraga wrote: > > >On Sun, 13 Dec 2015 01:30:17 +0100 (CET) > >Jan Engelhardt wrote: > > > >> nf_conntrack_ipv4 is indeed autoloaded (provided modprobe can do it) > >> when you cause instantiation of a xt_conntrack (or xt_state) rule > >> object through ip(4)tables. And if modprobe cannot satisfy the > >> request, that feeds back through the kernel and to iptables, which > >> may then report it to stderr. > > > > No, I mean selected in the "make menuconfig" ;) If the user > >chooses to compile state module, menuconfig won't select automatically > >nf_conntrack_ipv4 (and it should, since it depends on it). > > There is nothing to add to Kconfig, because there is no build-time > dependency here. In addition, some people might get grumpy if the > CONFIG_NETFILTER_XT_MATCH_CONNTRACK gained a dependency on something it > does not depend on at runtime in 100% of cases. But the reversed dependency is what seems to be missing, something like this: Best regards, Jozsef - E-mail : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences H-1525 Budapest 114, POB. 49, Hungary diff --git a/net/ipv4/netfilter/Kconfig b/net/ipv4/netfilter/Kconfig index a355841..a1dfd23 100644 --- a/net/ipv4/netfilter/Kconfig +++ b/net/ipv4/netfilter/Kconfig @@ -12,6 +12,7 @@ config NF_DEFRAG_IPV4 config NF_CONNTRACK_IPV4 tristate "IPv4 connection tracking support (required for NAT)" depends on NF_CONNTRACK + default NETFILTER_XT_MATCH_CONNTRACK default m if NETFILTER_ADVANCED=n select NF_DEFRAG_IPV4 ---help---