| Message ID | YAUVdnEg6OMPsUet@hydrogen |
|---|---|
| State | Accepted |
| Delegated to: | Jozsef Kadlecsik |
| Headers | show |
| Series | ipset: fix print format warning | expand |
Hi, On Mon, 18 Jan 2021, Neutron Soutmun wrote: > * Use PRIx64 for portablility over various architectures. > * The format string for the 64bit number printing is incorrect, > the `%` sign is missing. > * The force types casting over the uint32_t and uint64_t are unnecessary > which warned by the compiler on different architecture. > > Signed-off-by: Neutron Soutmun <neo.neutron@gmail.com> Thanks, patch is applied in the ipset git tree. Best regards, Jozsef > --- > lib/print.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lib/print.c b/lib/print.c > index 0d86a98..a7ffd81 100644 > --- a/lib/print.c > +++ b/lib/print.c > @@ -431,10 +431,10 @@ ipset_print_hexnumber(char *buf, unsigned int len, > *(const uint16_t *) number); > else if (maxsize == sizeof(uint32_t)) > return snprintf(buf, len, "0x%08"PRIx32, > - (long unsigned) *(const uint32_t *) number); > + *(const uint32_t *) number); > else if (maxsize == sizeof(uint64_t)) > - return snprintf(buf, len, "0x016lx", > - (long long unsigned) *(const uint64_t *) number); > + return snprintf(buf, len, "0x%016"PRIx64, > + *(const uint64_t *) number); > else > assert(0); > return 0; > -- > 2.30.0 > - E-mail : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.hu PGP key : https://wigner.hu/~kadlec/pgp_public_key.txt Address : Wigner Research Centre for Physics H-1525 Budapest 114, POB. 49, Hungary
diff --git a/lib/print.c b/lib/print.c index 0d86a98..a7ffd81 100644 --- a/lib/print.c +++ b/lib/print.c @@ -431,10 +431,10 @@ ipset_print_hexnumber(char *buf, unsigned int len, *(const uint16_t *) number); else if (maxsize == sizeof(uint32_t)) return snprintf(buf, len, "0x%08"PRIx32, - (long unsigned) *(const uint32_t *) number); + *(const uint32_t *) number); else if (maxsize == sizeof(uint64_t)) - return snprintf(buf, len, "0x016lx", - (long long unsigned) *(const uint64_t *) number); + return snprintf(buf, len, "0x%016"PRIx64, + *(const uint64_t *) number); else assert(0); return 0;
* Use PRIx64 for portablility over various architectures. * The format string for the 64bit number printing is incorrect, the `%` sign is missing. * The force types casting over the uint32_t and uint64_t are unnecessary which warned by the compiler on different architecture. Signed-off-by: Neutron Soutmun <neo.neutron@gmail.com> --- lib/print.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.30.0