| Message ID | 9b81cec687c3082f5fd762ece696f1272945e0ad.1506928244.git.harshasharmaiitr@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Pablo Neira |
| Headers | show |
| Series | evaluate: Follow linux-kernel coding style | expand |
On Mon, Oct 02, 2017 at 01:02:50PM +0530, Harsha Sharma wrote: > static const char * array should probably be static const char * const > array > as per linux-kernel coding style > > Signed-off-by: Harsha Sharma <harshasharmaiitr@gmail.com> > --- > src/evaluate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/evaluate.c b/src/evaluate.c > index b783054..f48801a 100644 > --- a/src/evaluate.c > +++ b/src/evaluate.c > @@ -33,7 +33,7 @@ > static struct output_ctx octx_debug_dummy; > static int expr_evaluate(struct eval_ctx *ctx, struct expr **expr); > > -static const char *byteorder_names[] = { > +static const char * const byteorder_names[] = { I can see more string array that could use this in the nftables tree. Please, fix all in one single patch. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/src/evaluate.c b/src/evaluate.c index b783054..f48801a 100644 --- a/src/evaluate.c +++ b/src/evaluate.c @@ -33,7 +33,7 @@ static struct output_ctx octx_debug_dummy; static int expr_evaluate(struct eval_ctx *ctx, struct expr **expr); -static const char *byteorder_names[] = { +static const char * const byteorder_names[] = { [BYTEORDER_INVALID] = "invalid", [BYTEORDER_HOST_ENDIAN] = "host endian", [BYTEORDER_BIG_ENDIAN] = "big endian", @@ -3350,7 +3350,7 @@ static int cmd_evaluate_export(struct eval_ctx *ctx, struct cmd *cmd) ctx->debug_mask & DEBUG_NETLINK); } -static const char *cmd_op_name[] = { +static const char * const cmd_op_name[] = { [CMD_INVALID] = "invalid", [CMD_ADD] = "add", [CMD_REPLACE] = "replace",
static const char * array should probably be static const char * const array as per linux-kernel coding style Signed-off-by: Harsha Sharma <harshasharmaiitr@gmail.com> --- src/evaluate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)