diff mbox

add missing ipset_parse_tcp_udp_port to libipset.map

Message ID 544AA6FF.1000803@mageia.org
State Superseded
Delegated to: Pablo Neira
Headers show

Commit Message

Thomas Backlund Oct. 24, 2014, 7:23 p.m. UTC
Found this issue when we switched from 6.19 static build to 6.21 dynamic 
build, and is still there in 6.23

--
Thomas

Comments

Jan Engelhardt Oct. 24, 2014, 8:08 p.m. UTC | #1
On Friday 2014-10-24 21:23, Thomas Backlund wrote:

> Found this issue when we switched from 6.19 static build to 6.21 dynamic build,
> and is still there in 6.23

What has been released is immutable; after a release, only add 
symbols to new sections.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jozsef Kadlecsik Oct. 24, 2014, 8:44 p.m. UTC | #2
On Fri, 24 Oct 2014, Jan Engelhardt wrote:

> On Friday 2014-10-24 21:23, Thomas Backlund wrote:
> 
> > Found this issue when we switched from 6.19 static build to 6.21 dynamic build,
> > and is still there in 6.23
> 
> What has been released is immutable; after a release, only add 
> symbols to new sections.

Yes, that's so. I'm going to write a check to catch such missing items 
before a release in the future.

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlecsik.jozsef@wigner.mta.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences
          H-1525 Budapest 114, POB. 49, Hungary
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch


Commit: 

author	Quentin Armitage <quentin@armitage.org.uk>	2013-08-09 11:26:33 (GMT)
committer	Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>	2013-08-17 19:31:29 (GMT)
commit	480761a3bdaa55bf8c966e4dab950ebf84775863 (patch)
tree	6d750f948abf1ae4f93e4c704502d085ac13d679
parent	3a4419954a3ae0ba5dafd711e6b8dd8f0beb5c21 (diff)
Add specifying protocol for bitmap:port
Signed-off-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>

added ipset_parse_tcp_udp_port, but forgot to update libipset.map

so we get:

# ipset list
/usr/lib64/ipset/ipset_bitmap_port.so: /usr/lib64/ipset/ipset_bitmap_port.so: undefined symbol: ipset_parse_tcp_udp_port

so update the map.

Signed-off-by: Thomas Backlund <tmb@mageia.org>


---
Note, this patch is against a build that also has the ipset_parse_uint16 added:
http://www.spinics.net/lists/netfilter-devel/msg33805.html

Since there is now 2 issues, what should be done for:
"bump API curr and age in Make_global.am and add a new section to libipset.map"

diff -Nurp ipset-6.23.old/lib/libipset.map ipset-6.23/lib/libipset.map
--- ipset-6.23.old/lib/libipset.map	2014-10-24 21:34:52.000000000 +0300
+++ ipset-6.23/lib/libipset.map	2014-10-24 21:45:46.502262622 +0300
@@ -149,6 +149,7 @@  LIBIPSET_4.3 {
 global:
   ipset_parse_skbmark;
   ipset_parse_skbprio;
+  ipset_parse_tcp_udp_port;
   ipset_parse_uint16;
   ipset_print_skbmark;
   ipset_print_skbprio;