| Message ID | 20261104-work-procfs-bugfixes-v2-3-021c84d852e0@kernel.org |
|---|---|
| State | Handled Elsewhere |
| Headers | show
Return-Path: <netfilter-devel+bounces-16957-incoming=patchwork.ozlabs.org@vger.kernel.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=omO9IGCx; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=104.64.211.4; helo=sin.lore.kernel.org; envelope-from=netfilter-devel+bounces-16957-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4jKg6j44Ytz1xrS for <incoming@patchwork.ozlabs.org>; Thu, 05 Nov 2026 09:27:25 +1100 (AEDT) Received: from smtp.subspace.kernel.org (conduit.subspace.kernel.org [100.77.114.92]) by sin.lore.kernel.org (Postfix) with ESMTP id 936B73980C for <incoming@patchwork.ozlabs.org>; Wed, 4 Nov 2026 19:17:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=127.0.0.1 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1793819825; b=qsW0MVGmIebSpeZ4MHfl3aFvM00LLGLloWxFiMPdiNGx6MArRu8O7FOFpxtdIWIsAOxs ypuRljoGm+l8ojCq3MnxZTrYLJCwODHakh5bGfHUO7r+JrfZzsehAP2jYZFGf9FAEWMGu nf0wjlYzYdqlqjzsNF+vUkDLDchbZ5OW1YbROb2PbXvRsUcMxQ5dTib2vbkZo0zbDekj/ dRWLCg3W6m9i+RXS9cMAwx6GSiz9NIE+ou9Z+JRqE8ewKudkYnhHC3nC1Pg+q0jArHvta EZEQ2lO2BeCwbQAE9CETZXrHHlhMxBJ+Ueoc/BgLOK3wbX9cZLZLSk7uEhrb6vR17qw== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793819825; h=X-Original-To:Received:Received:DKIM-Signature:From:To:Cc:Subject: Date:Message-ID:In-Reply-To:References:X-Mailing-List:List-Id: List-Post:List-Help:List-Subscribe:List-Unsubscribe:List-Owner: Precedence:MIME-Version:Content-Type:X-Mailer:X-Developer-Signature: X-Developer-Key:Content-Transfer-Encoding; bh=Cbujoj2vf5W42joV5o7W0AvKkij9cCOpaGGghku9+G8=; b=bT/xn88QBaZ2EDoKDJJZoAkswYpCz1iZJA/J4tC3VLaALZogwM4V4htW269yeBeEUIUd vk7U0oeR5pZZWQvG8L3ALirIdHtEl9jOzMfnMgBGrvFVkTt03XIoksnLdKMXNWgysRz3H XMEulr6GyjdWs9YSD1wH4XeHZeVZGtmz6Nz2BcWDsW4KaBaUxA8GFH7mDcaPd5RzKJg5y z3GVKnKT1dt4Sqnps1cThTqP63d+36kLproYTurBbHHxM2T4i/chJVtbuyRxKiWxHTIum Gwxvu2mjgcvLrt7wW9zNMHGpDVL0QfCUyQ2FGeE/xUPgCXWc3rrwJEpf2plXHW6OvTA== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=omO9IGCx; arc=pass header.oldest-pass=0 smtp.remote-ip=127.0.0.1 Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9FFDD606EE9F; Wed, 4 Nov 2026 19:17:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=omO9IGCx X-Original-To: netfilter-devel@vger.kernel.org Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793819820; b=vSjsG8U6sqXrNArx+izivr7UKWuxrC5qFRL4RUVoMbHWeIOpS9be6VDUHDU17pjQepGc 6IzJg3o/k4t8AqIgT4yv7ynSX+EWRzYOeeuQb4Yr9jaKOWPWBeyKxoej/KXz13nAd7z55 3a09Hnlhos7tif03HainiCzAWAz0REHvzrxZc3oAPfphM8AJc/atV7UVuEJCcrf5fnjTl nZBXF6khTq0nJWjCUU+HYAIqz4AVy8uvXKIJCv+a3kcxe0DFXodW/6h8dNQt9ETBgAiuJ VITGhYoGgr0E26y1w7hXb24XjjDoMl6DDfpfUxo+4McpmabPpisgGpkLfmYczuy1BVA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793819820; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID: In-Reply-To:References:MIME-Version:Content-Type:X-Mailer: X-Developer-Signature:X-Developer-Key:Content-Transfer-Encoding; bh=Cbujoj2vf5W42joV5o7W0AvKkij9cCOpaGGghku9+G8=; b=xEOV+MXl6cw+l2q8ztcDZugn9vZSUb6rtwCLDUbSnxC3w1JJUFqprPWY+A67oKf6vnxL Hn5ZgtJMJeaqsnhmJRuJlnaorQwa7Klskw0HOFgTINMo9XkFD3vvO2TaFbnTaOIjwRxtj Lht08vv/agvJQxTGjE+NyVVQFv5oYc4HXxLAV5hInPjXlShSu8FvYeIZnQz58aj/Aw0YS HU1FnGFQ7GArMxh9D5NvVXLYFwbIRv+M8+1hzEt7COntvm1Dec1k2Pf9vvnTSNVzfKY3b nbG0AQkPmtyKRmIMdzvQogwzRnjr+WIILyqYndN3OCZMU4gsrwzBgD96/5jrl3G8RnA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=omO9IGCx; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CB71606D803; Wed, 4 Nov 2026 19:16:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24F441F00A02; Wed, 4 Nov 2026 19:16:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793819819; bh=Cbujoj2vf5W42joV5o7W0AvKkij9cCOpaGGghku9+G8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=omO9IGCxRyG7KD0kOxfDpDxNQyYIzODWVtRjkLnN3/zFnPKj34X5crXOKucSFkfWr K2vwmPWEfSCfTc7KrJwcOMFunLOjtXDVztdyYUmknteKFz3PelPVAL1UgBnI+tAbd4 XF5ErKRbX8bdCtSjgX0zvSFTT6L0PDEOQbHUmwQkI114XRdB8cIfxqGscpwpemafw3 K7MJZBUNHbtj7OSLbkije9HCjsdQTGe+6yASXSAIELhzrF5YD6mcuYVUBb8Sm2r2MZ MV/cCX6mrHLPa/XrLIYAdVEN9IQTdCweH82A0WOCV2qCcCupff8Ero6Vt+lk3uRxZE xip5YgJ7X0fVA== From: Christian Brauner <brauner@kernel.org> To: linux-fsdevel@vger.kernel.org Cc: Linus Torvalds <torvalds@linux-foundation.org>, Jann Horn <jannh@google.com>, Josef Bacik <josef@toxicpanda.com>, Chris Mason <mason@kernel.org>, Jeff Layton <jlayton@kernel.org>, NeilBrown <neil@brown.name>, Eric Dumazet <edumazet@kernel.org>, Thomas Gleixner <tglx@kernel.org>, Al Viro <viro@zeniv.linux.org.uk>, Jonathan Corbet <corbet@lwn.net>, Christoph Hellwig <hch@lst.de>, Greg Kroah-Hartman <gregkh@suse.de>, Joel Granados <joel.granados@kernel.org>, Kees Cook <kees@kernel.org>, Jan Kara <jack@suse.cz>, Jan Kara <jack@suse.com>, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-um@lists.infradead.org, linux-wireless@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, ntfs3@lists.linux.dev, platform-driver-x86@vger.kernel.org, coreteam@netfilter.org, kexec@lists.infradead.org, linux-pci@vger.kernel.org, linux-sound@vger.kernel.org, netfilter-devel@vger.kernel.org, dri-devel@lists.freedesktop.org, ibm-acpi-devel@lists.sourceforge.net, jfs-discussion@lists.sourceforge.net, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-cifs@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-mm@kvack.org, linux-sh@vger.kernel.org, linux-usb@vger.kernel.org, samba-technical@lists.samba.org, sparclinux@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-doc@vger.kernel.org, linux-serial@vger.kernel.org, linux-atm-general@lists.sourceforge.net, Takashi Iwai <tiwai@suse.de>, linux-input@vger.kernel.org, linux-raid@vger.kernel.org, linux-ext4@vger.kernel.org, linux-modules@vger.kernel.org, linux-debuggers@vger.kernel.org, "Christian Brauner (Amutable)" <brauner@kernel.org>, Chuck Lever <cel@kernel.org>, stable@vger.kernel.org Subject: [PATCH RESEND v2 03/51] ALSA: cs46xx: hand the region to the region proc files Date: Wed, 4 Nov 2026 20:16:45 +0100 Message-ID: <20261104-work-procfs-bugfixes-v2-3-021c84d852e0@kernel.org> In-Reply-To: <20261104-work-procfs-bugfixes-v2-0-021c84d852e0@kernel.org> References: <20261104-work-procfs-bugfixes-v2-0-021c84d852e0@kernel.org> X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: <netfilter-devel.vger.kernel.org> List-Post: <mailto:netfilter-devel@vger.kernel.org> List-Help: <mailto:netfilter-devel+help@vger.kernel.org> List-Subscribe: <mailto:netfilter-devel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:netfilter-devel+unsubscribe@vger.kernel.org> List-Owner: <mailto:netfilter-devel+owner@vger.kernel.org> Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.17-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=1215; i=brauner@kernel.org; h=from:subject:message-id; bh=Z6ZRkJrhuCU4H5MdQ4cObdjJffW/paOotMbfYVXoKlo=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMWS9bjy38dymo9fKTmUGbmnq3vJ19u55ybMf3qtLXF/lV 3V+wtzWzx2lLAxiXAyyYoosDu0m4XLLeSo2G2VqwMxhZQIZwsDFKQAT+VXCyPDsb6PwnbR1njvC l2SKvFp3T79ebMkTpTsZWRmxsjzl6xoZ/qmcK6g8/p/jzJXZ7Ak/uerEBKe8Z+6ItmpmfjKzNzX 8DSMA X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit |
| Series |
[RESEND,v2,01/51] alloc_tag: don't remove /proc/allocinfo under the codetag module lock
|
expand
|
On Wed, 04 Nov 2026 20:16:45 +0100, Christian Brauner wrote: > > snd_cs46xx_proc_init() stores the chip in the private data of the five > region entries, but snd_cs46xx_io_read() reads that back as the region, > so a read of /proc/asound/cardN/CS46xx_BA0 and friends copies from > whatever sits at the region's offset in struct snd_cs46xx instead of > the mapped registers. Store the region. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Cc: stable@vger.kernel.org > Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org> Reviewed-by: Takashi Iwai <tiwai@suse.de> thanks, Takashi
diff --git a/sound/pci/cs46xx/cs46xx_lib.c b/sound/pci/cs46xx/cs46xx_lib.c index 797a5f09cade..efc7df444cb5 100644 --- a/sound/pci/cs46xx/cs46xx_lib.c +++ b/sound/pci/cs46xx/cs46xx_lib.c @@ -2764,7 +2764,7 @@ static int snd_cs46xx_proc_init(struct snd_card *card, struct snd_cs46xx *chip) struct snd_cs46xx_region *region = &chip->region.idx[idx]; if (! snd_card_proc_new(card, region->name, &entry)) { entry->content = SNDRV_INFO_CONTENT_DATA; - entry->private_data = chip; + entry->private_data = region; entry->c.ops = &snd_cs46xx_proc_io_ops; entry->size = region->size; entry->mode = S_IFREG | 0400;
snd_cs46xx_proc_init() stores the chip in the private data of the five region entries, but snd_cs46xx_io_read() reads that back as the region, so a read of /proc/asound/cardN/CS46xx_BA0 and friends copies from whatever sits at the region's offset in struct snd_cs46xx instead of the mapped registers. Store the region. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org> --- sound/pci/cs46xx/cs46xx_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)