diff mbox series

[nf-next] netfilter: xtables: support arpt_mark and ipv6 optstrip for iptables-nft only builds

Message ID 20250516141216.26745-1-fw@strlen.de
State Accepted
Headers show
Series [nf-next] netfilter: xtables: support arpt_mark and ipv6 optstrip for iptables-nft only builds | expand

Commit Message

Florian Westphal May 16, 2025, 2:12 p.m. UTC
Its now possible to build a kernel that has no support for the classic
xtables get/setsockopt interfaces and builtin tables.

In this case, we have CONFIG_IP6_NF_MANGLE=n and
CONFIG_IP_NF_ARPTABLES=n.

For optstript, the ipv6 code is so small that we can enable it if
netfilter ipv6 support exists. For mark, check if either classic
arptables or NFT_ARP_COMPAT is set.

Fixes: a9525c7f6219 ("netfilter: xtables: allow xtables-nft only builds")
Signed-off-by: Florian Westphal <fw@strlen.de>
---
 nf-next as we're too late in this development cycle.
 I detached this from the larger 'Exclude LEGACY TABLES on PREEMPT_RT'
 as its a self-standing bug fix.

 net/netfilter/xt_TCPOPTSTRIP.c | 4 ++--
 net/netfilter/xt_mark.c        | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Pablo Neira Ayuso May 21, 2025, 1:57 p.m. UTC | #1
On Fri, May 16, 2025 at 04:12:13PM +0200, Florian Westphal wrote:
> Its now possible to build a kernel that has no support for the classic
> xtables get/setsockopt interfaces and builtin tables.
> 
> In this case, we have CONFIG_IP6_NF_MANGLE=n and
> CONFIG_IP_NF_ARPTABLES=n.
> 
> For optstript, the ipv6 code is so small that we can enable it if
> netfilter ipv6 support exists. For mark, check if either classic
> arptables or NFT_ARP_COMPAT is set.

Applied to nf-next, thanks
diff mbox series

Patch

diff --git a/net/netfilter/xt_TCPOPTSTRIP.c b/net/netfilter/xt_TCPOPTSTRIP.c
index 30e99464171b..93f064306901 100644
--- a/net/netfilter/xt_TCPOPTSTRIP.c
+++ b/net/netfilter/xt_TCPOPTSTRIP.c
@@ -91,7 +91,7 @@  tcpoptstrip_tg4(struct sk_buff *skb, const struct xt_action_param *par)
 	return tcpoptstrip_mangle_packet(skb, par, ip_hdrlen(skb));
 }
 
-#if IS_ENABLED(CONFIG_IP6_NF_MANGLE)
+#if IS_ENABLED(CONFIG_IP6_NF_IPTABLES)
 static unsigned int
 tcpoptstrip_tg6(struct sk_buff *skb, const struct xt_action_param *par)
 {
@@ -119,7 +119,7 @@  static struct xt_target tcpoptstrip_tg_reg[] __read_mostly = {
 		.targetsize = sizeof(struct xt_tcpoptstrip_target_info),
 		.me         = THIS_MODULE,
 	},
-#if IS_ENABLED(CONFIG_IP6_NF_MANGLE)
+#if IS_ENABLED(CONFIG_IP6_NF_IPTABLES)
 	{
 		.name       = "TCPOPTSTRIP",
 		.family     = NFPROTO_IPV6,
diff --git a/net/netfilter/xt_mark.c b/net/netfilter/xt_mark.c
index 65b965ca40ea..59b9d04400ca 100644
--- a/net/netfilter/xt_mark.c
+++ b/net/netfilter/xt_mark.c
@@ -48,7 +48,7 @@  static struct xt_target mark_tg_reg[] __read_mostly = {
 		.targetsize     = sizeof(struct xt_mark_tginfo2),
 		.me             = THIS_MODULE,
 	},
-#if IS_ENABLED(CONFIG_IP_NF_ARPTABLES)
+#if IS_ENABLED(CONFIG_IP_NF_ARPTABLES) || IS_ENABLED(CONFIG_NFT_COMPAT_ARP)
 	{
 		.name           = "MARK",
 		.revision       = 2,