diff mbox series

[nf,v2,1/2] netfilter: nf_tables: disallow anonymous set with timeout flag

Message ID 20240301022605.146412-1-pablo@netfilter.org
State Accepted, archived
Headers show
Series [nf,v2,1/2] netfilter: nf_tables: disallow anonymous set with timeout flag | expand

Commit Message

Pablo Neira Ayuso March 1, 2024, 2:26 a.m. UTC
Anonymous sets are never used with timeout from userspace, reject this.
Exception to this rule is NFT_SET_EVAL to ensure legacy meters still work.

Fixes: 761da2935d6e ("netfilter: nf_tables: add set timeout API support")
Reported-by: lonial con <kongln9170@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
v2: allow NFT_SET_EVAL so meters (and use of nft_set_hash) is still possible

 net/netfilter/nf_tables_api.c | 3 +++
 1 file changed, 3 insertions(+)
diff mbox series


diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
index 7e938c7397dd..bd21067f25cf 100644
--- a/net/netfilter/nf_tables_api.c
+++ b/net/netfilter/nf_tables_api.c
@@ -5001,6 +5001,9 @@  static int nf_tables_newset(struct sk_buff *skb, const struct nfnl_info *info,
 		if ((flags & (NFT_SET_EVAL | NFT_SET_OBJECT)) ==
 			return -EOPNOTSUPP;
+			return -EOPNOTSUPP;
 	desc.dtype = 0;