[iptables,8/9] xshared: Free data after printing help

Message ID	20221130191345.14543-9-phil@nwl.cc
State	Accepted
Headers	show Return-Path: <netfilter-devel-owner@vger.kernel.org> From: Phil Sutter <phil@nwl.cc> To: netfilter-devel@vger.kernel.org Subject: [iptables PATCH 8/9] xshared: Free data after printing help Date: Wed, 30 Nov 2022 20:13:44 +0100 Message-Id: <20221130191345.14543-9-phil@nwl.cc> In-Reply-To: <20221130191345.14543-1-phil@nwl.cc> References: <20221130191345.14543-1-phil@nwl.cc> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	Fix for shell testsuite '-V' option \| expand [iptables,0/9] Fix for shell testsuite '-V' option [iptables,1/9] tests: shell: Fix valgrind mode for 0008-unprivileged_0 [iptables,2/9] iptables-restore: Free handle with --test also [iptables,3/9] iptables-xml: Free allocated chain strings [iptables,4/9] nft: Plug memleak in nft_rule_zero_counters() [iptables,5/9] iptables: Plug memleaks in print_firewall() [iptables,6/9] xtables: Introduce xtables_clear_iptables_command_state() [iptables,7/9] iptables: Properly clear iptables_command_state object [iptables,8/9] xshared: Free data after printing help [iptables,9/9] libiptc: Eliminate garbage access

Message ID

20221130191345.14543-9-phil@nwl.cc

State

Accepted

Headers

From: Phil Sutter <phil@nwl.cc>
To: netfilter-devel@vger.kernel.org
Subject: [iptables PATCH 8/9] xshared: Free data after printing help
Date: Wed, 30 Nov 2022 20:13:44 +0100
Message-Id: <20221130191345.14543-9-phil@nwl.cc>
In-Reply-To: <20221130191345.14543-1-phil@nwl.cc>
References: <20221130191345.14543-1-phil@nwl.cc>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

Fix for shell testsuite '-V' option | expand

Commit Message

Phil Sutter Nov. 30, 2022, 7:13 p.m. UTC

This is merely to make valgrind happy, but less noise means less real
issues missed.

Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 iptables/xshared.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/iptables/xshared.c b/iptables/xshared.c
index 2a894c19a011d..f93529b11a319 100644
--- a/iptables/xshared.c
+++ b/iptables/xshared.c
@@ -1543,6 +1543,9 @@  void do_parse(int argc, char *argv[],
 					XTF_TRY_LOAD, &cs->matches);
 
 			xtables_printhelp(cs->matches);
+			xtables_clear_iptables_command_state(cs);
+			xtables_free_opts(1);
+			xtables_fini();
 			exit(0);
 
 			/*

[iptables,8/9] xshared: Free data after printing help

Commit Message

Patch