[iptables,09/13] extensions: ecn: Sanitize xlate callback

Message ID	20221123164350.10502-10-phil@nwl.cc
State	Accepted
Delegated to:	Pablo Neira
Headers	show Return-Path: <netfilter-devel-owner@vger.kernel.org> From: Phil Sutter <phil@nwl.cc> To: netfilter-devel@vger.kernel.org Subject: [iptables PATCH 09/13] extensions: ecn: Sanitize xlate callback Date: Wed, 23 Nov 2022 17:43:46 +0100 Message-Id: <20221123164350.10502-10-phil@nwl.cc> In-Reply-To: <20221123164350.10502-1-phil@nwl.cc> References: <20221123164350.10502-1-phil@nwl.cc> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	Extensions: Review xlate callbacks \| expand [iptables,00/13] Extensions: Review xlate callbacks [iptables,01/13] extensions: libebt_mark: Fix mark target xlate [iptables,02/13] extensions: libebt_mark: Fix xlate test case [iptables,03/13] extensions: libebt_redirect: Fix xlate return code [iptables,04/13] extensions: libipt_ttl: Sanitize xlate callback [iptables,05/13] extensions: CONNMARK: Fix xlate callback [iptables,06/13] extensions: MARK: Sanitize MARK_xlate() [iptables,07/13] extensions: TCPMSS: Use xlate callback for IPv6, too [iptables,08/13] extensions: TOS: Fix v1 xlate callback [iptables,09/13] extensions: ecn: Sanitize xlate callback [iptables,10/13] extensions: tcp: Translate TCP option match [iptables,11/13] extensions: libebt_log: Add comment to clarify xlate callback [iptables,12/13] extensions: frag: Add comment to clarify xlate callback [iptables,13/13] extensions: ipcomp: Add comment to clarify xlate callback

Message ID

20221123164350.10502-10-phil@nwl.cc

State

Accepted

Delegated to:

Pablo Neira

Headers

From: Phil Sutter <phil@nwl.cc>
To: netfilter-devel@vger.kernel.org
Subject: [iptables PATCH 09/13] extensions: ecn: Sanitize xlate callback
Date: Wed, 23 Nov 2022 17:43:46 +0100
Message-Id: <20221123164350.10502-10-phil@nwl.cc>
In-Reply-To: <20221123164350.10502-1-phil@nwl.cc>
References: <20221123164350.10502-1-phil@nwl.cc>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

Extensions: Review xlate callbacks | expand

Commit Message

Phil Sutter Nov. 23, 2022, 4:43 p.m. UTC

Catch unexpected values in einfo->ip_ect.

Fixes: ca42442093d3d ("iptables: extensions: libxt_ecn: Add translation to nft")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 extensions/libxt_ecn.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/extensions/libxt_ecn.c b/extensions/libxt_ecn.c
index ad3c7a0307a0d..83a4acfab7da7 100644
--- a/extensions/libxt_ecn.c
+++ b/extensions/libxt_ecn.c
@@ -156,6 +156,8 @@  static int ecn_xlate(struct xt_xlate *xl,
 		case 3:
 			xt_xlate_add(xl, "ce");
 			break;
+		default:
+			return 0;
 		}
 	}
 	return 1;

[iptables,09/13] extensions: ecn: Sanitize xlate callback

Commit Message

Patch