From patchwork Thu Aug 16 00:03:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pablo Neira Ayuso X-Patchwork-Id: 958060 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netfilter-devel-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=netfilter.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41rRQ853vZz9s8f for ; Thu, 16 Aug 2018 10:04:00 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731224AbeHPC6c (ORCPT ); Wed, 15 Aug 2018 22:58:32 -0400 Received: from mail.us.es ([193.147.175.20]:44022 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731169AbeHPC6c (ORCPT ); Wed, 15 Aug 2018 22:58:32 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 93341C5156 for ; Thu, 16 Aug 2018 02:01:34 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 8296EDA727 for ; Thu, 16 Aug 2018 02:01:34 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 77E14DA737; Thu, 16 Aug 2018 02:01:34 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 7406EDA727 for ; Thu, 16 Aug 2018 02:01:32 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Thu, 16 Aug 2018 02:01:32 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from salvia.here (sys.soleta.eu [212.170.55.40]) (Authenticated sender: pneira@us.es) by entrada.int (Postfix) with ESMTPA id 598A84265A4E for ; Thu, 16 Aug 2018 02:01:32 +0200 (CEST) X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: netfilter-devel@vger.kernel.org Subject: [PATCH nft 1/4] statement: incorrect spacing in set reference Date: Thu, 16 Aug 2018 02:03:47 +0200 Message-Id: <20180816000350.12226-1-pablo@netfilter.org> X-Mailer: git-send-email 2.11.0 X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org chain y { type filter hook output priority filter; policy accept; update @xyz{ ip daddr } ^^ Missing space between set reference and the element statement. This does not break restoring the ruleset but it is inconsistent to the viewer. There is also an extra space after the element statement that is enclosed in brackets. Signed-off-by: Pablo Neira Ayuso --- src/statement.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/statement.c b/src/statement.c index 3040476fdfa1..cec83c19e529 100644 --- a/src/statement.c +++ b/src/statement.c @@ -630,7 +630,7 @@ static void set_stmt_print(const struct stmt *stmt, struct output_ctx *octx) expr_print(stmt->set.set, octx); nft_print(octx, " { "); expr_print(stmt->set.key, octx); - nft_print(octx, " } "); + nft_print(octx, " }"); } static void set_stmt_destroy(struct stmt *stmt) @@ -656,11 +656,11 @@ static void map_stmt_print(const struct stmt *stmt, struct output_ctx *octx) { nft_print(octx, "%s ", set_stmt_op_names[stmt->map.op]); expr_print(stmt->map.set, octx); - nft_print(octx, "{ "); + nft_print(octx, " { "); expr_print(stmt->map.map->map->key, octx); nft_print(octx, " : "); expr_print(stmt->map.map->mappings, octx); - nft_print(octx, " } "); + nft_print(octx, " }"); } static void map_stmt_destroy(struct stmt *stmt)