diff mbox series

netfilter: Remove unnecessary conversion to bool

Message ID 1604650813-1132-1-git-send-email-kaixuxia@tencent.com
State Accepted
Delegated to: Pablo Neira
Headers show
Series netfilter: Remove unnecessary conversion to bool | expand

Commit Message

kaixuxia Nov. 6, 2020, 8:20 a.m. UTC
From: Kaixu Xia <kaixuxia@tencent.com>

Here we could use the '!=' expression to fix the following coccicheck
warning:

./net/netfilter/xt_nfacct.c:30:41-46: WARNING: conversion to bool not needed here

Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
 net/netfilter/xt_nfacct.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pablo Neira Ayuso Dec. 1, 2020, 8:46 a.m. UTC | #1
On Fri, Nov 06, 2020 at 04:20:13PM +0800, xiakaixu1987@gmail.com wrote:
> From: Kaixu Xia <kaixuxia@tencent.com>
> 
> Here we could use the '!=' expression to fix the following coccicheck
> warning:
> 
> ./net/netfilter/xt_nfacct.c:30:41-46: WARNING: conversion to bool not needed here

Applied.
diff mbox series

Patch

diff --git a/net/netfilter/xt_nfacct.c b/net/netfilter/xt_nfacct.c
index a97c2259bbc8..7c6bf1c16813 100644
--- a/net/netfilter/xt_nfacct.c
+++ b/net/netfilter/xt_nfacct.c
@@ -27,7 +27,7 @@  static bool nfacct_mt(const struct sk_buff *skb, struct xt_action_param *par)
 
 	overquota = nfnl_acct_overquota(xt_net(par), info->nfacct);
 
-	return overquota == NFACCT_UNDERQUOTA ? false : true;
+	return overquota != NFACCT_UNDERQUOTA;
 }
 
 static int