From patchwork Thu May 18 14:16:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Alin_N=C4=83stac?= X-Patchwork-Id: 764018 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wTCsv4B1jz9s4s for ; Fri, 19 May 2017 00:16:35 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="lNGVeMdU"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756003AbdEROQe (ORCPT ); Thu, 18 May 2017 10:16:34 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:34765 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755790AbdEROQd (ORCPT ); Thu, 18 May 2017 10:16:33 -0400 Received: by mail-it0-f67.google.com with SMTP id d68so4775361ita.1 for ; Thu, 18 May 2017 07:16:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=6a3kx6YC5JhRwtEV7ktET6pQJp8M5rKRt8j12NkPtts=; b=lNGVeMdUXVB1EvJFfKJGwBr6e0jIu78x1UrxhbiptDIwF3O2A69fS9Dj5Xe1RtSRI+ BKMO6kc6W3e8eWlsuc7X5I/VRjiRESRLYzBVNkmR6V+f65klSdhuL3Lzg38wz164ZfGx hZ3UiR+PD6xvUwnFfEdhdIGSW1AeT4XYj5Yy9aZ1zf3uHPfzHZy5IXJkeasmNNZBn9yj 6qYMR3Wan6U3whOMtjWkTOd47MCYj4wq+mVT4U6ST6eQQtZAATtxiGXmb7NNrlJyjId7 rpTeQ9kxUfKT1uQW+DddaTwRl/omW1+ckNBpLVxG2Tk1Kex+WveJIpLkCuV1QL87MVbc GAcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=6a3kx6YC5JhRwtEV7ktET6pQJp8M5rKRt8j12NkPtts=; b=StPrJHymgo+OLk9QhgcyHbNmcxVC/B8VdBoWc0drdRUFPYQhWuY1D0miF99ClhOKuW mZzMlphmb6fW6CkiW8+n5B0kgsFLm6XIHGdgw/27o83v2Q+HIc9RMDljeD90+79fd3XQ UcF3Sh0BQoPyvO5ZSoHJE9qZo/8ubqOrPE4HN/TlkGfQ/VmYeWGoD6b9VHmG7Cudd+Tg cwUUdUrlM9WYGAHMVMY/oQ4x7ExO7DTyO3FPXkEHQYPPBa7A6SAaPEXnNp1glCZ7fsiG p+hc1CTsPPGNI4DlOX2AArf8+hRAjrtWjC7xXot+bRAf9gWZ329jB9au6zV+X359DxF8 9Faw== X-Gm-Message-State: AODbwcAMjdIheN023tLOVYy11mZwg928gdeHMwZXIpoUf82GJ67UFofm /V+XlgxEu4HiQZw3 X-Received: by 10.36.28.139 with SMTP id c133mr23619558itc.117.1495116992671; Thu, 18 May 2017 07:16:32 -0700 (PDT) Received: from cplx1037.edegem.eu.thmulti.com ([2001:4158:f012:a50:2a10:7bff:fec5:6f08]) by smtp.gmail.com with ESMTPSA id h142sm8718257ith.31.2017.05.18.07.16.31 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 18 May 2017 07:16:32 -0700 (PDT) From: Alin Nastac To: netfilter-devel@vger.kernel.org Subject: [PATCH v2] extensions: libxt_hashlimit: fix 64-bit printf formats Date: Thu, 18 May 2017 16:16:25 +0200 Message-Id: <1495116985-27115-1-git-send-email-alin.nastac@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Furthermore, this extension use a mix of PRIu64 and %llu formats for uint64_t values. IMO it should use only one, for the sake of consistency. Signed-off-by: Alin Nastac --- extensions/libxt_hashlimit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/libxt_hashlimit.c b/extensions/libxt_hashlimit.c index 9e63e1e..970bad9 100644 --- a/extensions/libxt_hashlimit.c +++ b/extensions/libxt_hashlimit.c @@ -942,7 +942,7 @@ static void print_packets_rate_xlate(struct xt_xlate *xl, uint64_t avg, _rates[i].mult / avg < _rates[i].mult % avg) break; - xt_xlate_add(xl, " %llu/%s burst %lu packets", + xt_xlate_add(xl, " %"PRIu64"/%s burst %"PRIu64" packets", _rates[i-1].mult / avg, _rates[i-1].name, burst); }