diff mbox

[iptables] configure: make libmnl and libnftnl hard requirements

Message ID 1461698878-4459-1-git-send-email-giuseppe@glongo.it
State Accepted
Delegated to: Jozsef Kadlecsik
Headers show

Commit Message

Giuseppe Longo April 26, 2016, 7:27 p.m. UTC 
From: Giuseppe Longo <giuseppelng@gmail.com>

Iptables building is broken if either libmnl orlibnftnl
is not installed on the system.

Configure script actually checks if libmnl and libnftnl are installed,
but doesn't exit if they are not.

Signed-off-by: Giuseppe Longo <giuseppelng@gmail.com>
---
 configure.ac | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

Comments

Pablo Neira Ayuso April 27, 2016, 5:09 p.m. UTC | #1 
On Tue, Apr 26, 2016 at 09:27:58PM +0200, Giuseppe Longo wrote:
> From: Giuseppe Longo <giuseppelng@gmail.com>
> 
> Iptables building is broken if either libmnl orlibnftnl
> is not installed on the system.
> 
> Configure script actually checks if libmnl and libnftnl are installed,
> but doesn't exit if they are not.

Applied, thanks Giuseppe.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/configure.ac b/configure.ac
index 12bffa9..b170add 100644
--- a/configure.ac
+++ b/configure.ac
@@ -122,8 +122,26 @@  AM_CONDITIONAL([HAVE_LIBNFNETLINK], [test "$nfnetlink" = 1])
 if test "x$enable_nftables" = "xyes"; then
 	PKG_CHECK_MODULES([libmnl], [libmnl >= 1.0], [mnl=1], [mnl=0])
 
+	if test "$mnl" = 0;
+	then
+		echo "*** Error: No suitable libmnl found. ***"
+		echo "    Please install the 'libmnl' package"
+		echo "    Or consider --disable-nftables to skip"
+		echo "    iptables-compat over nftables support."
+		exit 1
+	fi
+
 	PKG_CHECK_MODULES([libnftnl], [libnftnl >= 1.0.5], [nftables=1], [nftables=0])
 
+	if test "$nftables" = 0;
+	then
+		echo "*** Error: no suitable libnftnl found. ***"
+		echo "    Please install the 'libnftnl' package"
+		echo "    Or consider --disable-nftables to skip"
+		echo "    iptables-compat over nftables support."
+		exit 1
+	fi
+
 	AM_PROG_LEX
 	AC_PROG_YACC