| Message ID | 1459838692-17303-1-git-send-email-mart.frauenlob@chello.at |
|---|---|
| State | Changes Requested |
| Delegated to: | Pablo Neira |
| Headers | show |
On Tue, Apr 05, 2016 at 08:44:52AM +0200, Mart Frauenlob wrote: > The old options --src and --dst were still defined at two places. > Replaced with according --orig-src and --orig-dst entry. --src is valid shortcut. This breaks backward compatibility. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07.04.2016 11:40, Pablo Neira Ayuso wrote: > On Tue, Apr 05, 2016 at 08:44:52AM +0200, Mart Frauenlob wrote: >> The old options --src and --dst were still defined at two places. >> Replaced with according --orig-src and --orig-dst entry. > > --src is valid shortcut. > > This breaks backward compatibility. > ok, so I'll update the docs, to also show --src? -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Apr 07, 2016 at 07:24:55PM +0200, Mart Frauenlob wrote: > On 07.04.2016 11:40, Pablo Neira Ayuso wrote: > >On Tue, Apr 05, 2016 at 08:44:52AM +0200, Mart Frauenlob wrote: > >>The old options --src and --dst were still defined at two places. > >>Replaced with according --orig-src and --orig-dst entry. > > > >--src is valid shortcut. > > > >This breaks backward compatibility. > > ok, so I'll update the docs, to also show --src? yes please, thanks :) -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/src/conntrack.c b/src/conntrack.c index b384e07..076d8a3 100644 --- a/src/conntrack.c +++ b/src/conntrack.c @@ -282,8 +282,8 @@ enum ct_options { CT_OPT_ORIG_ZONE | CT_OPT_REPL_ZONE) static const char *optflags[NUMBER_OF_OPT] = { - [CT_OPT_ORIG_SRC_BIT] = "src", - [CT_OPT_ORIG_DST_BIT] = "dst", + [CT_OPT_ORIG_SRC_BIT] = "orig-src", + [CT_OPT_ORIG_DST_BIT] = "orig-dst", [CT_OPT_REPL_SRC_BIT] = "reply-src", [CT_OPT_REPL_DST_BIT] = "reply-dst", [CT_OPT_PROTO_BIT] = "protonum", @@ -2468,7 +2468,7 @@ int main(int argc, char *argv[]) case -1: case 0: exit_error(PARAMETER_PROBLEM, "you have to specify " - "`--src' and `--dst'"); + "`--orig-src' and `--orig-dst'"); break; case 1: exit_error(PARAMETER_PROBLEM, "you have to specify "
The old options --src and --dst were still defined at two places. Replaced with according --orig-src and --orig-dst entry. Signed-off-by: Mart Frauenlob <mart.frauenlob@chello.at> --- src/conntrack.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)