From patchwork Tue Oct 8 10:04:08 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gao feng X-Patchwork-Id: 281390 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 8211B2C00B6 for ; Tue, 8 Oct 2013 21:03:29 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752704Ab3JHKD1 (ORCPT ); Tue, 8 Oct 2013 06:03:27 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:2235 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751869Ab3JHKD1 (ORCPT ); Tue, 8 Oct 2013 06:03:27 -0400 X-IronPort-AV: E=Sophos;i="4.90,1056,1371052800"; d="scan'208";a="8688973" Received: from unknown (HELO tang.cn.fujitsu.com) ([10.167.250.3]) by song.cn.fujitsu.com with ESMTP; 08 Oct 2013 17:59:43 +0800 Received: from fnstmail02.fnst.cn.fujitsu.com (tang.cn.fujitsu.com [127.0.0.1]) by tang.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id r98A2xvw017395 for ; Tue, 8 Oct 2013 18:02:59 +0800 Received: from Donkey.fnst.cn.fujitsu.com ([10.167.226.30]) by fnstmail02.fnst.cn.fujitsu.com (Lotus Domino Release 8.5.3) with ESMTP id 2013100818005459-2073646 ; Tue, 8 Oct 2013 18:00:54 +0800 From: Gao feng To: netfilter-devel@vger.kernel.org Cc: Gao feng Subject: [PATCH] nfnetlink: use rcu_assign_pointer in nfnetlink_subsys_unregister Date: Tue, 8 Oct 2013 18:04:08 +0800 Message-Id: <1381226648-10959-1-git-send-email-gaofeng@cn.fujitsu.com> X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/10/08 18:00:54, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/10/08 18:00:55, Serialize complete at 2013/10/08 18:00:55 Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Though I don't face an oops, but it is more safer to set table's subsys through rcu_assign_pointer. Signed-off-by: Gao feng --- net/netfilter/nfnetlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetlink.c index 572d87d..3cd2fe6 100644 --- a/net/netfilter/nfnetlink.c +++ b/net/netfilter/nfnetlink.c @@ -78,7 +78,7 @@ EXPORT_SYMBOL_GPL(nfnetlink_subsys_register); int nfnetlink_subsys_unregister(const struct nfnetlink_subsystem *n) { nfnl_lock(n->subsys_id); - table[n->subsys_id].subsys = NULL; + rcu_assign_pointer(table[n->subsys_id].subsys, NULL); nfnl_unlock(n->subsys_id); synchronize_rcu(); return 0;