From patchwork Tue Apr 3 09:50:56 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pablo Neira Ayuso X-Patchwork-Id: 150361 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C5437B6FE2 for ; Tue, 3 Apr 2012 19:51:42 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752679Ab2DCJvj (ORCPT ); Tue, 3 Apr 2012 05:51:39 -0400 Received: from mail.us.es ([193.147.175.20]:55616 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751656Ab2DCJvj (ORCPT ); Tue, 3 Apr 2012 05:51:39 -0400 Received: (qmail 17508 invoked from network); 3 Apr 2012 11:51:37 +0200 Received: from unknown (HELO us.es) (192.168.2.12) by us.es with SMTP; 3 Apr 2012 11:51:37 +0200 Received: (qmail 4567 invoked by uid 507); 3 Apr 2012 09:51:37 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on antivirus2 X-Spam-Level: X-Spam-Status: No, score=-99.2 required=7.5 tests=BAYES_50, USER_IN_WHITELIST autolearn=disabled version=3.3.1 Received: from 127.0.0.1 by antivirus2 (envelope-from , uid 501) with qmail-scanner-2.08 (clamdscan: 0.97.4/14735. Clear:RC:1(127.0.0.1):. Processed in 0.023755 secs); 03 Apr 2012 09:51:37 -0000 Received: from unknown (HELO antivirus2) (127.0.0.1) by us.es with SMTP; 3 Apr 2012 09:51:37 -0000 Received: from 192.168.1.13 (192.168.1.13) by antivirus2 (F-Secure/fsigk_smtp/407/antivirus2); Tue, 03 Apr 2012 11:51:37 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/407/antivirus2) Received: (qmail 20277 invoked from network); 3 Apr 2012 11:51:36 +0200 Received: from berligate.hmw-consulting.de (HELO soleta.de.gnumonks.org) (pneira@us.es@83.236.178.202) by us.es with SMTP; 3 Apr 2012 11:51:36 +0200 From: pablo@netfilter.org To: netfilter-devel@vger.kernel.org Cc: davem@davemloft.net Subject: [PATCH 1/3] netfilter: xt_LOG: don't use xchg() for simple assignment Date: Tue, 3 Apr 2012 11:50:56 +0200 Message-Id: <1333446658-2335-2-git-send-email-pablo@netfilter.org> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1333446658-2335-1-git-send-email-pablo@netfilter.org> References: <1333446658-2335-1-git-send-email-pablo@netfilter.org> Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org From: Jan Beulich At least on ia64 the (bogus) use of xchg() here results in the compiler warning about an unused expression result. As only an assignment is intended here, convert it to such. Signed-off-by: Jan Beulich Acked-by: Eric Dumazet Signed-off-by: Pablo Neira Ayuso --- include/net/netfilter/xt_log.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/net/netfilter/xt_log.h b/include/net/netfilter/xt_log.h index 7e1544e..9d9756c 100644 --- a/include/net/netfilter/xt_log.h +++ b/include/net/netfilter/xt_log.h @@ -47,7 +47,7 @@ static void sb_close(struct sbuff *m) if (likely(m != &emergency)) kfree(m); else { - xchg(&emergency_ptr, m); + emergency_ptr = m; local_bh_enable(); } }